Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58433/?format=api
{ "id": 58433, "url": "https://patches.dpdk.org/api/patches/58433/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-12-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:55", "name": "[11/17] net/bnxt: check device is started before flow creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3514b489454520f4e07d609a94627986b397e763", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "https://patches.dpdk.org/api/series/6209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "https://patches.dpdk.org/series/6209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58433/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 511851EB2D;\n\tTue, 3 Sep 2019 04:19:32 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 57B0D1E980\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 1C01830C1FF;\n\tMon, 2 Sep 2019 19:19:02 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 1AFBEAC06AB;\n\tMon, 2 Sep 2019 19:19:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 1C01830C1FF", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477142;\n\tbh=UWW8Hc6/Jl4LdNRa1GR6NkagXQJ8bnxdTHwuihKsDOE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W/EMohOxlza2vg3x1P22RUgcnlMcOGhFZIM9aFOB2EdL/ALl8x39WhezmcMHEsX/A\n\t7jWRs5ClCZzeC78O1HtsMWi0DHg00RiO8ylw67e3qAmwTvX9LHya4XkV3+DCaDZOcd\n\tk0au4Z1txvjZyz02JbGYfCe6nE8be4zyLqpU7NNI=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Stephen Hemminger <stephen@networkplumber.org>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>,\n\tVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:55 -0700", "Message-Id": "<20190903021901.25895-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 11/17] net/bnxt: check device is started before\n\tflow creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Check device is started before flow creation.\nSince the vnic data structures aren't created until device start,\nthe driver dereferences NULL vnic if flow creation is attempted before\ndevice is started,\n\nReported-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 578081890..71a5266ce 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -1466,6 +1466,15 @@ bnxt_flow_create(struct rte_eth_dev *dev,\n \tint ret = 0;\n \tuint32_t tun_type;\n \n+\tif (!dev->data->dev_started) {\n+\t\trte_flow_error_set(error,\n+\t\t\t\t EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t NULL,\n+\t\t\t\t \"Device must be started\");\n+\t\treturn NULL;\n+\t}\n+\n \tflow = rte_zmalloc(\"bnxt_flow\", sizeof(struct rte_flow), 0);\n \tif (!flow) {\n \t\trte_flow_error_set(error, ENOMEM,\n", "prefixes": [ "11/17" ] }