Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58430/?format=api
https://patches.dpdk.org/api/patches/58430/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-10-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-10-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-10-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:53", "name": "[09/17] net/bnxt: allow only unicast MAC address filter creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9a9604b883b8ad52fff2a946a3b937396d02d538", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-10-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "https://patches.dpdk.org/api/series/6209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "https://patches.dpdk.org/series/6209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58430/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 98F2F1EB06;\n\tTue, 3 Sep 2019 04:19:27 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id CF8491E980\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:08 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 44D2F30C1FD;\n\tMon, 2 Sep 2019 19:19:01 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A76F9AC06AB;\n\tMon, 2 Sep 2019 19:19:07 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 44D2F30C1FD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477141;\n\tbh=D8B2YgK6G0JGKi0HAoS0sIeGNkcfIGE5L75i0b3PiUg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FPOf/fbWKlLr8xykkydKG06M/8wjNh34i6h0GirMe7JQWztfCImO46L9yjSTxLyn2\n\tvOQ9H6XCg/otnpE/xwcn19APulVa2wPgj9DGfxqvz/m5igtGJQaz6oZj57Sp5TNHas\n\txwh2R0jZP1CRgMEv4QmM+I7z2IeA4VQubB4uHCVQ=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:53 -0700", "Message-Id": "<20190903021901.25895-10-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 09/17] net/bnxt: allow only unicast MAC address\n\tfilter creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Check if the application is trying to create filters using\nbroadcast and multicast MAC address and reject it.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex aed822ee3..578081890 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -217,6 +217,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->dst)) {\n+\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->dst)) {\n+\t\t\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t\t\t EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t item,\n+\t\t\t\t\t\t\t \"DMAC is invalid\");\n+\t\t\t\t\treturn -rte_errno;\n+\t\t\t\t}\n \t\t\t\trte_memcpy(filter->dst_macaddr,\n \t\t\t\t\t ð_spec->dst, RTE_ETHER_ADDR_LEN);\n \t\t\t\ten |= use_ntuple ?\n@@ -231,6 +239,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->src)) {\n+\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->src)) {\n+\t\t\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t\t\t EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t item,\n+\t\t\t\t\t\t\t \"SMAC is invalid\");\n+\t\t\t\t\treturn -rte_errno;\n+\t\t\t\t}\n \t\t\t\trte_memcpy(filter->src_macaddr,\n \t\t\t\t\t ð_spec->src, RTE_ETHER_ADDR_LEN);\n \t\t\t\ten |= use_ntuple ?\n", "prefixes": [ "09/17" ] }{ "id": 58430, "url": "