Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58314/?format=api
{ "id": 58314, "url": "https://patches.dpdk.org/api/patches/58314/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190830163537.32704-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190830163537.32704-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190830163537.32704-8-ajit.khaparde@broadcom.com", "date": "2019-08-30T16:35:31", "name": "[v2,07/13] net/bnxt: map status registers for FW health monitoring", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b5e4122bb08103eb9d4c5171c2a4e379054d39e7", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190830163537.32704-8-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6182, "url": "https://patches.dpdk.org/api/series/6182/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6182", "date": "2019-08-30T16:35:24", "name": "bnxt patchset to support device error recovery", "version": 2, "mbox": "https://patches.dpdk.org/series/6182/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58314/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58314/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE7AB1E9D0;\n\tFri, 30 Aug 2019 18:36:10 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 6CE521E998\n\tfor <dev@dpdk.org>; Fri, 30 Aug 2019 18:35:48 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 6F4DA30C069;\n\tFri, 30 Aug 2019 09:35:41 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A65BDAC06AD;\n\tFri, 30 Aug 2019 09:35:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 6F4DA30C069", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567182941;\n\tbh=aaoStP9WmsGqyhyF4A3L667/HstfWNw6FGRxPRLLRpk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZtMJdHSjmJ7QSw6xdR70yUd0TLmx5wrcgAugcS0+l2vf76bzOoaBXzCoEYadD6dqn\n\tQiSwv80ySvxvY2CXdU2auVCYuoObWE1X8MjlJMEH8DpomReF60frLQyGOUmVyFec8+\n\tsyPmvdPWei0wS0rB/wTjtOS4b2IUK6rjhIx9cueE=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Fri, 30 Aug 2019 09:35:31 -0700", "Message-Id": "<20190830163537.32704-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190830163537.32704-1-ajit.khaparde@broadcom.com>", "References": "<2a851a62-f5a1-7061-edb4-412db0d335ce@intel.com>\n\t<20190830163537.32704-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 07/13] net/bnxt: map status registers for FW\n\thealth monitoring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nHWRM_ERROR_RECOVERY_QCFG command returns the FW status registers offset\nfor periodic firmware health check monitoring. Map them to GRC window 2.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 22 ++++++++++++++++-\n drivers/net/bnxt/bnxt_ethdev.c | 44 ++++++++++++++++++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 4 ++++\n 3 files changed, 69 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 19bd13a7f..1da09569d 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -354,7 +354,9 @@ struct bnxt_error_recovery_info {\n #define BNXT_FW_HEARTBEAT_CNT_REG\t1\n #define BNXT_FW_RECOVERY_CNT_REG\t2\n #define BNXT_FW_RESET_INPROG_REG\t3\n-\tuint32_t\tstatus_regs[4];\n+#define BNXT_FW_STATUS_REG_CNT\t\t4\n+\tuint32_t\tstatus_regs[BNXT_FW_STATUS_REG_CNT];\n+\tuint32_t\tmapped_status_regs[BNXT_FW_STATUS_REG_CNT];\n \tuint32_t\treset_inprogress_reg_mask;\n #define BNXT_NUM_RESET_REG\t16\n \tuint8_t\t\treg_array_cnt;\n@@ -366,6 +368,22 @@ struct bnxt_error_recovery_info {\n \tuint32_t\tflags;\n };\n \n+/* address space location of register */\n+#define BNXT_FW_STATUS_REG_TYPE_MASK\t3\n+/* register is located in PCIe config space */\n+#define BNXT_FW_STATUS_REG_TYPE_CFG\t0\n+/* register is located in GRC address space */\n+#define BNXT_FW_STATUS_REG_TYPE_GRC\t1\n+/* register is located in BAR0 */\n+#define BNXT_FW_STATUS_REG_TYPE_BAR0\t2\n+/* register is located in BAR1 */\n+#define BNXT_FW_STATUS_REG_TYPE_BAR1\t3\n+\n+#define BNXT_FW_STATUS_REG_TYPE(reg)\t((reg) & BNXT_FW_STATUS_REG_TYPE_MASK)\n+#define BNXT_FW_STATUS_REG_OFF(reg)\t((reg) & ~BNXT_FW_STATUS_REG_TYPE_MASK)\n+\n+#define BNXT_GRCP_WINDOW_2_BASE\t\t0x2000\n+\n #define BNXT_HWRM_SHORT_REQ_LEN\t\tsizeof(struct hwrm_short_input)\n struct bnxt {\n \tvoid\t\t\t\t*bar0;\n@@ -510,6 +528,8 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete);\n int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg);\n int is_bnxt_in_error(struct bnxt *bp);\n \n+int bnxt_map_fw_health_status_regs(struct bnxt *bp);\n+\n bool is_bnxt_supported(struct rte_eth_dev *dev);\n bool bnxt_stratus_device(struct bnxt *bp);\n extern const struct rte_flow_ops bnxt_flow_ops;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7a1142947..a0de259da 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3496,6 +3496,49 @@ static const struct eth_dev_ops bnxt_dev_ops = {\n \t.timesync_read_tx_timestamp = bnxt_timesync_read_tx_timestamp,\n };\n \n+int bnxt_map_fw_health_status_regs(struct bnxt *bp)\n+{\n+\tstruct bnxt_error_recovery_info *info = bp->recovery_info;\n+\tuint32_t reg_base = 0xffffffff;\n+\tint i;\n+\n+\t/* Only pre-map the monitoring GRC registers using window 2 */\n+\tfor (i = 0; i < BNXT_FW_STATUS_REG_CNT; i++) {\n+\t\tuint32_t reg = info->status_regs[i];\n+\n+\t\tif (BNXT_FW_STATUS_REG_TYPE(reg) != BNXT_FW_STATUS_REG_TYPE_GRC)\n+\t\t\tcontinue;\n+\n+\t\tif (reg_base == 0xffffffff)\n+\t\t\treg_base = reg & 0xfffff000;\n+\t\tif ((reg & 0xfffff000) != reg_base)\n+\t\t\treturn -ERANGE;\n+\n+\t\t/* Use mask 0xffc as the Lower 2 bits indicates\n+\t\t * address space location\n+\t\t */\n+\t\tinfo->mapped_status_regs[i] = BNXT_GRCP_WINDOW_2_BASE +\n+\t\t\t\t\t\t(reg & 0xffc);\n+\t}\n+\n+\tif (reg_base == 0xffffffff)\n+\t\treturn 0;\n+\n+\trte_write32(reg_base, (uint8_t *)bp->bar0 +\n+\t\t BNXT_GRCPF_REG_WINDOW_BASE_OUT + 4);\n+\n+\treturn 0;\n+}\n+\n+static void bnxt_unmap_fw_health_status_regs(struct bnxt *bp)\n+{\n+\tif (!(bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY))\n+\t\treturn;\n+\n+\trte_write32(0, (uint8_t *)bp->bar0 +\n+\t\t BNXT_GRCPF_REG_WINDOW_BASE_OUT + 4);\n+}\n+\n static void bnxt_dev_cleanup(struct bnxt *bp)\n {\n \tbnxt_set_hwrm_link_config(bp, false);\n@@ -4226,6 +4269,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)\n \tbnxt_free_int(bp);\n \tbnxt_free_mem(bp, reconfig_dev);\n \tbnxt_hwrm_func_buf_unrgtr(bp);\n+\tbnxt_unmap_fw_health_status_regs(bp);\n \trc = bnxt_hwrm_func_driver_unregister(bp, 0);\n \tbp->flags &= ~BNXT_FLAG_REGISTERED;\n \tbnxt_free_ctx_mem(bp);\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex e2c993936..2d9c43c98 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4767,6 +4767,10 @@ int bnxt_hwrm_error_recovery_qcfg(struct bnxt *bp)\n err:\n \tHWRM_UNLOCK();\n \n+\t/* Map the FW status registers */\n+\tif (!rc)\n+\t\trc = bnxt_map_fw_health_status_regs(bp);\n+\n \tif (rc) {\n \t\trte_free(bp->recovery_info);\n \t\tbp->recovery_info = NULL;\n", "prefixes": [ "v2", "07/13" ] }