Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58229/?format=api
https://patches.dpdk.org/api/patches/58229/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190829080000.20806-12-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829080000.20806-12-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829080000.20806-12-maxime.coquelin@redhat.com", "date": "2019-08-29T07:59:56", "name": "[11/15] net/virtio: add vDPA op to stop and close the device", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "2d478c00753328eb90bb168e7a4a17675c659643", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190829080000.20806-12-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 6163, "url": "https://patches.dpdk.org/api/series/6163/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6163", "date": "2019-08-29T07:59:45", "name": "Introduce Virtio vDPA driver", "version": 1, "mbox": "https://patches.dpdk.org/series/6163/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58229/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/58229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E4DD41DFEA;\n\tThu, 29 Aug 2019 10:00:58 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id DD4E31D50C;\n\tThu, 29 Aug 2019 10:00:56 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4F6608553A;\n\tThu, 29 Aug 2019 08:00:56 +0000 (UTC)", "from localhost.localdomain (ovpn-112-52.ams2.redhat.com\n\t[10.36.112.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CAC15D6B2;\n\tThu, 29 Aug 2019 08:00:51 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com, zhihong.wang@intel.com, amorenoz@redhat.com,\n\txiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 29 Aug 2019 09:59:56 +0200", "Message-Id": "<20190829080000.20806-12-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "References": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]); Thu, 29 Aug 2019 08:00:56 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 11/15] net/virtio: add vDPA op to stop and close\n\tthe device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch implements the vDPA .dev_close() callback.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_vdpa.c | 52 ++++++++++++++++++++++++++++++++\n 1 file changed, 52 insertions(+)", "diff": "diff --git a/drivers/net/virtio/virtio_vdpa.c b/drivers/net/virtio/virtio_vdpa.c\nindex 13b4dd07d..691844906 100644\n--- a/drivers/net/virtio/virtio_vdpa.c\n+++ b/drivers/net/virtio/virtio_vdpa.c\n@@ -436,6 +436,33 @@ virtio_vdpa_start(struct virtio_vdpa_device *dev)\n \treturn ret;\n }\n \n+static void\n+virtio_vdpa_stop(struct virtio_vdpa_device *dev)\n+{\n+\tstruct virtio_hw *hw = &dev->hw;\n+\tuint32_t i, nr_vring;\n+\tint vid = dev->vid;\n+\tstruct rte_vhost_vring vr;\n+\tuint16_t last_used_idx, last_avail_idx;\n+\n+\tnr_vring = rte_vhost_get_vring_num(vid);\n+\n+\tvtpci_reset(hw);\n+\n+\tfor (i = 0; i < nr_vring; i++) {\n+\t\trte_vhost_get_vhost_vring(vid, i, &vr);\n+\n+\t\tlast_used_idx = vr.used->idx;\n+\t\tlast_avail_idx = vr.avail->idx;\n+\n+\t\trte_vhost_set_vring_base(vid, i, last_avail_idx,\n+\t\t\t\tlast_used_idx);\n+\t}\n+\n+\trte_free(dev->vqs);\n+\tdev->vqs = NULL;\n+}\n+\n static int\n virtio_vdpa_dev_config(int vid)\n {\n@@ -470,11 +497,36 @@ virtio_vdpa_dev_config(int vid)\n \treturn ret;\n }\n \n+static int\n+virtio_vdpa_dev_close(int vid)\n+{\n+\tint did;\n+\tstruct internal_list *list;\n+\tstruct virtio_vdpa_device *dev;\n+\n+\tdid = rte_vhost_get_vdpa_device_id(vid);\n+\tlist = find_internal_resource_by_did(did);\n+\tif (list == NULL) {\n+\t\tDRV_LOG(ERR, \"Invalid device id: %d\", did);\n+\t\treturn -1;\n+\t}\n+\n+\tdev = list->dev;\n+\n+\trte_spinlock_lock(&dev->lock);\n+\tvirtio_vdpa_stop(dev);\n+\tvirtio_vdpa_dma_map(dev, 0);\n+\trte_spinlock_unlock(&dev->lock);\n+\n+\treturn 0;\n+}\n+\n static struct rte_vdpa_dev_ops virtio_vdpa_ops = {\n \t.get_queue_num = virtio_vdpa_get_queue_num,\n \t.get_features = virtio_vdpa_get_features,\n \t.get_protocol_features = virtio_vdpa_get_protocol_features,\n \t.dev_conf = virtio_vdpa_dev_config,\n+\t.dev_close = virtio_vdpa_dev_close,\n };\n \n static inline int\n", "prefixes": [ "11/15" ] }{ "id": 58229, "url": "