Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58157/?format=api
https://patches.dpdk.org/api/patches/58157/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190829023656.8220-22-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829023656.8220-22-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829023656.8220-22-qi.z.zhang@intel.com", "date": "2019-08-29T02:36:14", "name": "[v2,21/63] net/ice/base: fix type-mismatch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "60844cdab5fa42a32fc62aed0ae91913bb39090c", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190829023656.8220-22-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6158, "url": "https://patches.dpdk.org/api/series/6158/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6158", "date": "2019-08-29T02:35:54", "name": "[v2,01/63] net/ice/base: enhance NVM read", "version": 2, "mbox": "https://patches.dpdk.org/series/6158/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58157/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58157/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7495F1D14A;\n\tThu, 29 Aug 2019 04:35:11 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 9F51C1C2A4;\n\tThu, 29 Aug 2019 04:34:54 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Aug 2019 19:34:54 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga004.jf.intel.com with ESMTP; 28 Aug 2019 19:34:52 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,442,1559545200\"; d=\"scan'208\";a=\"332363619\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tstable@dpdk.org, Jeb Cramer <jeb.j.cramer@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Thu, 29 Aug 2019 10:36:14 +0800", "Message-Id": "<20190829023656.8220-22-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190829023656.8220-1-qi.z.zhang@intel.com>", "References": "<20190826105105.19121-1-qi.z.zhang@intel.com>\n\t<20190829023656.8220-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 21/63] net/ice/base: fix type-mismatch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The iterators are u8, but the values being compared against are u16s.\nIt may not ever be the case that the comparison is against a value\nlarger than the upper bound of the smaller type, but code analysis tools\ndon't know that.\n\nFixes: 93e84b1bfc92 (\"net/ice/base: add basic Tx scheduler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jeb Cramer <jeb.j.cramer@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_sched.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c\nindex 84a033f1c..01c8defae 100644\n--- a/drivers/net/ice/base/ice_sched.c\n+++ b/drivers/net/ice/base/ice_sched.c\n@@ -735,7 +735,7 @@ ice_sched_del_rl_profile(struct ice_hw *hw,\n */\n static void ice_sched_clear_rl_prof(struct ice_port_info *pi)\n {\n-\tu8 ln;\n+\tu16 ln;\n \n \tfor (ln = 0; ln < pi->hw->num_tx_sched_layers; ln++) {\n \t\tstruct ice_aqc_rl_profile_info *rl_prof_elem;\n@@ -2181,12 +2181,11 @@ static enum ice_status\n ice_sched_move_nodes(struct ice_port_info *pi, struct ice_sched_node *parent,\n \t\t u16 num_items, u32 *list)\n {\n+\tenum ice_status status = ICE_SUCCESS;\n \tstruct ice_aqc_move_elem *buf;\n \tstruct ice_sched_node *node;\n-\tenum ice_status status = ICE_SUCCESS;\n+\tu16 i, grps_movd = 0;\n \tstruct ice_hw *hw;\n-\tu16 grps_movd = 0;\n-\tu8 i;\n \n \thw = pi->hw;\n \n@@ -2802,7 +2801,7 @@ ice_sched_assoc_vsi_to_agg(struct ice_port_info *pi, u32 agg_id,\n */\n static void ice_sched_rm_unused_rl_prof(struct ice_port_info *pi)\n {\n-\tu8 ln;\n+\tu16 ln;\n \n \tfor (ln = 0; ln < pi->hw->num_tx_sched_layers; ln++) {\n \t\tstruct ice_aqc_rl_profile_info *rl_prof_elem;\n", "prefixes": [ "v2", "21/63" ] }{ "id": 58157, "url": "