Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58152/?format=api
{ "id": 58152, "url": "https://patches.dpdk.org/api/patches/58152/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190829023656.8220-19-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829023656.8220-19-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829023656.8220-19-qi.z.zhang@intel.com", "date": "2019-08-29T02:36:11", "name": "[v2,18/63] net/ice/base: resolve static analysis issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a625d0df76ebb813fa5ae3e35341afa09158ad3e", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190829023656.8220-19-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6158, "url": "https://patches.dpdk.org/api/series/6158/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6158", "date": "2019-08-29T02:35:54", "name": "[v2,01/63] net/ice/base: enhance NVM read", "version": 2, "mbox": "https://patches.dpdk.org/series/6158/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58152/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 07FDD1C436;\n\tThu, 29 Aug 2019 04:35:06 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 32D1C1C21E;\n\tThu, 29 Aug 2019 04:34:49 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Aug 2019 19:34:48 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga004.jf.intel.com with ESMTP; 28 Aug 2019 19:34:47 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,442,1559545200\"; d=\"scan'208\";a=\"332363591\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tstable@dpdk.org, Dan Nowlin <dan.nowlin@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Thu, 29 Aug 2019 10:36:11 +0800", "Message-Id": "<20190829023656.8220-19-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190829023656.8220-1-qi.z.zhang@intel.com>", "References": "<20190826105105.19121-1-qi.z.zhang@intel.com>\n\t<20190829023656.8220-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 18/63] net/ice/base: resolve static analysis\n\tissues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity complains first_free can be -1 resulting in a negative shift left\nwhen k equals 0; i.e. the expression 1 << (first_free - k). Fix this by\nexplicitly checking for this case.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dan Nowlin <dan.nowlin@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 29888df76..73362c909 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -4200,7 +4200,7 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)\n \t\t\t\tindex = i + 1;\n \n \t\t\t/* check for room */\n-\t\t\tif (first_free + 1 < ice_fd_pairs[index].count)\n+\t\t\tif (first_free + 1 < (s8)ice_fd_pairs[index].count)\n \t\t\t\treturn ICE_ERR_MAX_LIMIT;\n \n \t\t\t/* place in extraction sequence */\n@@ -4210,6 +4210,9 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)\n \t\t\t\tes[first_free - k].off =\n \t\t\t\t\tice_fd_pairs[index].off + (k * 2);\n \n+\t\t\t\tif (k > first_free)\n+\t\t\t\t\treturn ICE_ERR_OUT_OF_RANGE;\n+\n \t\t\t\t/* keep track of non-relevant fields */\n \t\t\t\tmask_sel |= 1 << (first_free - k);\n \t\t\t}\n", "prefixes": [ "v2", "18/63" ] }