Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58097/?format=api
{ "id": 58097, "url": "https://patches.dpdk.org/api/patches/58097/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1566938236-3521-1-git-send-email-cernay@netcope.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566938236-3521-1-git-send-email-cernay@netcope.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566938236-3521-1-git-send-email-cernay@netcope.com", "date": "2019-08-27T20:37:16", "name": "[v3] net/nfb: remove resources when port is closed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "71c38d2a9ab3119c94464d1552f7b113410fa3d3", "submitter": { "id": 1227, "url": "https://patches.dpdk.org/api/people/1227/?format=api", "name": "Rastislav Cernay", "email": "cernay@netcope.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1566938236-3521-1-git-send-email-cernay@netcope.com/mbox/", "series": [ { "id": 6142, "url": "https://patches.dpdk.org/api/series/6142/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6142", "date": "2019-08-27T20:37:16", "name": "[v3] net/nfb: remove resources when port is closed", "version": 3, "mbox": "https://patches.dpdk.org/series/6142/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58097/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BF8521C1C2;\n\tTue, 27 Aug 2019 21:40:24 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 1946B1C1BE\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 21:40:23 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id r17so50285wme.0\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 12:40:23 -0700 (PDT)", "from sw-c1.int.netcope.com ([5.180.196.50])\n\tby smtp.gmail.com with ESMTPSA id 6sm118115wmf.23.2019.08.27.12.40.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 27 Aug 2019 12:40:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RQduCbwvb7FJTtrlgAf+d9QQ+7NlZW2Q9yRhNcUI7To=;\n\tb=VNDPRIvN5yyQ3X+/HH3Y7t0RDaHAfD7FFyFlIrbwAoaLIil5icSj5aVwb0hoEGC/b3\n\tCP3VuyR9Df/ZDp7kdze/JN+Tmt3bFi0KPhnMyfiWJDAwY5A+ybA9qqgbwNEFDL1bhtNQ\n\tZThgpfyCSy12LSrS/hLoZkQYZqK1zTTPfoONUEWC8ekzm9sawi+Oo/F7MqCKgX1OMOLM\n\tcP7fYnbiun1U6cQam3TTH4xFFrU+fNZMzUjkkQCLtkcZ/5pwJKPGRUSC3GSKbPatRgYd\n\tYe3wShlcEqV0nSDAZHx9ZIgmElOesDrCjuq5m5ECGnaZyBSELv0jbuoOUv4L4Vb3R/qb\n\t7htw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RQduCbwvb7FJTtrlgAf+d9QQ+7NlZW2Q9yRhNcUI7To=;\n\tb=MJtgTazsB0uZmewPDG5ffCXmbEMArQHkEicL18r2/dII4vk2J61muNGfQzBF//6CHE\n\t7Vri5VU/gAcjontOFoCDH/aKezsH0gSnuRRxpZhO8at3dV037QckH8SZsnsirDdQdkj8\n\tSu4+X6gfH1jyv5X7pFt5Ahl+igRg//mGqn/HHa7MHKQqYQMrmLqjHpDs7t3rbB8cD0Zr\n\tzCmEkF8ED733xfPhfzIUPWKr9oTMLR7yfwICMnbTPc0OCv+ETY+B+DalPmrxswpvQRaX\n\tYQeoyIdXzjC3fJGehdTOFSFQPgJHFSeMF148TaJYIn8WwX++R+wB8FXUnAKGh1K2nLmK\n\tNW3w==", "X-Gm-Message-State": "APjAAAWVtoGwFyL1L0YZz4QH1FXb4hadNZwmkmEPOLPdflYJ7KE+5BN/\n\t84lQkQgNQ1evHV+SM2mPaVmxMk1X3Me45w==", "X-Google-Smtp-Source": "APXvYqxWu2qXVydK4Xj+wjzKqJV2hcgpdYx9bwxf0KO+j3VAQIIQypIdWABnG8er1RLYwf5uEquYeA==", "X-Received": "by 2002:a1c:c584:: with SMTP id v126mr211890wmf.27.1566934821762;\n\tTue, 27 Aug 2019 12:40:21 -0700 (PDT)", "From": "Rastislav Cernay <cernay@netcope.com>", "X-Google-Original-From": "Rastislav Cernay", "To": "dev@dpdk.org", "Cc": "Rastislav Cernay <cernay@netcope.com>", "Date": "Tue, 27 Aug 2019 22:37:16 +0200", "Message-Id": "<1566938236-3521-1-git-send-email-cernay@netcope.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1565362745-152027-1-git-send-email-cernay@netcope.com>", "References": "<1565362745-152027-1-git-send-email-cernay@netcope.com>", "Subject": "[dpdk-dev] [PATCH v3] net/nfb: remove resources when port is closed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rastislav Cernay <cernay@netcope.com>\n\nThe rte_eth_dev_close() function now handles freeing resources for\ndevices (e.g., mac_addrs). To conform with the new close() behaviour we\nare asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that\nrte_eth_dev_close() releases all device level dynamic memory.\n\nSigned-off-by: Rastislav Cernay <cernay@netcope.com>\nReviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>\nAcked-by: Jan Remes <remes@netcope.com>\n---\nv2: remove unnecessary cast\nv3: send correct patch\ndrivers/net/nfb/nfb_ethdev.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c\nindex c3119a0..f4093d4 100644\n--- a/drivers/net/nfb/nfb_ethdev.c\n+++ b/drivers/net/nfb/nfb_ethdev.c\n@@ -210,12 +210,16 @@\n static void\n nfb_eth_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *internals = dev->data->dev_private;\n \tuint16_t i;\n \tuint16_t nb_rx = dev->data->nb_rx_queues;\n \tuint16_t nb_tx = dev->data->nb_tx_queues;\n \n \tnfb_eth_dev_stop(dev);\n \n+\tnfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac);\n+\tnfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);\n+\n \tfor (i = 0; i < nb_rx; i++) {\n \t\tnfb_eth_rx_queue_release(dev->data->rx_queues[i]);\n \t\tdev->data->rx_queues[i] = NULL;\n@@ -226,6 +230,9 @@\n \t\tdev->data->tx_queues[i] = NULL;\n \t}\n \tdev->data->nb_tx_queues = 0;\n+\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n }\n \n /**\n@@ -446,6 +453,9 @@\n \t\trte_kvargs_free(kvlist);\n \t}\n \n+\t/* Let rte_eth_dev_close() release the port resources */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/*\n \t * Get number of available DMA RX and TX queues, which is maximum\n \t * number of queues that can be created and store it in private device\n@@ -520,15 +530,10 @@\n static int\n nfb_eth_dev_uninit(struct rte_eth_dev *dev)\n {\n-\tstruct rte_eth_dev_data *data = dev->data;\n-\tstruct pmd_internals *internals = (struct pmd_internals *)\n-\t\tdata->dev_private;\n-\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_pci_addr *pci_addr = &pci_dev->addr;\n \n-\tnfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac);\n-\tnfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);\n+\tnfb_eth_dev_close(dev);\n \n \tRTE_LOG(INFO, PMD, \"NFB device (\"\n \t\tPCI_PRI_FMT \") successfully uninitialized\\n\",\n", "prefixes": [ "v3" ] }