Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58055/?format=api
{ "id": 58055, "url": "https://patches.dpdk.org/api/patches/58055/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1566915962-5472-13-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566915962-5472-13-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566915962-5472-13-git-send-email-arybchenko@solarflare.com", "date": "2019-08-27T14:25:23", "name": "[12/51] net/bonding: check status of getting ethdev info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "40ea3258c2790712d6e82418bcc493657698ea36", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1566915962-5472-13-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6138, "url": "https://patches.dpdk.org/api/series/6138/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6138", "date": "2019-08-27T14:25:13", "name": "ethdev: change rte_eth_dev_info_get() return value to int", "version": 1, "mbox": "https://patches.dpdk.org/series/6138/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58055/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58055/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4A7C1C1F4;\n\tTue, 27 Aug 2019 16:27:00 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 416551C12C\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 16:26:23 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tB684BB40068; Tue, 27 Aug 2019 14:26:19 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 27 Aug 2019 07:26:16 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 27 Aug 2019 07:26:15 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx7REQCgE004167; Tue, 27 Aug 2019 15:26:15 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tE60451613D2; Tue, 27 Aug 2019 15:26:14 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Chas Williams <chas3@att.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Tue, 27 Aug 2019 15:25:23 +0100", "Message-ID": "<1566915962-5472-13-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "References": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-TM-AS-Result": "No-0.027300-4.000000-10", "X-TMASE-MatchedRID": "vAcx410tmlfDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeYd0WOKRkwsh0kx\n\tAPClfhN02tmoqiGUvaLMdHm3E7kFwCHhSBQfglfsA9lly13c/gE/zzQo1aNM72AMM0WKD4as4I/\n\ttgYen2+WPeXBZDCu6JZf1EF8dUCKB3EFLWHIZiz8pJ8SpVT9O/8WLeiJW8Z+pC4p+8w9U67Lic9\n\tPyNm/U0eLzNWBegCW2oq1o0yfqNxkLbigRnpKlKVHxEBQar9Jn5rd20XKsT4AcVOxPuHGIXX3D4\n\tuCV/vGcWUHV/z9MpMGsULy1PgqcCs0iYeix2rWUjGpz7oxjC24edB646HRbEE2FuMeNEqwq5APD\n\tq2B3cAxn2JWP8qFf9FKehBzm9vnO5B2Qzud0EsI7z/PzND407cC+ksT6a9fy", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.027300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-MDID": "1566915980-jHOoD0w-9glg", "Subject": "[dpdk-dev] [PATCH 12/51] net/bonding: check status of getting\n\tethdev info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_dev_info_get() return value was changed from void to\nint, so this patch modify rte_eth_dev_info_get() usage across\nnet/bonding according to its new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/bonding/rte_eth_bond_api.c | 10 +++++++++-\n drivers/net/bonding/rte_eth_bond_pmd.c | 36 ++++++++++++++++++++++++++++++----\n 2 files changed, 41 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex 0fc4c5e..e2e27e9 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -452,6 +452,7 @@\n \tstruct bond_dev_private *internals;\n \tstruct rte_eth_link link_props;\n \tstruct rte_eth_dev_info dev_info;\n+\tint ret;\n \n \tbonded_eth_dev = &rte_eth_devices[bonded_port_id];\n \tinternals = bonded_eth_dev->data->dev_private;\n@@ -465,7 +466,14 @@\n \t\treturn -1;\n \t}\n \n-\trte_eth_dev_info_get(slave_port_id, &dev_info);\n+\tret = rte_eth_dev_info_get(slave_port_id, &dev_info);\n+\tif (ret != 0) {\n+\t\tRTE_BOND_LOG(ERR,\n+\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n+\t\t\t__func__, slave_port_id, strerror(-ret));\n+\n+\t\treturn ret;\n+\t}\n \tif (dev_info.max_rx_pktlen < internals->max_rx_pktlen) {\n \t\tRTE_BOND_LOG(ERR, \"Slave (port %u) max_rx_pktlen too small\",\n \t\t\t slave_port_id);\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 97ab3f2..a1b5014 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -186,7 +186,15 @@\n \t\treturn -1;\n \t}\n \n-\trte_eth_dev_info_get(slave_port, &slave_info);\n+\tret = rte_eth_dev_info_get(slave_port, &slave_info);\n+\tif (ret != 0) {\n+\t\tRTE_BOND_LOG(ERR,\n+\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n+\t\t\t__func__, slave_port, strerror(-ret));\n+\n+\t\treturn ret;\n+\t}\n+\n \tif (slave_info.max_rx_queues < bond_dev->data->nb_rx_queues ||\n \t\t\tslave_info.max_tx_queues < bond_dev->data->nb_tx_queues) {\n \t\tRTE_BOND_LOG(ERR,\n@@ -204,10 +212,19 @@\n \tstruct bond_dev_private *internals = bond_dev->data->dev_private;\n \tstruct rte_eth_dev_info bond_info;\n \tuint16_t idx;\n+\tint ret;\n \n \t/* Verify if all slaves in bonding supports flow director and */\n \tif (internals->slave_count > 0) {\n-\t\trte_eth_dev_info_get(bond_dev->data->port_id, &bond_info);\n+\t\tret = rte_eth_dev_info_get(bond_dev->data->port_id, &bond_info);\n+\t\tif (ret != 0) {\n+\t\t\tRTE_BOND_LOG(ERR,\n+\t\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\t__func__, bond_dev->data->port_id,\n+\t\t\t\tstrerror(-ret));\n+\n+\t\t\treturn ret;\n+\t\t}\n \n \t\tinternals->mode4.dedicated_queues.rx_qid = bond_info.nb_rx_queues;\n \t\tinternals->mode4.dedicated_queues.tx_qid = bond_info.nb_tx_queues;\n@@ -2102,6 +2119,8 @@ struct bwg_slave {\n bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n \tstruct bond_dev_private *internals = dev->data->dev_private;\n+\tstruct bond_slave_details slave;\n+\tint ret;\n \n \tuint16_t max_nb_rx_queues = UINT16_MAX;\n \tuint16_t max_nb_tx_queues = UINT16_MAX;\n@@ -2123,8 +2142,17 @@ struct bwg_slave {\n \t\tuint16_t idx;\n \n \t\tfor (idx = 0; idx < internals->slave_count; idx++) {\n-\t\t\trte_eth_dev_info_get(internals->slaves[idx].port_id,\n-\t\t\t\t\t&slave_info);\n+\t\t\tslave = internals->slaves[idx];\n+\t\t\tret = rte_eth_dev_info_get(slave.port_id, &slave_info);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tRTE_BOND_LOG(ERR,\n+\t\t\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\t\t__func__,\n+\t\t\t\t\tslave.port_id,\n+\t\t\t\t\tstrerror(-ret));\n+\n+\t\t\t\treturn;\n+\t\t\t}\n \n \t\t\tif (slave_info.max_rx_queues < max_nb_rx_queues)\n \t\t\t\tmax_nb_rx_queues = slave_info.max_rx_queues;\n", "prefixes": [ "12/51" ] }