Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57997/?format=api
{ "id": 57997, "url": "https://patches.dpdk.org/api/patches/57997/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-2-sachin.saxena@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190827070730.11206-2-sachin.saxena@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190827070730.11206-2-sachin.saxena@nxp.com", "date": "2019-08-27T07:07:01", "name": "[v1,01/30] bus/dpaa: fix DPAA SEC blacklist case", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6e17db9742eebfab2ab8ac05214e258bd483c377", "submitter": { "id": 1054, "url": "https://patches.dpdk.org/api/people/1054/?format=api", "name": "Sachin Saxena", "email": "sachin.saxena@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-2-sachin.saxena@nxp.com/mbox/", "series": [ { "id": 6130, "url": "https://patches.dpdk.org/api/series/6130/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6130", "date": "2019-08-27T07:07:00", "name": "Enhancements and fixes in NXP dpaax drivers and fsl-mc bus", "version": 1, "mbox": "https://patches.dpdk.org/series/6130/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57997/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57997/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D311B1041;\n\tTue, 27 Aug 2019 09:09:19 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n\tby dpdk.org (Postfix) with ESMTP id 816EA1BF7C;\n\tTue, 27 Aug 2019 09:09:15 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 0C9152005BF;\n\tTue, 27 Aug 2019 09:09:15 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 91BAE2001BC;\n\tTue, 27 Aug 2019 09:09:12 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.133.63])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 7C9F1402DE;\n\tTue, 27 Aug 2019 15:09:08 +0800 (SGT)" ], "From": "Sachin Saxena <sachin.saxena@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stable@dpdk.org,\n\tHemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 27 Aug 2019 12:37:01 +0530", "Message-Id": "<20190827070730.11206-2-sachin.saxena@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "References": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v1 01/30] bus/dpaa: fix DPAA SEC blacklist case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hemant Agrawal <hemant.agrawal@nxp.com>\n\nThe black list of dpaa_sec devices fails.\nEAL: failed to parse device \"dpaa:dpaa_sec-1\"\n\nThis patch address following issues:\n- bus usages dpaa-sec while the driver usage dpaa_sec\n- bus usages numbers from 0 to MAX_SEC - while driver\nprobe usages sec number form max-fman_device +1\n\nFixes: 6e0752205bb2 (\"bus/dpaa: support device blacklisting\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nReviewed-by: Sachin Saxena <sachin.saxena@nxp.com>\n---\n doc/guides/cryptodevs/dpaa_sec.rst | 6 +++---\n drivers/bus/dpaa/dpaa_bus.c | 6 +++---\n drivers/crypto/dpaa_sec/dpaa_sec.c | 3 +--\n 3 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/dpaa_sec.rst b/doc/guides/cryptodevs/dpaa_sec.rst\nindex 0a2600634..3a3e30aaf 100644\n--- a/doc/guides/cryptodevs/dpaa_sec.rst\n+++ b/doc/guides/cryptodevs/dpaa_sec.rst\n@@ -85,11 +85,11 @@ For blacklisting a DPAA device, following commands can be used.\n \n .. code-block:: console\n \n- <dpdk app> <EAL args> -b \"dpaa_bus:dpaa-secX\" -- ...\n- e.g. \"dpaa_bus:dpaa-sec0\"\n+ <dpdk app> <EAL args> -b \"dpaa:dpaa_sec-X\" -- ...\n+ e.g. \"dpaa:dpaa_sec-1\"\n \n or to disable all 4 SEC devices\n- -b \"dpaa_sec:dpaa-sec0\" -b \"dpaa_sec:dpaa-sec1\" -b \"dpaa_sec:dpaa-sec2\" -b \"dpaa_sec:dpaa-sec3\"\n+ -b \"dpaa:dpaa_sec-1\" -b \"dpaa:dpaa_sec-2\" -b \"dpaa:dpaa_sec-3\" -b \"dpaa:dpaa_sec-4\"\n \n Limitations\n -----------\ndiff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex 07cc5c667..f7d1a5b63 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -218,7 +218,7 @@ dpaa_create_device_list(void)\n \t\t * allocated for dev->name/\n \t\t */\n \t\tmemset(dev->name, 0, RTE_ETH_NAME_MAX_LEN);\n-\t\tsprintf(dev->name, \"dpaa-sec%d\", i);\n+\t\tsprintf(dev->name, \"dpaa_sec-%d\", i+1);\n \t\tDPAA_BUS_LOG(INFO, \"%s cryptodev added\", dev->name);\n \t\tdev->device.name = dev->name;\n \t\tdev->device.devargs = dpaa_devargs_lookup(dev);\n@@ -397,7 +397,7 @@ rte_dpaa_bus_parse(const char *name, void *out_name)\n \t * without separator. Both need to be handled.\n \t * It is also possible that \"name=fm1-mac3\" is passed along.\n \t */\n-\tDPAA_BUS_DEBUG(\"Parse device name (%s)\\n\", name);\n+\tDPAA_BUS_DEBUG(\"Parse device name (%s)\", name);\n \n \t/* Check for dpaa_bus:fm1-mac3 style */\n \tdup_name = strdup(name);\n@@ -428,7 +428,7 @@ rte_dpaa_bus_parse(const char *name, void *out_name)\n \tfor (i = 0; i < RTE_LIBRTE_DPAA_MAX_CRYPTODEV; i++) {\n \t\tchar sec_name[16];\n \n-\t\tsnprintf(sec_name, 16, \"dpaa-sec%d\", i);\n+\t\tsnprintf(sec_name, 16, \"dpaa_sec-%d\", i+1);\n \t\tif (strcmp(sec_name, sep) == 0) {\n \t\t\tif (out_name)\n \t\t\t\tstrcpy(out_name, sep);\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 122c80a07..1754862be 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -2678,8 +2678,7 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,\n \n \tint retval;\n \n-\tsnprintf(cryptodev_name, sizeof(cryptodev_name), \"dpaa_sec-%d\",\n-\t\t\tdpaa_dev->id.dev_id);\n+\tsnprintf(cryptodev_name, sizeof(cryptodev_name), \"%s\", dpaa_dev->name);\n \n \tcryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, rte_socket_id());\n \tif (cryptodev == NULL)\n", "prefixes": [ "v1", "01/30" ] }