Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57752/?format=api
{ "id": 57752, "url": "https://patches.dpdk.org/api/patches/57752/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1566214919-32250-12-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566214919-32250-12-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566214919-32250-12-git-send-email-david.marchand@redhat.com", "date": "2019-08-19T11:41:59", "name": "[11/11] drivers/raw: use new logtype wrapper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a40fae88b0fd624760389c33359bcc629e5acf1", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1566214919-32250-12-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 6072, "url": "https://patches.dpdk.org/api/series/6072/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6072", "date": "2019-08-19T11:41:48", "name": "Fixing log levels for dynamically loaded drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/6072/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57752/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57752/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0475F1BEEA;\n\tMon, 19 Aug 2019 13:43:08 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 38A7B1BEC3\n\tfor <dev@dpdk.org>; Mon, 19 Aug 2019 13:43:06 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9B8FC106E96B;\n\tMon, 19 Aug 2019 11:43:05 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-32.brq.redhat.com\n\t[10.40.204.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CB53E100195F;\n\tMon, 19 Aug 2019 11:43:02 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Nipun Gupta <nipun.gupta@nxp.com>, Rosen Xu <rosen.xu@intel.com>,\n\tTianfei zhang <tianfei.zhang@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tXiaoyun Li <xiaoyun.li@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n\tShreyansh Jain <shreyansh.jain@nxp.com>,\n\tHemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Mon, 19 Aug 2019 13:41:59 +0200", "Message-Id": "<1566214919-32250-12-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "References": "<1566214919-32250-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.6.2\n\t(mx1.redhat.com [10.5.110.66]); Mon, 19 Aug 2019 11:43:05 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 11/11] drivers/raw: use new logtype wrapper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make use of the newly introduced wrapper.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 8 ++------\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 8 ++------\n drivers/raw/ifpga/ifpga_rawdev.c | 8 ++------\n drivers/raw/ioat/ioat_rawdev.c | 8 ++------\n drivers/raw/ntb/ntb.c | 8 ++------\n drivers/raw/skeleton/skeleton_rawdev.c | 8 ++------\n 6 files changed, 12 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\nindex 3f42da1..ff02855 100644\n--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n@@ -283,9 +283,5 @@ static struct rte_vdev_driver dpaa2_cmdif_drv = {\n \n RTE_PMD_REGISTER_VDEV(DPAA2_CMDIF_PMD_NAME, dpaa2_cmdif_drv);\n \n-RTE_INIT(dpaa2_cmdif_init_log)\n-{\n-\tdpaa2_cmdif_logtype = rte_log_register(\"pmd.raw.dpaa2.cmdif\");\n-\tif (dpaa2_cmdif_logtype >= 0)\n-\t\trte_log_set_level(dpaa2_cmdif_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(dpaa2_cmdif_logtype, \"pmd.raw.dpaa2.cmdif\",\n+\tRTE_LOG_INFO, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\nindex a391913..6af7c14 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n@@ -1345,9 +1345,5 @@ RTE_PMD_REGISTER_DPAA2(dpaa2_qdma, rte_dpaa2_qdma_pmd);\n RTE_PMD_REGISTER_PARAM_STRING(dpaa2_qdma,\n \t\"no_prefetch=<int> \");\n \n-RTE_INIT(dpaa2_qdma_init_log)\n-{\n-\tdpaa2_qdma_logtype = rte_log_register(\"pmd.raw.dpaa2.qdma\");\n-\tif (dpaa2_qdma_logtype >= 0)\n-\t\trte_log_set_level(dpaa2_qdma_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(dpaa2_qdma_logtype, \"pmd.raw.dpaa2.qdma\",\n+\tRTE_LOG_INFO, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex fef89e6..dc2f3c1 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -757,12 +757,8 @@ RTE_PMD_REGISTER_PCI(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, \"* igb_uio | uio_pci_generic | vfio-pci\");\n \n-RTE_INIT(ifpga_rawdev_init_log)\n-{\n-\tifpga_rawdev_logtype = rte_log_register(\"driver.raw.init\");\n-\tif (ifpga_rawdev_logtype >= 0)\n-\t\trte_log_set_level(ifpga_rawdev_logtype, RTE_LOG_NOTICE);\n-}\n+RTE_LOG_REGISTER(ifpga_rawdev_logtype, \"pmd.rawdev.ifpga.init\",\n+\tRTE_LOG_NOTICE, RTE_LOGTYPE_PMD);\n \n static const char * const valid_args[] = {\n #define IFPGA_ARG_NAME \"ifpga\"\ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex 7270ad7..023eb0e 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -347,9 +347,5 @@ RTE_PMD_REGISTER_PCI(IOAT_PMD_RAWDEV_NAME, ioat_pmd_drv);\n RTE_PMD_REGISTER_PCI_TABLE(IOAT_PMD_RAWDEV_NAME, pci_id_ioat_map);\n RTE_PMD_REGISTER_KMOD_DEP(IOAT_PMD_RAWDEV_NAME, \"* igb_uio | uio_pci_generic\");\n \n-RTE_INIT(ioat_pmd_init_log)\n-{\n-\tioat_pmd_logtype = rte_log_register(IOAT_PMD_LOG_NAME);\n-\tif (ioat_pmd_logtype >= 0)\n-\t\trte_log_set_level(ioat_pmd_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(ioat_pmd_logtype, IOAT_PMD_LOG_NAME,\n+\tRTE_LOG_INFO, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex bfecce1..e5e07a7 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -835,9 +835,5 @@ RTE_PMD_REGISTER_PCI(raw_ntb, rte_ntb_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(raw_ntb, pci_id_ntb_map);\n RTE_PMD_REGISTER_KMOD_DEP(raw_ntb, \"* igb_uio | uio_pci_generic | vfio-pci\");\n \n-RTE_INIT(ntb_init_log)\n-{\n-\tntb_logtype = rte_log_register(\"pmd.raw.ntb\");\n-\tif (ntb_logtype >= 0)\n-\t\trte_log_set_level(ntb_logtype, RTE_LOG_DEBUG);\n-}\n+RTE_LOG_REGISTER(ntb_logtype, \"pmd.raw.ntb\",\n+\tRTE_LOG_DEBUG, RTE_LOGTYPE_PMD);\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 586183a..69c2bba 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -760,9 +760,5 @@ static struct rte_vdev_driver skeleton_pmd_drv = {\n \n RTE_PMD_REGISTER_VDEV(SKELETON_PMD_RAWDEV_NAME, skeleton_pmd_drv);\n \n-RTE_INIT(skeleton_pmd_init_log)\n-{\n-\tskeleton_pmd_logtype = rte_log_register(\"rawdev.skeleton\");\n-\tif (skeleton_pmd_logtype >= 0)\n-\t\trte_log_set_level(skeleton_pmd_logtype, RTE_LOG_INFO);\n-}\n+RTE_LOG_REGISTER(skeleton_pmd_logtype, \"pmd.rawdev.skeleton\",\n+\tRTE_LOG_INFO, RTE_LOGTYPE_PMD);\n", "prefixes": [ "11/11" ] }