Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57703/?format=api
{ "id": 57703, "url": "https://patches.dpdk.org/api/patches/57703/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/156586846064.44449.9348520751731980354.stgit@jrharri1-skx/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<156586846064.44449.9348520751731980354.stgit@jrharri1-skx>", "list_archive_url": "https://inbox.dpdk.org/dev/156586846064.44449.9348520751731980354.stgit@jrharri1-skx", "date": "2019-08-15T11:27:40", "name": "[2/2] timer: don't check tsc flags in secondary processes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c0852a9801e94bc5920df1935fd6d47d0088c5a1", "submitter": { "id": 84, "url": "https://patches.dpdk.org/api/people/84/?format=api", "name": "Harris, James R", "email": "james.r.harris@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/156586846064.44449.9348520751731980354.stgit@jrharri1-skx/mbox/", "series": [ { "id": 6054, "url": "https://patches.dpdk.org/api/series/6054/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6054", "date": "2019-08-15T11:27:35", "name": "[1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs", "version": 1, "mbox": "https://patches.dpdk.org/series/6054/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57703/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C2241BEF3;\n\tThu, 15 Aug 2019 20:32:51 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 0E2471BEA8\n\tfor <dev@dpdk.org>; Thu, 15 Aug 2019 20:32:49 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Aug 2019 11:32:49 -0700", "from jrharri1-skx.ch.intel.com (HELO [127.0.1.1])\n\t([143.182.137.73])\n\tby orsmga008.jf.intel.com with ESMTP; 15 Aug 2019 11:32:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,389,1559545200\"; d=\"scan'208\";a=\"171191637\"", "From": "Jim Harris <james.r.harris@intel.com>", "To": "dev@dpdk.org, anatoly.burakov@intel.com", "Date": "Thu, 15 Aug 2019 04:27:40 -0700", "Message-ID": "<156586846064.44449.9348520751731980354.stgit@jrharri1-skx>", "In-Reply-To": "<156586845525.44449.11798632267644345382.stgit@jrharri1-skx>", "References": "<156586845525.44449.11798632267644345382.stgit@jrharri1-skx>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Subject": "[dpdk-dev] [PATCH 2/2] timer: don't check tsc flags in secondary\n\tprocesses", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "check_tsc_flags() parses /proc/cpuinfo and prints\nwarning messages if any cores don't have constant_tsc\nand nonstop_tsc. It has no functional meaning.\nThis consumes a noticeable amount of time in\nsecondary processes - on my test system, it consumes\n21ms out of the 66ms total execution time for\nrte_eal_init().\n\nSo let's just skip checking these flags in secondary\nprocesses. Since the primary process is already\nparsing the entirety of /proc/cpuinfo, the warning\nprinted in the primary process should be sufficient.\n\nSigned-off-by: Jim Harris <james.r.harris@intel.com>\n---\n lib/librte_eal/linux/eal/eal_timer.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal_timer.c b/lib/librte_eal/linux/eal/eal_timer.c\nindex 76ec17034..ce447d43b 100644\n--- a/lib/librte_eal/linux/eal/eal_timer.c\n+++ b/lib/librte_eal/linux/eal/eal_timer.c\n@@ -198,6 +198,15 @@ check_tsc_flags(void)\n \tchar line[512];\n \tFILE *stream;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\t/* This function just prints warnings if TSC is not constant\n+\t\t * and has no functional meaning. It also checks *all* cores\n+\t\t * on the system, not just the ones configured for this process.\n+\t\t * So don't bother rechecking again in secondary processes.\n+\t\t */\n+\t\treturn;\n+\t}\n+\n \tstream = fopen(\"/proc/cpuinfo\", \"r\");\n \tif (!stream) {\n \t\tRTE_LOG(WARNING, EAL, \"WARNING: Unable to open /proc/cpuinfo\\n\");\n", "prefixes": [ "2/2" ] }