Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57691/?format=api
{ "id": 57691, "url": "https://patches.dpdk.org/api/patches/57691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/aca9df2e188c0c205a241b51afa315a31247dae4.1565861014.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<aca9df2e188c0c205a241b51afa315a31247dae4.1565861014.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/aca9df2e188c0c205a241b51afa315a31247dae4.1565861014.git.dekelp@mellanox.com", "date": "2019-08-15T09:26:51", "name": "net/mlx5: fix validation of jump action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1017a33db98829c5a5d2f59fdf54774c452f448", "submitter": { "id": 1082, "url": "https://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/aca9df2e188c0c205a241b51afa315a31247dae4.1565861014.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 6051, "url": "https://patches.dpdk.org/api/series/6051/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6051", "date": "2019-08-15T09:26:51", "name": "net/mlx5: fix validation of jump action", "version": 1, "mbox": "https://patches.dpdk.org/series/6051/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57691/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E530C1BE8B;\n\tThu, 15 Aug 2019 11:27:39 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 6116B1B13C\n\tfor <dev@dpdk.org>; Thu, 15 Aug 2019 11:27:38 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 15 Aug 2019 12:27:36 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x7F9RTIq001216;\n\tThu, 15 Aug 2019 12:27:36 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "yskoh@mellanox.com, viacheslavo@mellanox.com, shahafs@mellanox.com", "Cc": "orika@mellanox.com, dev@dpdk.org, stable@dpdk.org", "Date": "Thu, 15 Aug 2019 12:26:51 +0300", "Message-Id": "<aca9df2e188c0c205a241b51afa315a31247dae4.1565861014.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix validation of jump action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch updates the validation function of jump action.\nIt adds check of conflicting fate actions in flow rule.\nIt also removes check of action->type which is not needed.\n\nFixes: 684b9a1b1f5c (\"net/mlx5: support jump action\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 21faa98..374dbae 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1951,7 +1951,9 @@ struct field_modify_info modify_tcp[] = {\n * Validate jump action.\n *\n * @param[in] action\n- * Pointer to the modify action.\n+ * Pointer to the jump action.\n+ * @param[in] action_flags\n+ * Holds the actions detected until now.\n * @param[in] group\n * The group of the current flow.\n * @param[out] error\n@@ -1962,10 +1964,17 @@ struct field_modify_info modify_tcp[] = {\n */\n static int\n flow_dv_validate_action_jump(const struct rte_flow_action *action,\n+\t\t\t uint64_t action_flags,\n \t\t\t uint32_t group,\n \t\t\t struct rte_flow_error *error)\n {\n-\tif (action->type != RTE_FLOW_ACTION_TYPE_JUMP && !action->conf)\n+\tif (action_flags & (MLX5_FLOW_FATE_ACTIONS |\n+\t\t\t MLX5_FLOW_FATE_ESWITCH_ACTIONS))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"can't have 2 fate actions in\"\n+\t\t\t\t\t \" same flow\");\n+\tif (!action->conf)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n \t\t\t\t\t NULL, \"action configuration not set\");\n@@ -3220,6 +3229,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_JUMP:\n \t\t\tret = flow_dv_validate_action_jump(actions,\n+\t\t\t\t\t\t\t action_flags,\n \t\t\t\t\t\t\t attr->group, error);\n \t\t\tif (ret)\n \t\t\t\treturn ret;\n", "prefixes": [] }