Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57681/?format=api
{ "id": 57681, "url": "https://patches.dpdk.org/api/patches/57681/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190814130953.30853-1-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190814130953.30853-1-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190814130953.30853-1-jerinj@marvell.com", "date": "2019-08-14T13:09:53", "name": "bpf: hide internal program arg type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f0d3c895e95eeb0e5a25897df4e972db60ec3936", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190814130953.30853-1-jerinj@marvell.com/mbox/", "series": [ { "id": 6045, "url": "https://patches.dpdk.org/api/series/6045/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6045", "date": "2019-08-14T13:09:53", "name": "bpf: hide internal program arg type", "version": 1, "mbox": "https://patches.dpdk.org/series/6045/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57681/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EDEE8375B;\n\tWed, 14 Aug 2019 15:10:29 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8E8BBA69\n\tfor <dev@dpdk.org>; Wed, 14 Aug 2019 15:10:28 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx7ED80xc023249; Wed, 14 Aug 2019 06:10:26 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2ubfabf452-3\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tWed, 14 Aug 2019 06:10:25 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n\t(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tWed, 14 Aug 2019 06:10:20 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Wed, 14 Aug 2019 06:10:20 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id C73C73F703F;\n\tWed, 14 Aug 2019 06:10:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : mime-version :\n\tcontent-transfer-encoding : content-type; s=pfpt0818;\n\tbh=IaCDJLIUjIM2MpwIXIUaXGkaOatiUjLSr/mFReEm1n0=; \n\tb=rgY6HZkVa1C0ZP8IvkF5BVQhlviIhRds2w9Gxm8ehrLPaJ2RXSTATREs0T9eLNVETK8B\n\t1o1tuNcU+ixJOdMbYtG/PbBWnhUpa06CI1aj/yl7EYghNxKHqLvnzrYRyvy5wddsQdSy\n\txasFJ+MdhkSZVpITVctESljCz84eFntHPcxCj5AS+C9nZKz8XPgwygASYrL5s7nMHXA0\n\tigXyIk/LNGxsut6XCg+UWCcwj5OSzeRnrqMRc57zl/5VMMysFUwjfGPCf/+ENjDmDM4m\n\t0UAKC5rT+QbOGKJ4N+PkeKzBfew9/XMwgFq/sxfZPu0z6MMH2Mh0F0RplMiB6HI4kPeU\n\tLQ== ", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Konstantin Ananyev <konstantin.ananyev@intel.com>", "CC": "<thomas@monjalon.net>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 14 Aug 2019 18:39:53 +0530", "Message-ID": "<20190814130953.30853-1-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.22.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:5.22.84,1.0.8\n\tdefinitions=2019-08-14_04:2019-08-14,2019-08-14 signatures=0", "Subject": "[dpdk-dev] [PATCH] bpf: hide internal program arg type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nRTE_BPF_ARG_PTR_STACK is used as internal program\narg type. Rename to RTE_BPF_ARG_RESERVED to\navoid exposing internal program type.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/librte_bpf/bpf_validate.c | 12 +++++++-----\n lib/librte_bpf/rte_bpf.h | 2 +-\n 2 files changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c\nindex 0cf41fa27..6bd6f78e9 100644\n--- a/lib/librte_bpf/bpf_validate.c\n+++ b/lib/librte_bpf/bpf_validate.c\n@@ -15,6 +15,8 @@\n \n #include \"bpf_impl.h\"\n \n+#define BPF_ARG_PTR_STACK RTE_BPF_ARG_RESERVED\n+\n struct bpf_reg_val {\n \tstruct rte_bpf_arg v;\n \tuint64_t mask;\n@@ -710,7 +712,7 @@ eval_ptr(struct bpf_verifier *bvf, struct bpf_reg_val *rm, uint32_t opsz,\n \tif (rm->u.max % align != 0)\n \t\treturn \"unaligned memory access\";\n \n-\tif (rm->v.type == RTE_BPF_ARG_PTR_STACK) {\n+\tif (rm->v.type == BPF_ARG_PTR_STACK) {\n \n \t\tif (rm->u.max != rm->u.min || rm->s.max != rm->s.min ||\n \t\t\t\trm->u.max != (uint64_t)rm->s.max)\n@@ -764,7 +766,7 @@ eval_load(struct bpf_verifier *bvf, const struct ebpf_insn *ins)\n \tif (err != NULL)\n \t\treturn err;\n \n-\tif (rs.v.type == RTE_BPF_ARG_PTR_STACK) {\n+\tif (rs.v.type == BPF_ARG_PTR_STACK) {\n \n \t\tsv = st->sv + rs.u.max / sizeof(uint64_t);\n \t\tif (sv->v.type == RTE_BPF_ARG_UNDEF || sv->mask < msk)\n@@ -859,7 +861,7 @@ eval_store(struct bpf_verifier *bvf, const struct ebpf_insn *ins)\n \tif (err != NULL)\n \t\treturn err;\n \n-\tif (rd.v.type == RTE_BPF_ARG_PTR_STACK) {\n+\tif (rd.v.type == BPF_ARG_PTR_STACK) {\n \n \t\tsv = st->sv + rd.u.max / sizeof(uint64_t);\n \t\tif (BPF_CLASS(ins->code) == BPF_STX &&\n@@ -908,7 +910,7 @@ eval_func_arg(struct bpf_verifier *bvf, const struct rte_bpf_arg *arg,\n \t\t * pointer to the variable on the stack is passed\n \t\t * as an argument, mark stack space it occupies as initialized.\n \t\t */\n-\t\tif (err == NULL && rv->v.type == RTE_BPF_ARG_PTR_STACK) {\n+\t\tif (err == NULL && rv->v.type == BPF_ARG_PTR_STACK) {\n \n \t\t\ti = rv->u.max / sizeof(uint64_t);\n \t\t\tn = i + arg->size / sizeof(uint64_t);\n@@ -2131,7 +2133,7 @@ evaluate(struct bpf_verifier *bvf)\n \t/* initial state of frame pointer */\n \tstatic const struct bpf_reg_val rvfp = {\n \t\t.v = {\n-\t\t\t.type = RTE_BPF_ARG_PTR_STACK,\n+\t\t\t.type = BPF_ARG_PTR_STACK,\n \t\t\t.size = MAX_BPF_STACK_SIZE,\n \t\t},\n \t\t.mask = UINT64_MAX,\ndiff --git a/lib/librte_bpf/rte_bpf.h b/lib/librte_bpf/rte_bpf.h\nindex cd4d56dea..cbf1cddac 100644\n--- a/lib/librte_bpf/rte_bpf.h\n+++ b/lib/librte_bpf/rte_bpf.h\n@@ -32,7 +32,7 @@ enum rte_bpf_arg_type {\n \tRTE_BPF_ARG_RAW, /**< scalar value */\n \tRTE_BPF_ARG_PTR = 0x10, /**< pointer to data buffer */\n \tRTE_BPF_ARG_PTR_MBUF, /**< pointer to rte_mbuf */\n-\tRTE_BPF_ARG_PTR_STACK,\n+\tRTE_BPF_ARG_RESERVED, /**< reserved for internal use */\n };\n \n /**\n", "prefixes": [] }