Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57652/?format=api
{ "id": 57652, "url": "https://patches.dpdk.org/api/patches/57652/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1565693011-33998-2-git-send-email-gavin.hu@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1565693011-33998-2-git-send-email-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1565693011-33998-2-git-send-email-gavin.hu@arm.com", "date": "2019-08-13T10:43:30", "name": "[1/2] net/i40e: desc loading is unnecessarily ordered for aarch64", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bfdac3fd17946834e9522736a199374053b98666", "submitter": { "id": 1018, "url": "https://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1565693011-33998-2-git-send-email-gavin.hu@arm.com/mbox/", "series": [ { "id": 6026, "url": "https://patches.dpdk.org/api/series/6026/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6026", "date": "2019-08-13T10:43:29", "name": "i40e neon vPMD optiomization for aarch64", "version": 1, "mbox": "https://patches.dpdk.org/series/6026/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57652/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7EACD1BE0C;\n\tTue, 13 Aug 2019 12:44:03 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id 5FD161BE0C;\n\tTue, 13 Aug 2019 12:44:01 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF6DB1570;\n\tTue, 13 Aug 2019 03:44:00 -0700 (PDT)", "from net-arm-thunderx2.test.ast.arm.com\n\t(net-arm-thunderx2.shanghai.arm.com [10.169.40.40])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t9AEF13F694; Tue, 13 Aug 2019 03:43:58 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, thomas@monjalon.net, jerinj@marvell.com,\n\tpbhagavatula@marvell.com, Honnappa.Nagarahalli@arm.com,\n\tqi.z.zhang@intel.com, bruce.richardson@intel.com, stable@dpdk.org", "Date": "Tue, 13 Aug 2019 18:43:30 +0800", "Message-Id": "<1565693011-33998-2-git-send-email-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1565693011-33998-1-git-send-email-gavin.hu@arm.com>", "References": "<1565693011-33998-1-git-send-email-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH 1/2] net/i40e: desc loading is unnecessarily\n\tordered for aarch64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For x86, the descriptors needs to be loaded in order, so in between two\ndescriptors loading, there is a compiler barrier in place.[1]\nFor aarch64, a patch [2] is in place to survive with discontinuous DD bits,\nthe barriers can be removed to take full advantage of out-of-order\nexecution.\n\n50% performance gain in the RFC2544 NDR test was measured on ThunderX2.\n12.50% performan gain in the RFC2544 NDR test was measured on Ampere\neMAG80 platform.\n\n[1] http://inbox.dpdk.org/users/039ED4275CED7440929022BC67E7061153D71548@\nSHSMSX105.ccr.corp.intel.com/\n[2] https://mails.dpdk.org/archives/stable/2017-October/003324.html\n\nFixes: ae0eb310f253 (\"net/i40e: implement vector PMD for ARM\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Steve Capper <steve.capper@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c\nindex 83572ef..5555e9b 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c\n@@ -285,7 +285,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t\t/* Read desc statuses backwards to avoid race condition */\n \t\t/* A.1 load 4 pkts desc */\n \t\tdescs[3] = vld1q_u64((uint64_t *)(rxdp + 3));\n-\t\trte_rmb();\n \n \t\t/* B.2 copy 2 mbuf point into rx_pkts */\n \t\tvst1q_u64((uint64_t *)&rx_pkts[pos], mbp1);\n", "prefixes": [ "1/2" ] }