Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57620/?format=api
{ "id": 57620, "url": "https://patches.dpdk.org/api/patches/57620/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1565608778-17185-1-git-send-email-cernay@netcope.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1565608778-17185-1-git-send-email-cernay@netcope.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1565608778-17185-1-git-send-email-cernay@netcope.com", "date": "2019-08-12T11:19:38", "name": "[v2] net/nfb: remove resources when port is closed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5b2af8cc47448db86097105511e0ff6253026774", "submitter": { "id": 1227, "url": "https://patches.dpdk.org/api/people/1227/?format=api", "name": "Rastislav Cernay", "email": "cernay@netcope.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1565608778-17185-1-git-send-email-cernay@netcope.com/mbox/", "series": [ { "id": 6015, "url": "https://patches.dpdk.org/api/series/6015/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6015", "date": "2019-08-12T11:19:38", "name": "[v2] net/nfb: remove resources when port is closed", "version": 2, "mbox": "https://patches.dpdk.org/series/6015/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57620/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57620/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 58DE149E0;\n\tMon, 12 Aug 2019 13:19:57 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id E355B378B\n\tfor <dev@dpdk.org>; Mon, 12 Aug 2019 13:19:55 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id p17so104205404wrf.11\n\tfor <dev@dpdk.org>; Mon, 12 Aug 2019 04:19:55 -0700 (PDT)", "from sw-c1.int.netcope.com ([5.180.196.50])\n\tby smtp.gmail.com with ESMTPSA id\n\tl14sm10585773wrn.42.2019.08.12.04.19.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 12 Aug 2019 04:19:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=DVZjN8aJApXOGfIqwsOIh0EAxQ1MFQJGhWs7+GBDjIs=;\n\tb=mMWjvVdD4jYysyRkdFZJdsPwXNSWn99ZK+mgUvyc1uBPwZjia6B4KGNi8f6Y+UOzrd\n\tqpCEFpbre3SmYKtCzVBlWPM9J/VQKAySeS3zwJ+0h2oihXb4FBF2mq+CCaITSjDeX+CR\n\tYtOwkWOIfuO27QR6j6jTtrB5EB9T+ulV7hBNLRsvi/eRtNk2N+bZ+pXknZhrP/i1zCJG\n\tFX5/o3uGp9zJ3k/5fmNJhbjkDXLK+M6n3ajLsjveFrOFdWX4oPOFmWbNKQ+aw+dyVF6K\n\t+S+4TKcZYuz9Yd5BceQZbMbV91+trp0zrPylppzku+yqXtwbZUs1bXDU+UqjtuG1YlRs\n\tN7xg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=DVZjN8aJApXOGfIqwsOIh0EAxQ1MFQJGhWs7+GBDjIs=;\n\tb=kJJTOHhqssRdiFsNR7DeYy5TkYhwLTHuLP6EvIkO3Dg1R+E8sjoECiJSSN+eK2tO1A\n\tNOE5H+yqFzB0ZbpKoSLmqaVnnFis9QmNUj5nGkml1w6xYRc/lDUZuNDQK4FSi4Aow6HL\n\tTZielkBnT0lc8XSxoOnHEisi/tQZPsDYlwFH+4AQH+hELUevg8ddh1gBD5vijgM4AbqT\n\ty1mYTLXX0nJl52/j8Gmg0V88NHhtoYqWVRmG4Hks8f5L5i28OXAKWa6iDDlasz/YPa0K\n\tcB7DOwbRaK/2azn4cmtSCKQSc0kccULQ0jrUr0vox6KBHTotFGaDRW8qkJ3RZLaX/0mI\n\t/Dug==", "X-Gm-Message-State": "APjAAAWnQOYkYSVr82CUhIgepeybycJgBXziEZ1efHcdSWrBTm2q3WPO\n\thYcZ2ixjeMXZsTxmdBBE20xfzms0Cwc=", "X-Google-Smtp-Source": "APXvYqyWVLjm+p/G66xQP7lCFO1ekCArhelQwe/GDFXKYSuObGBGE09s075d5rOlTJKtmKNintVs1A==", "X-Received": "by 2002:a5d:5343:: with SMTP id t3mr1236474wrv.156.1565608795468;\n\tMon, 12 Aug 2019 04:19:55 -0700 (PDT)", "From": "Rastislav Cernay <cernay@netcope.com>", "X-Google-Original-From": "Rastislav Cernay", "To": "dev@dpdk.org", "Cc": "Rastislav Cernay <cernay@netcope.com>", "Date": "Mon, 12 Aug 2019 13:19:38 +0200", "Message-Id": "<1565608778-17185-1-git-send-email-cernay@netcope.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1565362745-152027-1-git-send-email-cernay@netcope.com>", "References": "<1565362745-152027-1-git-send-email-cernay@netcope.com>", "Subject": "[dpdk-dev] [PATCH v2] net/nfb: remove resources when port is closed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rastislav Cernay <cernay@netcope.com>\n\nThe rte_eth_dev_close() function now handles freeing resources for\ndevices (e.g., mac_addrs). To conform with the new close() behaviour we\nare asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that\nrte_eth_dev_close() releases all device level dynamic memory.\n\nSigned-off-by: Rastislav Cernay <cernay@netcope.com>\nAcked-by: Jan Remes <remes@netcope.com>\nReviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\nv2: remove unnecessary cast\n drivers/net/szedata2/rte_eth_szedata2.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c\nindex d5dec1b..99d5ca5 100644\n--- a/drivers/net/szedata2/rte_eth_szedata2.c\n+++ b/drivers/net/szedata2/rte_eth_szedata2.c\n@@ -1157,12 +1157,15 @@ struct szedata2_tx_queue {\n static void\n eth_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *internals = dev->data->dev_private;\n \tuint16_t i;\n \tuint16_t nb_rx = dev->data->nb_rx_queues;\n \tuint16_t nb_tx = dev->data->nb_tx_queues;\n \n \teth_dev_stop(dev);\n \n+\tfree(internals->sze_dev_path);\n+\n \tfor (i = 0; i < nb_rx; i++) {\n \t\teth_rx_queue_release(dev->data->rx_queues[i]);\n \t\tdev->data->rx_queues[i] = NULL;\n@@ -1173,6 +1176,9 @@ struct szedata2_tx_queue {\n \t\tdev->data->tx_queues[i] = NULL;\n \t}\n \tdev->data->nb_tx_queues = 0;\n+\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n }\n \n static int\n@@ -1475,6 +1481,9 @@ struct szedata2_tx_queue {\n \tPMD_INIT_LOG(INFO, \"Initializing eth_dev %s (driver %s)\", data->name,\n \t\t\tRTE_STR(RTE_SZEDATA2_DRIVER_NAME));\n \n+\t/* Let rte_eth_dev_close() release the port resources */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* Fill internal private structure. */\n \tinternals->dev = dev;\n \t/* Get index of szedata2 device file and create path to device file */\n@@ -1537,12 +1546,9 @@ struct szedata2_tx_queue {\n static int\n rte_szedata2_eth_dev_uninit(struct rte_eth_dev *dev)\n {\n-\tstruct pmd_internals *internals = (struct pmd_internals *)\n-\t\tdev->data->dev_private;\n-\n \tPMD_INIT_FUNC_TRACE();\n \n-\tfree(internals->sze_dev_path);\n+\teth_dev_close(dev);\n \n \tPMD_DRV_LOG(INFO, \"%s device %s successfully uninitialized\",\n \t\t\tRTE_STR(RTE_SZEDATA2_DRIVER_NAME), dev->data->name);\n", "prefixes": [ "v2" ] }