Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5757,
    "url": "https://patches.dpdk.org/api/patches/5757/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1435162530-9272-1-git-send-email-danielx.t.mrzyglod@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1435162530-9272-1-git-send-email-danielx.t.mrzyglod@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1435162530-9272-1-git-send-email-danielx.t.mrzyglod@intel.com",
    "date": "2015-06-24T16:15:30",
    "name": "[dpdk-dev] cfgfile: Fix for Reading Files on nfs filesystem.",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "e18d54b645d5abf792eb96bc599883a6d6a17d0a",
    "submitter": {
        "id": 23,
        "url": "https://patches.dpdk.org/api/people/23/?format=api",
        "name": "Daniel Mrzyglod",
        "email": "danielx.t.mrzyglod@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1435162530-9272-1-git-send-email-danielx.t.mrzyglod@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/5757/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/5757/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 74186C3FE;\n\tWed, 24 Jun 2015 18:16:45 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id CCC8AC3E8\n\tfor <dev@dpdk.org>; Wed, 24 Jun 2015 18:16:43 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 24 Jun 2015 09:16:43 -0700",
            "from unknown ([10.217.248.46])\n\tby orsmga002.jf.intel.com with SMTP; 24 Jun 2015 09:16:38 -0700",
            "by  (sSMTP sendmail emulation); Wed, 24 Jun 2015 18:15:33 +0200"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,672,1427785200\"; d=\"scan'208\";a=\"752489476\"",
        "From": "Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 24 Jun 2015 18:15:30 +0200",
        "Message-Id": "<1435162530-9272-1-git-send-email-danielx.t.mrzyglod@intel.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "Subject": "[dpdk-dev] [PATCH] cfgfile: Fix for Reading Files on nfs filesystem.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The problem occure when we have config files on NFS filesystem.\nSolution with minimal change to library is to add buffer for I/O operations.\nWithout buffering there is  3-10% of faulty Reading from NFS.\n\nThe problem seems to be only NFS filesystem.\n\nSigned-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>\n---\n lib/librte_cfgfile/rte_cfgfile.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c\nindex b81c273..6105e0c 100644\n--- a/lib/librte_cfgfile/rte_cfgfile.c\n+++ b/lib/librte_cfgfile/rte_cfgfile.c\n@@ -93,10 +93,13 @@ rte_cfgfile_load(const char *filename, int flags)\n \tint curr_section = -1;\n \tint curr_entry = -1;\n \tchar buffer[256];\n+\tchar f_streambuff[BUFSIZ];\n \tint lineno = 0;\n \tstruct rte_cfgfile *cfg = NULL;\n+\tmemset(f_streambuff,'\\0',BUFSIZ);\n \n \tFILE *f = fopen(filename, \"r\");\n+\tsetbuf( f, f_streambuff);\n \tif (f == NULL)\n \t\treturn NULL;\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}