Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57532,
    "url": "https://patches.dpdk.org/api/patches/57532/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/3afc75c18d194c49bdc647eb3787f04a1c788c3e.1565188248.git.thierry.herbelot@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<3afc75c18d194c49bdc647eb3787f04a1c788c3e.1565188248.git.thierry.herbelot@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/3afc75c18d194c49bdc647eb3787f04a1c788c3e.1565188248.git.thierry.herbelot@6wind.com",
    "date": "2019-08-07T14:37:28",
    "name": "[19.11,09/12] virtio: get all pending rx packets with vectorized functions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7039b15bdb4f79bd4e6fdd6afbf9f5feac18e2d8",
    "submitter": {
        "id": 897,
        "url": "https://patches.dpdk.org/api/people/897/?format=api",
        "name": "Thierry Herbelot",
        "email": "thierry.herbelot@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/3afc75c18d194c49bdc647eb3787f04a1c788c3e.1565188248.git.thierry.herbelot@6wind.com/mbox/",
    "series": [
        {
            "id": 5973,
            "url": "https://patches.dpdk.org/api/series/5973/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5973",
            "date": "2019-08-07T14:37:19",
            "name": "Miscellaneous fixes",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/5973/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/57532/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/57532/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3615A1B970;\n\tWed,  7 Aug 2019 16:38:19 +0200 (CEST)",
            "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 138EA2C02\n\tfor <dev@dpdk.org>; Wed,  7 Aug 2019 16:38:00 +0200 (CEST)",
            "by mail-wr1-f66.google.com with SMTP id t16so1520634wra.6\n\tfor <dev@dpdk.org>; Wed, 07 Aug 2019 07:38:00 -0700 (PDT)",
            "from ascain.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t2sm133441211wrn.29.2019.08.07.07.37.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 07 Aug 2019 07:37:59 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=4AA75z0k2YLTMG07EUslwT4j6faGfzjKPl2dPIEQc+8=;\n\tb=Pa/Vux9GnMvq1KD2HnkSFGZHUFf4SSL90rNVA53DkJUHZiAb4+E1G3nvHUR4kZJ4VH\n\tMcGHxvZRtH8mIKzIHZRICx4FR8VKjuiIYCK80hNkwkCu1X/CWcmbojehaAfQIwBnZt3H\n\tlW/iXT7DB1XLFZUGD3MQv0EO1qlFEsHXT2r/C4mbnrbffXrbeKQiRrdasPUFUEQ/nbu5\n\t5IijOCQ/INzA6zD9G+pgmY1THWnyo1y7tz0Rnrfb/IjGYDFDxUaq+Jdb85j/jxh3wBzU\n\t4nMT98OuCc55S4xnoV6zW/IShr1XWgwO9szAophXc6iTNgdqh+CW7XXyeKZLMvHbUL2t\n\tagsQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=4AA75z0k2YLTMG07EUslwT4j6faGfzjKPl2dPIEQc+8=;\n\tb=nQTKoOSkpv36+JQs+ldJwkeErGVzT+DCmUuZ6qD2MPbCCDEemjdWGC+pyLOS6QUZTa\n\thVB1tSSnvDfnBp+AUec3pofWeCuJGaHKhKtHHgg9qNnJRY1waGPt81EsND7P5b5mREqU\n\tlXr6gT813CkxhfSW0O55SmqMP71O/JJyH9KN4EkTCVj35TgIVxzanO+LWcyp9HrJtXXB\n\tVUqa3NrMQtBWOoJJPPkq9RY6V7khWSC/biI2F+hCLHmNw5B25Up33oDRRf8u2YjljQM3\n\t87rkKa19cKIcOOiy4EHIDUkXe7SWb6/ay+phZRwwmhqniHamqM57bTX8xWcrafWQ0sMk\n\twNbw==",
        "X-Gm-Message-State": "APjAAAX0aAPZjBq0OwlCPRG/cmc6aD+/N2p/oKdAq2rgBJiCyTqftrHF\n\tK1jSPJtcEtwVSAUOUJ7rafsN+kNtDA==",
        "X-Google-Smtp-Source": "APXvYqwVIz0CcMepYnW86v/z/6XZIvxDJ2NWv2+h0gr42npToMrYgXYynO1cfSGOuzE5AYHQIl/mQQ==",
        "X-Received": "by 2002:a5d:4e90:: with SMTP id\n\te16mr11233670wru.339.1565188679657; \n\tWed, 07 Aug 2019 07:37:59 -0700 (PDT)",
        "From": "Thierry Herbelot <thierry.herbelot@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thibaut Collet <thibaut.collet@6wind.com>, stable@dpdk.org,\n\tThomas Monjalon <thomas@monjalon.net>",
        "Date": "Wed,  7 Aug 2019 16:37:28 +0200",
        "Message-Id": "<3afc75c18d194c49bdc647eb3787f04a1c788c3e.1565188248.git.thierry.herbelot@6wind.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": [
            "<cover.1565188248.git.thierry.herbelot@6wind.com>",
            "<cover.1565188248.git.thierry.herbelot@6wind.com>"
        ],
        "References": [
            "<cover.1565188248.git.thierry.herbelot@6wind.com>",
            "<cover.1565188248.git.thierry.herbelot@6wind.com>"
        ],
        "Subject": "[dpdk-dev] [PATCH 19.11 09/12] virtio: get all pending rx packets\n\twith vectorized functions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Thibaut Collet <thibaut.collet@6wind.com>\n\nThe loop to read packets does not take all packets as the number of\navailable packets (nb_used) is decremented in the loop.\nTake all available packets provides a performance improvement of 3%.\n\nFixes: fc3d66212fed (\"virtio: add vector Rx\")\nCc: stable at dpdk.org\n\nSigned-off-by: Thibaut Collet <thibaut.collet@6wind.com>\n---\n drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +++--\n drivers/net/virtio/virtio_rxtx_simple_sse.c  | 5 +++--\n 2 files changed, 6 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c\nindex e4b18cba0ce5..66bdaa00e01f 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple_neon.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c\n@@ -42,7 +42,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct virtnet_rx *rxvq = rx_queue;\n \tstruct virtqueue *vq = rxvq->vq;\n \tstruct virtio_hw *hw = vq->hw;\n-\tuint16_t nb_used;\n+\tuint16_t nb_used, nb_total;\n \tuint16_t desc_idx;\n \tstruct vring_used_elem *rused;\n \tstruct rte_mbuf **sw_ring;\n@@ -106,9 +106,10 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tvirtqueue_notify(vq);\n \t}\n \n+\tnb_total = nb_used;\n \tref_rx_pkts = rx_pkts;\n \tfor (nb_pkts_received = 0;\n-\t\tnb_pkts_received < nb_used;) {\n+\t\tnb_pkts_received < nb_total;) {\n \t\tuint64x2_t desc[RTE_VIRTIO_DESC_PER_LOOP / 2];\n \t\tuint64x2_t mbp[RTE_VIRTIO_DESC_PER_LOOP / 2];\n \t\tuint64x2_t pkt_mb[RTE_VIRTIO_DESC_PER_LOOP];\ndiff --git a/drivers/net/virtio/virtio_rxtx_simple_sse.c b/drivers/net/virtio/virtio_rxtx_simple_sse.c\nindex c757e8c9d601..811b416755e7 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple_sse.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple_sse.c\n@@ -43,7 +43,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct virtnet_rx *rxvq = rx_queue;\n \tstruct virtqueue *vq = rxvq->vq;\n \tstruct virtio_hw *hw = vq->hw;\n-\tuint16_t nb_used;\n+\tuint16_t nb_used, nb_total;\n \tuint16_t desc_idx;\n \tstruct vring_used_elem *rused;\n \tstruct rte_mbuf **sw_ring;\n@@ -108,9 +108,10 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tvirtqueue_notify(vq);\n \t}\n \n+\tnb_total = nb_used;\n \tref_rx_pkts = rx_pkts;\n \tfor (nb_pkts_received = 0;\n-\t\tnb_pkts_received < nb_used;) {\n+\t\tnb_pkts_received < nb_total;) {\n \t\t__m128i desc[RTE_VIRTIO_DESC_PER_LOOP / 2];\n \t\t__m128i mbp[RTE_VIRTIO_DESC_PER_LOOP / 2];\n \t\t__m128i pkt_mb[RTE_VIRTIO_DESC_PER_LOOP];\n",
    "prefixes": [
        "19.11",
        "09/12"
    ]
}