Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57518/?format=api
{ "id": 57518, "url": "https://patches.dpdk.org/api/patches/57518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1565182667-10633-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1565182667-10633-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1565182667-10633-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-08-07T12:57:47", "name": "doc: update inline settings in mlx5 guide", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3c9f164c8ea0d4dca39446d5851b8e4fd7df1c43", "submitter": { "id": 1102, "url": "https://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1565182667-10633-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 5968, "url": "https://patches.dpdk.org/api/series/5968/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5968", "date": "2019-08-07T12:57:47", "name": "doc: update inline settings in mlx5 guide", "version": 1, "mbox": "https://patches.dpdk.org/series/5968/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57518/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 62E6F2BF1;\n\tWed, 7 Aug 2019 14:57:52 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id D46022BD3\n\tfor <dev@dpdk.org>; Wed, 7 Aug 2019 14:57:49 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 7 Aug 2019 15:57:49 +0300", "from pegasus12.mtr.labs.mlnx (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x77CvnXX009404;\n\tWed, 7 Aug 2019 15:57:49 +0300", "from pegasus12.mtr.labs.mlnx (localhost [127.0.0.1])\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id\n\tx77CvmUW010674; Wed, 7 Aug 2019 12:57:48 GMT", "(from viacheslavo@localhost)\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id x77CvmcA010673; \n\tWed, 7 Aug 2019 12:57:48 GMT" ], "X-Authentication-Warning": "pegasus12.mtr.labs.mlnx: viacheslavo set sender to\n\tviacheslavo@mellanox.com using -f", "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "yskoh@mellanox.com, shahafs@mellanox.com", "Date": "Wed, 7 Aug 2019 12:57:47 +0000", "Message-Id": "<1565182667-10633-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] doc: update inline settings in mlx5 guide", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch updates mlx5 documentation in parts:\n\n - txq_inline_min parameter is described in more details,\n values are fixed\n\n - maximal amount of segments in multi-segment packets.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n doc/guides/nics/mlx5.rst | 31 +++++++++++++++++++------------\n 1 file changed, 19 insertions(+), 12 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex f7a076f..d6082ac 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -124,9 +124,10 @@ Limitations\n \n Will match any ipv4 packet (VLAN included).\n \n-- A multi segment packet must have less than 6 segments in case the Tx burst function\n- is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have\n- less than 50 segments.\n+- A multi segment packet must have not more segments than reported by dev_infos_get()\n+ in tx_desc_lim.nb_seg_max field. This value depends on maximal supported Tx descriptor\n+ size and ``txq_inline_min`` settings and may be from 2 (worst case forced by maximal\n+ inline settings) to 58.\n \n - Flows with a VXLAN Network Identifier equal (or ends to be equal)\n to 0 are not supported.\n@@ -403,25 +404,31 @@ Run-time configuration\n \n Minimal amount of data to be inlined into WQE during Tx operations. NICs\n may require this minimal data amount to operate correctly. The exact value\n- may depend on NIC operation mode, requested offloads, etc.\n+ may depend on NIC operation mode, requested offloads, etc. It is strongly\n+ recommended to omit this parameter and use the default values. Anyway,\n+ applications using this parameter should take into consideration that\n+ specifying an inconsistent value may prevent the NIC from sending packets.\n \n If ``txq_inline_min`` key is present the specified value (may be aligned\n by the driver in order not to exceed the limits and provide better descriptor\n- space utilization) will be used by the driver and it is guaranteed the\n- requested data bytes are inlined into the WQE beside other inline settings.\n- This keys also may update ``txq_inline_max`` value (default of specified\n- explicitly in devargs) to reserve the space for inline data.\n+ space utilization) will be used by the driver and it is guaranteed that\n+ requested amount of data bytes are inlined into the WQE beside other inline\n+ settings. This key also may update ``txq_inline_max`` value (default\n+ or specified explicitly in devargs) to reserve the space for inline data.\n \n If ``txq_inline_min`` key is not present, the value may be queried by the\n driver from the NIC via DevX if this feature is available. If there is no DevX\n enabled/supported the value 18 (supposing L2 header including VLAN) is set\n- for ConnectX-4, value 58 (supposing L2-L4 headers, required by configurations\n- over E-Switch) is set for ConnectX-4 Lx, and 0 is set by default for ConnectX-5\n+ for ConnectX-4 and ConnectX-4LX, and 0 is set by default for ConnectX-5\n and newer NICs. If packet is shorter the ``txq_inline_min`` value, the entire\n packet is inlined.\n \n- For the ConnectX-4 and ConnectX-4 Lx NICs driver does not allow to set\n- this value below 18 (minimal L2 header, including VLAN).\n+ For ConnectX-4 NIC, driver does not allow specifying value below 18\n+ (minimal L2 header, including VLAN), error will be raised.\n+\n+ For ConnectX-4LX NIC, it is allowed to specify values below 18, but\n+ it is not recommended and may prevent NIC from sending packets over\n+ some configurations.\n \n Please, note, this minimal data inlining disengages eMPW feature (Enhanced\n Multi-Packet Write), because last one does not support partial packet inlining.\n", "prefixes": [] }