Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57412/?format=api
{ "id": 57412, "url": "https://patches.dpdk.org/api/patches/57412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1564926975-31571-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1564926975-31571-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1564926975-31571-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-08-04T13:56:15", "name": "net/mlx5: fix completion request for inline packets", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "bec9fa89383ec8979fee9aa8f9cc3f2bffd9997f", "submitter": { "id": 1102, "url": "https://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1564926975-31571-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 5903, "url": "https://patches.dpdk.org/api/series/5903/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5903", "date": "2019-08-04T13:56:15", "name": "net/mlx5: fix completion request for inline packets", "version": 1, "mbox": "https://patches.dpdk.org/series/5903/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57412/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DEBCD1BEB1;\n\tSun, 4 Aug 2019 15:56:23 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 426731BE73\n\tfor <dev@dpdk.org>; Sun, 4 Aug 2019 15:56:22 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 4 Aug 2019 16:56:16 +0300", "from pegasus12.mtr.labs.mlnx (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x74DuGsl003808;\n\tSun, 4 Aug 2019 16:56:16 +0300", "from pegasus12.mtr.labs.mlnx (localhost [127.0.0.1])\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id\n\tx74DuG0O031610; Sun, 4 Aug 2019 13:56:16 GMT", "(from viacheslavo@localhost)\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id x74DuGqp031609; \n\tSun, 4 Aug 2019 13:56:16 GMT" ], "X-Authentication-Warning": "pegasus12.mtr.labs.mlnx: viacheslavo set sender to\n\tviacheslavo@mellanox.com using -f", "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "yskoh@mellanox.com, shahafs@mellanox.com", "Date": "Sun, 4 Aug 2019 13:56:15 +0000", "Message-Id": "<1564926975-31571-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix completion request for inline\n\tpackets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If packets are completely inline the mbuf is freed immediately\nafter data copying and no pointer is stored into elts array\nto be free on completion. This leads the elts_head is not\nupdated and completion request buffer counter works incorrect.\nThis patch decrements the base value elts_comp used to calculate\ncounter threshold and completion requests flags are set more\ncorrectly on the base of MLX5_TX_COMP_THRESH value.\n\nFixes: 18a1c20044c0 (\"net/mlx5: implement Tx burst template\")\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex a890f41..308133b 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -4097,6 +4097,7 @@ enum mlx5_txcmp_code {\n \t\t\t * Packet data are completely inlined,\n \t\t\t * free the packet immediately.\n \t\t\t */\n+\t\t\ttxq->elts_comp--;\n \t\t\trte_pktmbuf_free_seg(loc->mbuf);\n \t\t\tgoto next_mbuf;\n pointer_empw:\n@@ -4283,6 +4284,7 @@ enum mlx5_txcmp_code {\n \t\t\t\t * Packet data are completely inlined,\n \t\t\t\t * free the packet immediately.\n \t\t\t\t */\n+\t\t\t\ttxq->elts_comp--;\n \t\t\t\trte_pktmbuf_free_seg(loc->mbuf);\n \t\t\t} else if (!MLX5_TXOFF_CONFIG(EMPW) &&\n \t\t\t\t txq->inlen_mode) {\n", "prefixes": [] }