Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57403/?format=api
{ "id": 57403, "url": "https://patches.dpdk.org/api/patches/57403/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1564903224-16945-1-git-send-email-hkalra@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1564903224-16945-1-git-send-email-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1564903224-16945-1-git-send-email-hkalra@marvell.com", "date": "2019-08-04T07:20:52", "name": "drivers/octeontx2: fix coverity issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c3529855c5b95cfe437c814380035e1c8fab836c", "submitter": { "id": 1182, "url": "https://patches.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1564903224-16945-1-git-send-email-hkalra@marvell.com/mbox/", "series": [ { "id": 5898, "url": "https://patches.dpdk.org/api/series/5898/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5898", "date": "2019-08-04T07:20:52", "name": "drivers/octeontx2: fix coverity issues", "version": 1, "mbox": "https://patches.dpdk.org/series/5898/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57403/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57403/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 950A51BEE1;\n\tSun, 4 Aug 2019 09:20:57 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 68AC01BEBA\n\tfor <dev@dpdk.org>; Sun, 4 Aug 2019 09:20:56 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx747KtJb026281 for <dev@dpdk.org>; Sun, 4 Aug 2019 00:20:55 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2u57mqtp5h-2\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Sun, 04 Aug 2019 00:20:55 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSun, 4 Aug 2019 00:20:54 -0700", "from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52)\n\tby SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1367.3 via Frontend Transport; Sun, 4 Aug 2019 00:20:54 -0700", "from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by\n\tMN2PR18MB3023.namprd18.prod.outlook.com (20.179.84.145) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.2136.13; Sun, 4 Aug 2019 07:20:52 +0000", "from MN2PR18MB2848.namprd18.prod.outlook.com\n\t([fe80::4447:9459:5386:2e18]) by\n\tMN2PR18MB2848.namprd18.prod.outlook.com\n\t([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2136.010;\n\tSun, 4 Aug 2019 07:20:52 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : content-type :\n\tcontent-transfer-encoding : mime-version; s=pfpt0818;\n\tbh=LPSDN0aN0a4nAQjHlTyBAkYOMHY2L2XEWghcndUEMts=; \n\tb=DIg5qv67qo1kEkBjRdLTbzVBvG+7XKZIUJAlZtcxmCf+AQSjTby3LXBLDx860Ri5ZrE4\n\tn34RCS3TPrlbNGAms9Yu1Rp77yD/NSSb/32WTxSfgAPENkOxcc54OYa8/6wSzKd6incZ\n\tM92avvuY8lJ6PrjDFXYlbpJzvKYR6IN/pTF8nV5knsvRmnPstEvaBwwFKhktTR8gPZXf\n\t5tiQ1nTbxkz7doBVTSeq5NO8RzKjcBUoM00vFEdkcPC0/nZBQl3TfEdRWwcOWZzxoWGd\n\tZVcopJqB9HAkd18pEa/YTO2kRNiFStx6HcXol1cewiEEPHpokRIsGfgZtHjd+kK4ewfo\n\tSg== ", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=LPSDN0aN0a4nAQjHlTyBAkYOMHY2L2XEWghcndUEMts=;\n\tb=krbJlBALphB2WlyczuIQb2Un03nnUj7yIZOLjl3DAOfLc5JyZqy014CTbZJW/enXt0TkwLr2UtwB1E/Z66pqOxG4PEY8dbjNObJWkPsMQ0FWXmmDUCKT72SG+IscQlcwUWnVAxfKZ8w7/e+hOrT68ORr+ZQ4PQbmAmgMn89DVfM=" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=cgusb9gt59lLb5OqNl6M10InZWCQE7wbA6xLtW6WYPPw/fkdWIs28HXscBfxEpxiwF46RM3iMrgJlrZ/6rgyCwYvxp7qj3ZAopGcJdXVtFgfDCF6Zv6Qobb8dJtCB3wEup9LVdD/NH+k4ZFnHQXjr5TISnfc0Wyy6Uai92JUAD7uuF6uCmPCeffPDBUYGLzQ8L7Cl68+7SuQ7h24VTRFej0hy6QuK+PbFerp9gRXiSscr8tzQVEXUnt7bX2Gqoa4RXU9u7fVHdxymk0Vnon/HUOmZAzPszlKFeaJe0KpJFrITqmd+aJgPrRl1zelys8NFQt8UxqgdJxyqtMdUa9AYg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=LPSDN0aN0a4nAQjHlTyBAkYOMHY2L2XEWghcndUEMts=;\n\tb=GlrT0VvP26KadVpZK+7hIz1gYZ/glismWjFCHCySipM2Fz5pj8A7TtLmYFS+UMk31t5oQSYeW1Z/rLbJSouGYkwfqWHXGb/5Fo4C+h9lNVTTrdc2h9Cv24xIftZ5Enuf2SPY2zQAZHdSEBSSobrTSGxegozrf7ap8zs/mRXpbZDBk68HjylCQT9MOh5RJ8HToFsUSA+gwAOtJr+vQX0KEMl5cGPMGcN9kID7YlOmwJGRuZvjFVZe2PGPXTn462clp3Wd37WooftK5OCsqMMoSUD81P8UnRplsEvctI7kZ597lizRlGu3uYjzGNhhCQHUKtGRKrvDrzF5zYYAlRmJFQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1;spf=pass\n\tsmtp.mailfrom=marvell.com;dmarc=pass action=none\n\theader.from=marvell.com;dkim=pass header.d=marvell.com;arc=none", "From": "Harman Kalra <hkalra@marvell.com>", "To": "Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Nithin Kumar Dabilpuram\n\t<ndabilpuram@marvell.com>, Vamsi Krishna Attunuru <vattunuru@marvell.com>,\n\tKiran Kumar Kokkilagadda <kirankumark@marvell.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "Thread-Topic": "[PATCH] drivers/octeontx2: fix coverity issues", "Thread-Index": "AQHVSpUlhGe/9LHxDk616iQ+gX/YCQ==", "Date": "Sun, 4 Aug 2019 07:20:52 +0000", "Message-ID": "<1564903224-16945-1-git-send-email-hkalra@marvell.com>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BMXPR01CA0073.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:54::13) To MN2PR18MB2848.namprd18.prod.outlook.com\n\t(2603:10b6:208:3e::21)", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.7.4", "x-originating-ip": "[115.113.156.2]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "848f6700-8e3f-4984-6e45-08d718ac4832", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);\n\tSRVR:MN2PR18MB3023; ", "x-ms-traffictypediagnostic": "MN2PR18MB3023:", "x-microsoft-antispam-prvs": "<MN2PR18MB3023028B1236EBDCBD89E854C5DB0@MN2PR18MB3023.namprd18.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:262;", "x-forefront-prvs": "0119DC3B5E", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(4636009)(136003)(396003)(366004)(376002)(39850400004)(346002)(189003)(199004)(4326008)(26005)(6512007)(6636002)(186003)(99286004)(478600001)(6486002)(50226002)(5660300002)(6436002)(14444005)(256004)(102836004)(86362001)(71200400001)(71190400001)(3846002)(6116002)(486006)(476003)(14454004)(107886003)(110136005)(66446008)(64756008)(6506007)(386003)(68736007)(8676002)(66476007)(66556008)(66946007)(2616005)(52116002)(53936002)(305945005)(2906002)(55236004)(7736002)(54906003)(81156014)(81166006)(8936002)(25786009)(316002)(66066001)(36756003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3023;\n\tH:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: marvell.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "z1t1vckE8ZNuXNdAPTYXgq0GIpphR7IdmP/3Z0cKoX+n0OeJWzjIUeoOKsh3YQwB6NYMmbvgNTzyJo2LXMf6LdBeuBEyjsWHV7Jd4pUsDi1rp8/JVpOeAP18ffopEJeCbBlEvgATg/5Xu9Igeoc5sAhUua/zDaayEPJ72Wy79mIMxxjTx8wtt29UTr6lGnbcGdIAf86CQbkE4Y4z9xCoXDr9ByeHGcoHNmwyrKf1Wg0Y1D5GVe94pMVdXhjf7nCnNFUykno3fPcqNEibxB/EVpmSaaruOX1NHpVlmst0osmeHtjh8rkwh2+k08uIqMzCBUPCqjqUwtJ1YLu+pfzI+sap8q0Bpf1Wb8SOPTH6KeZnooQq9khY9WG1+Po4pgf0CjbA+L44e6Ahz3qqrlnPTR00tgyn90EFuP/+SN0xVgs=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-Network-Message-Id": "848f6700-8e3f-4984-6e45-08d718ac4832", "X-MS-Exchange-CrossTenant-originalarrivaltime": "04 Aug 2019 07:20:52.5028\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "70e1fb47-1155-421d-87fc-2e58f638b6e0", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "hkalra@marvell.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR18MB3023", "X-OriginatorOrg": "marvell.com", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:5.22.84,1.0.8\n\tdefinitions=2019-08-04_04:2019-07-31,2019-08-04 signatures=0", "Subject": "[dpdk-dev] [PATCH] drivers/octeontx2: fix coverity issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Addresed issues reported by coverity: NULL pointer dereferencing\nissues, unchecked return value, uinitialized scalar value,\nprobable deadcode cases, unintended sign extension, bad bit\nshift operation, Wrong sizeof argument (SIZEOF_MISMATCH)\n\nCoverity issue: 343396, 345028, 344977, 345015, 345025, 344969,\nCoverity issue: 345014, 344966, 343437, 344993, 345007, 344988,\nCoverity issue: 343405, 344999, 345003\n\nFixes: 58f6f93c34c1 (\"net/octeontx2: add module EEPROM dump\")\nFixes: 38f566280abb (\"net/octeontx2: add link stats operations\")\nFixes: b5dc3140448e (\"net/octeontx2: support base PTP\")\nFixes: ba1b3b081edf (\"net/octeontx2: support VLAN offloads\")\nFixes: 092b38341859 (\"net/octeontx2: add flow init and fini\")\nFixes: 3da1b85b6d06 (\"common/octeontx2: add FLR IRQ handler\")\nFixes: 2548ab774f92 (\"mempool/octeontx2: add context dump support\")\nFixes: 2b71657c8660 (\"common/octeontx2: add mbox request and response definition\")\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/common/octeontx2/otx2_dev.c | 3 +--\n drivers/common/octeontx2/otx2_mbox.h | 4 ++--\n drivers/mempool/octeontx2/otx2_mempool_debug.c | 2 +-\n drivers/net/octeontx2/otx2_ethdev.c | 3 ++-\n drivers/net/octeontx2/otx2_ethdev_ops.c | 7 ++++++-\n drivers/net/octeontx2/otx2_flow.c | 10 ++++------\n drivers/net/octeontx2/otx2_link.c | 8 ++++++--\n drivers/net/octeontx2/otx2_ptp.c | 15 ++++++++++++---\n drivers/net/octeontx2/otx2_tm.h | 2 +-\n drivers/net/octeontx2/otx2_vlan.c | 12 +++++++-----\n 10 files changed, 42 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2/otx2_dev.c\nindex f58a6e725..910270975 100644\n--- a/drivers/common/octeontx2/otx2_dev.c\n+++ b/drivers/common/octeontx2/otx2_dev.c\n@@ -791,9 +791,8 @@ otx2_pf_vf_flr_irq(void *param)\n \t\t\tif (!(intr & (1ULL << vf)))\n \t\t\t\tcontinue;\n \n-\t\t\tvf = 64 * i + vf;\n \t\t\totx2_base_dbg(\"FLR: i :%d intr: 0x%\" PRIx64 \", vf-%d\",\n-\t\t\t\t i, intr, vf);\n+\t\t\t\t i, intr, (64 * i + vf));\n \t\t\t/* Clear interrupt */\n \t\t\totx2_write64(BIT_ULL(vf), bar2 + RVU_PF_VFFLR_INTX(i));\n \t\t\t/* Disable the interrupt */\ndiff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h\nindex b2c59c86e..009015fa5 100644\n--- a/drivers/common/octeontx2/otx2_mbox.h\n+++ b/drivers/common/octeontx2/otx2_mbox.h\n@@ -13,8 +13,8 @@\n \n #include <otx2_common.h>\n \n-#define SZ_64K\t\t\t(64 * 1024)\n-#define SZ_1K\t\t\t(1 * 1024)\n+#define SZ_64K\t\t\t(64ULL * 1024ULL)\n+#define SZ_1K\t\t\t(1ULL * 1024ULL)\n #define MBOX_SIZE\t\tSZ_64K\n \n /* AF/PF: PF initiated, PF/VF VF initiated */\ndiff --git a/drivers/mempool/octeontx2/otx2_mempool_debug.c b/drivers/mempool/octeontx2/otx2_mempool_debug.c\nindex eef61ef07..8bd395389 100644\n--- a/drivers/mempool/octeontx2/otx2_mempool_debug.c\n+++ b/drivers/mempool/octeontx2/otx2_mempool_debug.c\n@@ -91,7 +91,7 @@ otx2_mempool_ctx_dump(struct otx2_npa_lf *lf)\n \tstruct npa_aq_enq_req *aq;\n \tstruct npa_aq_enq_rsp *rsp;\n \tuint32_t q;\n-\tint rc;\n+\tint rc = 0;\n \n \tfor (q = 0; q < lf->nr_pools; q++) {\n \t\t/* Skip disabled POOL */\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex 3fb7bd93f..99fcb36c3 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -749,7 +749,8 @@ nix_sq_uninit(struct otx2_eth_txq *txq)\n \twhile (count) {\n \t\tvoid *next_sqb;\n \n-\t\tnext_sqb = *(void **)((uintptr_t)sqb_buf + ((sqes_per_sqb - 1) *\n+\t\tnext_sqb = *(void **)((uintptr_t)sqb_buf + (uint32_t)\n+\t\t\t\t ((sqes_per_sqb - 1) *\n \t\t\t\t nix_sq_max_sqe_sz(txq)));\n \t\tnpa_lf_aura_op_free(txq->sqb_pool->pool_id, 1,\n \t\t\t\t (uint64_t)sqb_buf);\ndiff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c b/drivers/net/octeontx2/otx2_ethdev_ops.c\nindex 5a16a3c04..2a79e20bb 100644\n--- a/drivers/net/octeontx2/otx2_ethdev_ops.c\n+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c\n@@ -352,10 +352,15 @@ nix_get_fwdata(struct otx2_eth_dev *dev)\n {\n \tstruct otx2_mbox *mbox = dev->mbox;\n \tstruct cgx_fw_data *rsp = NULL;\n+\tint rc;\n \n \totx2_mbox_alloc_msg_cgx_get_aux_link_info(mbox);\n \n-\totx2_mbox_process_msg(mbox, (void *)&rsp);\n+\trc = otx2_mbox_process_msg(mbox, (void *)&rsp);\n+\tif (rc) {\n+\t\totx2_err(\"Failed to get fw data: %d\", rc);\n+\t\treturn NULL;\n+\t}\n \n \treturn rsp;\n }\ndiff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c\nindex c463075cb..bdbf123a9 100644\n--- a/drivers/net/octeontx2/otx2_flow.c\n+++ b/drivers/net/octeontx2/otx2_flow.c\n@@ -844,7 +844,7 @@ otx2_flow_init(struct otx2_eth_dev *hw)\n \t}\n \n \tnpc->free_entries = rte_zmalloc(NULL, npc->flow_max_priority\n-\t\t\t\t\t* sizeof(struct rte_bitmap),\n+\t\t\t\t\t* sizeof(struct rte_bitmap *),\n \t\t\t\t\t0);\n \tif (npc->free_entries == NULL) {\n \t\totx2_err(\"free_entries alloc failed\");\n@@ -853,7 +853,7 @@ otx2_flow_init(struct otx2_eth_dev *hw)\n \t}\n \n \tnpc->free_entries_rev = rte_zmalloc(NULL, npc->flow_max_priority\n-\t\t\t\t\t* sizeof(struct rte_bitmap),\n+\t\t\t\t\t* sizeof(struct rte_bitmap *),\n \t\t\t\t\t0);\n \tif (npc->free_entries_rev == NULL) {\n \t\totx2_err(\"free_entries_rev alloc failed\");\n@@ -862,7 +862,7 @@ otx2_flow_init(struct otx2_eth_dev *hw)\n \t}\n \n \tnpc->live_entries = rte_zmalloc(NULL, npc->flow_max_priority\n-\t\t\t\t\t* sizeof(struct rte_bitmap),\n+\t\t\t\t\t* sizeof(struct rte_bitmap *),\n \t\t\t\t\t0);\n \tif (npc->live_entries == NULL) {\n \t\totx2_err(\"live_entries alloc failed\");\n@@ -871,7 +871,7 @@ otx2_flow_init(struct otx2_eth_dev *hw)\n \t}\n \n \tnpc->live_entries_rev = rte_zmalloc(NULL, npc->flow_max_priority\n-\t\t\t\t\t* sizeof(struct rte_bitmap),\n+\t\t\t\t\t* sizeof(struct rte_bitmap *),\n \t\t\t\t\t0);\n \tif (npc->live_entries_rev == NULL) {\n \t\totx2_err(\"live_entries_rev alloc failed\");\n@@ -948,8 +948,6 @@ otx2_flow_init(struct otx2_eth_dev *hw)\n \t\trte_free(npc->flow_entry_info);\n \tif (npc_mem)\n \t\trte_free(npc_mem);\n-\tif (nix_mem)\n-\t\trte_free(nix_mem);\n \treturn rc;\n }\n \ndiff --git a/drivers/net/octeontx2/otx2_link.c b/drivers/net/octeontx2/otx2_link.c\nindex 8fcbdc9b7..725b793d4 100644\n--- a/drivers/net/octeontx2/otx2_link.c\n+++ b/drivers/net/octeontx2/otx2_link.c\n@@ -52,10 +52,14 @@ otx2_eth_dev_link_status_update(struct otx2_dev *dev,\n \t\t\t\tstruct cgx_link_user_info *link)\n {\n \tstruct otx2_eth_dev *otx2_dev = (struct otx2_eth_dev *)dev;\n-\tstruct rte_eth_dev *eth_dev = otx2_dev->eth_dev;\n \tstruct rte_eth_link eth_link;\n+\tstruct rte_eth_dev *eth_dev;\n \n-\tif (!link || !dev || !eth_dev->data->dev_conf.intr_conf.lsc)\n+\tif (!link || !dev)\n+\t\treturn;\n+\n+\teth_dev = otx2_dev->eth_dev;\n+\tif (!eth_dev || !eth_dev->data->dev_conf.intr_conf.lsc)\n \t\treturn;\n \n \tif (nix_wait_for_link_cfg(otx2_dev)) {\ndiff --git a/drivers/net/octeontx2/otx2_ptp.c b/drivers/net/octeontx2/otx2_ptp.c\nindex 52e5456b5..fd13c2678 100644\n--- a/drivers/net/octeontx2/otx2_ptp.c\n+++ b/drivers/net/octeontx2/otx2_ptp.c\n@@ -102,7 +102,7 @@ nix_ptp_config(struct rte_eth_dev *eth_dev, int en)\n {\n \tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n \tstruct otx2_mbox *mbox = dev->mbox;\n-\tuint8_t rc = 0;\n+\tuint8_t rc = -EINVAL;\n \n \tif (otx2_dev_is_vf(dev))\n \t\treturn rc;\n@@ -136,9 +136,16 @@ int\n otx2_eth_dev_ptp_info_update(struct otx2_dev *dev, bool ptp_en)\n {\n \tstruct otx2_eth_dev *otx2_dev = (struct otx2_eth_dev *)dev;\n-\tstruct rte_eth_dev *eth_dev = otx2_dev->eth_dev;\n+\tstruct rte_eth_dev *eth_dev;\n \tint i;\n \n+\tif (!dev)\n+\t\treturn -EINVAL;\n+\n+\teth_dev = otx2_dev->eth_dev;\n+\tif (!eth_dev)\n+\t\treturn -EINVAL;\n+\n \totx2_dev->ptp_en = ptp_en;\n \tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++) {\n \t\tstruct otx2_eth_rxq *rxq = eth_dev->data->rx_queues[i];\n@@ -174,8 +181,10 @@ otx2_nix_timesync_enable(struct rte_eth_dev *eth_dev)\n \tts = rte_eth_dma_zone_reserve(eth_dev, \"otx2_ts\",\n \t\t\t\t 0, OTX2_ALIGN, OTX2_ALIGN,\n \t\t\t\t dev->node);\n-\tif (ts == NULL)\n+\tif (ts == NULL) {\n \t\totx2_err(\"Failed to allocate mem for tx tstamp addr\");\n+\t\treturn -ENOMEM;\n+\t}\n \n \tdev->tstamp.tx_tstamp_iova = ts->iova;\n \tdev->tstamp.tx_tstamp = ts->addr;\ndiff --git a/drivers/net/octeontx2/otx2_tm.h b/drivers/net/octeontx2/otx2_tm.h\nindex 2a009eece..4712b0935 100644\n--- a/drivers/net/octeontx2/otx2_tm.h\n+++ b/drivers/net/octeontx2/otx2_tm.h\n@@ -62,7 +62,7 @@ TAILQ_HEAD(otx2_nix_tm_node_list, otx2_nix_tm_node);\n TAILQ_HEAD(otx2_nix_tm_shaper_profile_list, otx2_nix_tm_shaper_profile);\n \n #define MAX_SCHED_WEIGHT ((uint8_t)~0)\n-#define NIX_TM_RR_QUANTUM_MAX ((1 << 24) - 1)\n+#define NIX_TM_RR_QUANTUM_MAX (BIT_ULL(24) - 1)\n \n /* DEFAULT_RR_WEIGHT * NIX_TM_RR_QUANTUM_MAX / MAX_SCHED_WEIGHT */\n /* = NIX_MAX_HW_MTU */\ndiff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c\nindex 189c45174..c01089b44 100644\n--- a/drivers/net/octeontx2/otx2_vlan.c\n+++ b/drivers/net/octeontx2/otx2_vlan.c\n@@ -303,7 +303,7 @@ nix_vlan_mcam_config(struct rte_eth_dev *eth_dev,\n \t\tentry.kw[kwi] |= NPC_LT_LB_CTAG << mkex->lb_lt_offset;\n \t\tentry.kw_mask[kwi] |= 0xFULL << mkex->lb_lt_offset;\n \n-\t\tmcam_data = (vlan_id << 16);\n+\t\tmcam_data = ((uint32_t)vlan_id << 16);\n \t\tmcam_mask = (BIT_ULL(16) - 1) << 16;\n \t\totx2_mbox_memcpy(key_data + mkex->lb_xtract.key_off,\n \t\t\t\t &mcam_data, mkex->lb_xtract.len + 1);\n@@ -649,7 +649,9 @@ otx2_nix_vlan_filter_set(struct rte_eth_dev *eth_dev, uint16_t vlan_id,\n \t} else {\n \t\tTAILQ_FOREACH(entry, &vlan->fltr_tbl, next) {\n \t\t\tif (entry->vlan_id == vlan_id) {\n-\t\t\t\tnix_vlan_mcam_free(dev, entry->mcam_idx);\n+\t\t\t\trc = nix_vlan_mcam_free(dev, entry->mcam_idx);\n+\t\t\t\tif (rc)\n+\t\t\t\t\treturn rc;\n \t\t\t\tTAILQ_REMOVE(&vlan->fltr_tbl, entry, next);\n \t\t\t\trte_free(entry);\n \t\t\t\tbreak;\n@@ -707,7 +709,7 @@ otx2_nix_vlan_offload_set(struct rte_eth_dev *eth_dev, int mask)\n \tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n \tuint64_t offloads = dev->rx_offloads;\n \tstruct rte_eth_rxmode *rxmode;\n-\tint rc;\n+\tint rc = 0;\n \n \trxmode = ð_dev->data->dev_conf.rxmode;\n \n@@ -837,8 +839,8 @@ otx2_nix_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n \t\tvtag_cfg->vtag_size = NIX_VTAGSIZE_T4;\n \n \t\tif (vlan->outer_vlan_tpid)\n-\t\t\tvtag_cfg->tx.vtag0 =\n-\t\t\t\t(vlan->outer_vlan_tpid << 16) | vlan_id;\n+\t\t\tvtag_cfg->tx.vtag0 = ((uint32_t)vlan->outer_vlan_tpid\n+\t\t\t\t\t << 16) | vlan_id;\n \t\telse\n \t\t\tvtag_cfg->tx.vtag0 =\n \t\t\t\t((RTE_ETHER_TYPE_VLAN << 16) | vlan_id);\n", "prefixes": [] }