Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57401/?format=api
{ "id": 57401, "url": "https://patches.dpdk.org/api/patches/57401/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190802235222.20682-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190802235222.20682-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190802235222.20682-3-stephen@networkplumber.org", "date": "2019-08-02T23:52:22", "name": "[v6,2/2] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "491e9eda936232d3e063cc4ea7974a595d736f9d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190802235222.20682-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5896, "url": "https://patches.dpdk.org/api/series/5896/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5896", "date": "2019-08-02T23:52:20", "name": "examples/client_server_mp: port id (fixes only)", "version": 6, "mbox": "https://patches.dpdk.org/series/5896/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57401/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F7F11C43C;\n\tSat, 3 Aug 2019 01:52:37 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 1BDA21C2ED\n\tfor <dev@dpdk.org>; Sat, 3 Aug 2019 01:52:33 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id b13so36771105pfo.1\n\tfor <dev@dpdk.org>; Fri, 02 Aug 2019 16:52:32 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt6sm5629229pgu.23.2019.08.02.16.52.30\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 02 Aug 2019 16:52:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=z+EC+KZ3Hxt68Qh9e34WkkC+eK9OIUZjm7zwDV7dSfijXQ1+12p3+cs2HlfI2ZIqM4\n\thPe5SoezHssT9/LDcrR8E+5xfub5VWHFtqxuQ/ENNbGqF+/K4Eaq9GHlc2R6ZGddu9fb\n\tPCavJUNoSQEQnIy8X2wB3Cg+31hkIVmcwJVF9/FippDyT+RMCFg9jWQ0VLW6s6h1JpN2\n\tlIAeLhc9LRkc6BhjmbeTMqUr16tqu2QwpAyXW5MTpayDVt8h9CuN4i2css7Wk1WhJ/TC\n\tt3y+hSeFMATQodk6lNXgujIiRMQlrEoCNcIJEuWkm5wlpgr5i1rhQZtQPYQHHE9YBwLZ\n\tuSTA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=Jvfoj4j6pGonHvvVZX/s83haaDFEc+w9T3dj/GtP0dKuBOQi9Uu/9P2I7Nd8qDVHM3\n\tu2D5x/6qhUJ/I1/Z3XK7CmLxwar5k+1Xgkq34sTB5j9Oj1idJFexqj9lzH9tAlLPvjnJ\n\twqb0QxW1dptzTnvuF0YJYokre1IuohC/J5BNpyAvYvEAhvRb7vXBGxNFNQEX2WHebLqo\n\tf0ecZor5jaVqv73Ge70gwp66DSyiHmEa/Jq61N7om6qu/9sjMQQyqNw25d6GU/L2RCw7\n\tljTHzPdB3Jrvjvv0kEv9jW8i48zULio/G5l2WfnKJFBqHE4qLMILrhZTQTgUlTxqa6SS\n\tn6GA==", "X-Gm-Message-State": "APjAAAU8jOL2YnQfuOxuxnXw6emzQRe4/TAMM4DjA0e/ibga5c4iImOR\n\tSgFNxaUOdpBrnHseDMAW6DYrUrZ8", "X-Google-Smtp-Source": "APXvYqy4XQkoavYqkbTycjW6E6Ibj1sEojPSavDC74wRMpH0NPKXeXA4PsDZ9EHSfq5/vTNFThtIAA==", "X-Received": "by 2002:a63:f304:: with SMTP id\n\tl4mr125462287pgh.66.1564789951925; \n\tFri, 02 Aug 2019 16:52:31 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>", "Date": "Fri, 2 Aug 2019 16:52:22 -0700", "Message-Id": "<20190802235222.20682-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190802235222.20682-1-stephen@networkplumber.org>", "References": "<20190726165054.24078-1-stephen@networkplumber.org>\n\t<20190802235222.20682-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 2/2] examples/multi_process/client_server_mp -\n\tfix crash in mp_client with sparse ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nThe mp_client crashes if run on Azure or any system where ethdev\nports are owned. In that case, the tx_buffer and tx_stats for the\nreal port were initialized correctly, but the wrong port was used.\n\nFor example if the server has Ports 3 and 5. Then calling\nrte_eth_tx_buffer_flush on any other buffer will dereference null\nbecause the tx buffer for that port was not allocated.\n\nAlso:\n - the flush code is common enough that it should not be marked\n unlikely\n - combine conditions to reduce indentation\n - avoid unnecessary if() if sent is zero.\n\nFixes: e2366e74e029 (\"examples: use buffered Tx\")\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n .../client_server_mp/mp_client/client.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_client/client.c b/examples/multi_process/client_server_mp/mp_client/client.c\nindex c23dd3f378f7..361d90b54b2d 100644\n--- a/examples/multi_process/client_server_mp/mp_client/client.c\n+++ b/examples/multi_process/client_server_mp/mp_client/client.c\n@@ -246,19 +246,19 @@ main(int argc, char *argv[])\n \n \tfor (;;) {\n \t\tuint16_t i, rx_pkts;\n-\t\tuint16_t port;\n \n \t\trx_pkts = rte_ring_dequeue_burst(rx_ring, pkts,\n \t\t\t\tPKT_READ_SIZE, NULL);\n \n-\t\tif (unlikely(rx_pkts == 0)){\n-\t\t\tif (need_flush)\n-\t\t\t\tfor (port = 0; port < ports->num_ports; port++) {\n-\t\t\t\t\tsent = rte_eth_tx_buffer_flush(ports->id[port], client_id,\n-\t\t\t\t\t\t\ttx_buffer[port]);\n-\t\t\t\t\tif (unlikely(sent))\n-\t\t\t\t\t\ttx_stats->tx[port] += sent;\n-\t\t\t\t}\n+\t\tif (rx_pkts == 0 && need_flush) {\n+\t\t\tfor (i = 0; i < ports->num_ports; i++) {\n+\t\t\t\tuint16_t port = ports->id[i];\n+\n+\t\t\t\tsent = rte_eth_tx_buffer_flush(port,\n+\t\t\t\t\t\t\t client_id,\n+\t\t\t\t\t\t\t tx_buffer[port]);\n+\t\t\t\ttx_stats->tx[port] += sent;\n+\t\t\t}\n \t\t\tneed_flush = 0;\n \t\t\tcontinue;\n \t\t}\n", "prefixes": [ "v6", "2/2" ] }