Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57379/?format=api
{ "id": 57379, "url": "https://patches.dpdk.org/api/patches/57379/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190802025826.1174-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190802025826.1174-5-stephen@networkplumber.org", "date": "2019-08-02T02:58:26", "name": "[v5,4/4] examples/multi_process/client_server_mp/mp_server: use ether format address", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a8b7a9316967cf326e2427bb76612bc012205462", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 5881, "url": "https://patches.dpdk.org/api/series/5881/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5881", "date": "2019-08-02T02:58:22", "name": "examples/client_server_mp: port id fixes", "version": 5, "mbox": "https://patches.dpdk.org/series/5881/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57379/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57379/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C18C91C227;\n\tFri, 2 Aug 2019 04:58:39 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 2E1701C20F\n\tfor <dev@dpdk.org>; Fri, 2 Aug 2019 04:58:34 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id n4so10602pgv.2\n\tfor <dev@dpdk.org>; Thu, 01 Aug 2019 19:58:34 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta20sm5788738pjo.0.2019.08.01.19.58.32\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 01 Aug 2019 19:58:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=GRL9o22FsqlZS1KIBKGsZH8PR5E+wVCUALAgsRD4EO0=;\n\tb=VRrPHxAqwsVlETKaJ2uQ8Fy/NmgObWFUBWp5PwaFjx79w+O/tF4ZoWff8Vf3Im7Rny\n\t0vcb6JzZTuOXrxlpvcvVMu3CDhfHzDFb6vn2MhAQJpbgmMKfVkoVqjuZWDZ6VlFef9m1\n\taq/UAliHZ/NTCeLeDCoOZlXcHK6pQSmuDUYVYVwkBldOXz/1sE39fNyBAP8vXZ+o4CJZ\n\tA6BHJWraj+Dx5kWu8AJzoU51gG2sNiE1qX1PC6/P5KR35qD1RMEiU4YRUk6jdO1S+bqp\n\tu4GZGY05VGsXp99yszcHiELQwgzjSFPockUiT3VAtfEfaLujcXlGoClHLLFKV7pxZVfM\n\tFF0g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=GRL9o22FsqlZS1KIBKGsZH8PR5E+wVCUALAgsRD4EO0=;\n\tb=gjgW93ts8Tc16RjUQovkeFmhH/5CjCvqNs7+Nltp5W4kfkv9cDB11Z72I+FgbnFi9D\n\twZE6aW5zPoT+kpE8Mwp4/4nXly2d61JY3tOigpD/6kZ8NDSbaUhUmYiJJSgne/hm+JjC\n\tkj8ZoNpAv2lS34YIG6dO1nMen73uApzA2x3pyJ1KuIIV+hHEusmZUQp1MmX+cUuZ9Vt9\n\tE2kElCMmjHigipruTaWewNsBZA7cXKrhMADlKF3Q9ab/KDDqTGzroSQRAV70C1DAC+hl\n\t+wRUVwbyrL4IXaEycrLF0UJNqA25/r8e70t2AWMi/N42T7gyPLi6vrr5uij1IWWA/E7q\n\tMr0A==", "X-Gm-Message-State": "APjAAAVGpJSlbAAQK2B+Do7Yzh6So4LlmrdsKp/r6VL4P7gqeFPFqzk8\n\tTYbanavBDD/AQbGAz+RpDuync3c7", "X-Google-Smtp-Source": "APXvYqygpfqT/ZZE7sHvUncnu4jY6QV/6Y3WNMd3uW4aEy+8n+5gA3Gl4IbhZNmYOeyLBSRChqyJkA==", "X-Received": "by 2002:aa7:9531:: with SMTP id\n\tc17mr59086508pfp.130.1564714712941; \n\tThu, 01 Aug 2019 19:58:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 1 Aug 2019 19:58:26 -0700", "Message-Id": "<20190802025826.1174-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190802025826.1174-1-stephen@networkplumber.org>", "References": "<20190726165054.24078-1-stephen@networkplumber.org>\n\t<20190802025826.1174-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 4/4]\n\texamples/multi_process/client_server_mp/mp_server: use ether\n\tformat address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No need to use snprintf to print ethernet address.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n .../client_server_mp/mp_server/main.c | 32 ++++++-------------\n 1 file changed, 9 insertions(+), 23 deletions(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c\nindex bfec0bef3a71..d1339d4be64c 100644\n--- a/examples/multi_process/client_server_mp/mp_server/main.c\n+++ b/examples/multi_process/client_server_mp/mp_server/main.c\n@@ -56,26 +56,6 @@ struct client_rx_buf {\n /* One buffer per client rx queue - dynamically allocate array */\n static struct client_rx_buf *cl_rx_buf;\n \n-static const char *\n-get_printable_mac_addr(uint16_t port)\n-{\n-\tstatic const char err_address[] = \"00:00:00:00:00:00\";\n-\tstatic char addresses[RTE_MAX_ETHPORTS][sizeof(err_address)];\n-\n-\tif (unlikely(port >= RTE_MAX_ETHPORTS))\n-\t\treturn err_address;\n-\tif (unlikely(addresses[port][0] == '\\0')) {\n-\t\tstruct rte_ether_addr mac;\n-\n-\t\trte_eth_macaddr_get(port, &mac);\n-\t\tsnprintf(addresses[port], sizeof(addresses[port]),\n-\t\t\t\t\"%02x:%02x:%02x:%02x:%02x:%02x\\n\",\n-\t\t\t\tmac.addr_bytes[0], mac.addr_bytes[1], mac.addr_bytes[2],\n-\t\t\t\tmac.addr_bytes[3], mac.addr_bytes[4], mac.addr_bytes[5]);\n-\t}\n-\treturn addresses[port];\n-}\n-\n /*\n * This function displays the recorded statistics for each port\n * and for each client. It uses ANSI terminal codes to clear\n@@ -118,9 +98,15 @@ do_stats_display(void)\n \n \tprintf(\"PORTS\\n\");\n \tprintf(\"-----\\n\");\n-\tfor (i = 0; i < ports->num_ports; i++)\n-\t\tprintf(\"Port %u: '%s'\\t\", ports->id[i],\n-\t\t get_printable_mac_addr(ports->id[i]));\n+\tfor (i = 0; i < ports->num_ports; i++) {\n+\t\tstruct rte_ether_addr mac = { };\n+\t\tchar buf[32];\n+\n+\t\trte_eth_macaddr_get(ports->id[i], &mac);\n+\t\trte_ether_format_addr(buf, sizeof(buf), &mac);\n+\t\tprintf(\"Port %u: '%s'\\t\", ports->id[i], buf);\n+\t}\n+\n \tprintf(\"\\n\\n\");\n \tfor (i = 0; i < ports->num_ports; i++) {\n \t\tprintf(\"Port %u - rx: %9\"PRIu64\"\\ttx: %9\"PRIu64\"\\n\",\n", "prefixes": [ "v5", "4/4" ] }