Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57377/?format=api
https://patches.dpdk.org/api/patches/57377/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190802025826.1174-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190802025826.1174-3-stephen@networkplumber.org", "date": "2019-08-02T02:58:24", "name": "[v5,2/4] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "491e9eda936232d3e063cc4ea7974a595d736f9d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5881, "url": "https://patches.dpdk.org/api/series/5881/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5881", "date": "2019-08-02T02:58:22", "name": "examples/client_server_mp: port id fixes", "version": 5, "mbox": "https://patches.dpdk.org/series/5881/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57377/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 26EE81C211;\n\tFri, 2 Aug 2019 04:58:36 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 1FB0B1C200\n\tfor <dev@dpdk.org>; Fri, 2 Aug 2019 04:58:32 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id q10so35189118pff.9\n\tfor <dev@dpdk.org>; Thu, 01 Aug 2019 19:58:31 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta20sm5788738pjo.0.2019.08.01.19.58.29\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 01 Aug 2019 19:58:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=lRD/1cKG90stvWMjNP7XOcA3QfA52V30HzlhbXI7h8c3t8Hc+ZGxygzpCnTpIX3gu7\n\tfgd+B/Qxei4KktqRCyvI1lAhK29xyX//RDO/MHt5bTcN9YBZbVNbYInrgLlooM3sKZ7R\n\tiXSSR/vnjKZo22bnLxAZjlqcF0unD5ITpBSjxwTivj2oxHO46XsLS+cZwa3kQts+FMyq\n\tCz5Itvf5o1ekvK2gFdn8ll41KJDpI7qJi5T0iI82kJOccCJMXGlopq9ikfHpyhf/8Eff\n\tnqHJN4C2dc8W31Q7oZAHjHoR5sRsxsAHQBoj8JCJ0cbbYlN6ujc40u3IFnPhMsLAdhX9\n\t/Kdg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=uWNzbwV0s5U1BxmXp6g0Xhy5S1/Hl9RWROEFtOpm6HzjV6gAtULKKCpA+mCnHokcj+\n\teml1QyOFlzhjklxeHEk0/X5bLFc3Gd7D3EfKult0sWHbqK/uWAfMIwBldBEBMmFrOMxe\n\ts7StHjv/Fv9GN+JVD/kyjm9OUyAzvUqOmsNBpkDqsGIeu/vGg+cPaFC6pG1DXfNH8Qj7\n\tQTkJB05mC+a8j/Sp81sBSdjEKxNAhSBVdzspKt8fzyPz8KIx/ojP9pixVyvWB1IqJ6WB\n\tSjbPrYezcbJsMWCdcTk5TUdwz3vSraLJ47hlEc+u8vywbExnM4gdru3D2GPSJykqfhQ5\n\tfseA==", "X-Gm-Message-State": "APjAAAULfFosN7exIyM0eTevVFRG8fyUrhmAwKFA6tiimAZpk6MrqS5X\n\t8x7L/PEMP83KxDc89mdUIDTiRrbcDLI=", "X-Google-Smtp-Source": "APXvYqwKBSH7s6R2R1fqifrtdbRAwGCGrLooq7xHk9y4bdZ5BFGBmGeU9L6n52DPfZGKjnW7oNwCmg==", "X-Received": "by 2002:a17:90a:d817:: with SMTP id\n\ta23mr1979559pjv.54.1564714710773; \n\tThu, 01 Aug 2019 19:58:30 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>", "Date": "Thu, 1 Aug 2019 19:58:24 -0700", "Message-Id": "<20190802025826.1174-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190802025826.1174-1-stephen@networkplumber.org>", "References": "<20190726165054.24078-1-stephen@networkplumber.org>\n\t<20190802025826.1174-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 2/4] examples/multi_process/client_server_mp -\n\tfix crash in mp_client with sparse ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nThe mp_client crashes if run on Azure or any system where ethdev\nports are owned. In that case, the tx_buffer and tx_stats for the\nreal port were initialized correctly, but the wrong port was used.\n\nFor example if the server has Ports 3 and 5. Then calling\nrte_eth_tx_buffer_flush on any other buffer will dereference null\nbecause the tx buffer for that port was not allocated.\n\nAlso:\n - the flush code is common enough that it should not be marked\n unlikely\n - combine conditions to reduce indentation\n - avoid unnecessary if() if sent is zero.\n\nFixes: e2366e74e029 (\"examples: use buffered Tx\")\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n .../client_server_mp/mp_client/client.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_client/client.c b/examples/multi_process/client_server_mp/mp_client/client.c\nindex c23dd3f378f7..361d90b54b2d 100644\n--- a/examples/multi_process/client_server_mp/mp_client/client.c\n+++ b/examples/multi_process/client_server_mp/mp_client/client.c\n@@ -246,19 +246,19 @@ main(int argc, char *argv[])\n \n \tfor (;;) {\n \t\tuint16_t i, rx_pkts;\n-\t\tuint16_t port;\n \n \t\trx_pkts = rte_ring_dequeue_burst(rx_ring, pkts,\n \t\t\t\tPKT_READ_SIZE, NULL);\n \n-\t\tif (unlikely(rx_pkts == 0)){\n-\t\t\tif (need_flush)\n-\t\t\t\tfor (port = 0; port < ports->num_ports; port++) {\n-\t\t\t\t\tsent = rte_eth_tx_buffer_flush(ports->id[port], client_id,\n-\t\t\t\t\t\t\ttx_buffer[port]);\n-\t\t\t\t\tif (unlikely(sent))\n-\t\t\t\t\t\ttx_stats->tx[port] += sent;\n-\t\t\t\t}\n+\t\tif (rx_pkts == 0 && need_flush) {\n+\t\t\tfor (i = 0; i < ports->num_ports; i++) {\n+\t\t\t\tuint16_t port = ports->id[i];\n+\n+\t\t\t\tsent = rte_eth_tx_buffer_flush(port,\n+\t\t\t\t\t\t\t client_id,\n+\t\t\t\t\t\t\t tx_buffer[port]);\n+\t\t\t\ttx_stats->tx[port] += sent;\n+\t\t\t}\n \t\t\tneed_flush = 0;\n \t\t\tcontinue;\n \t\t}\n", "prefixes": [ "v5", "2/4" ] }{ "id": 57377, "url": "