Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57374,
    "url": "https://patches.dpdk.org/api/patches/57374/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190802025154.328-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190802025154.328-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190802025154.328-4-stephen@networkplumber.org",
    "date": "2019-08-02T02:51:54",
    "name": "[3/3] testpmd: use exit instead of panic",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ff1cd532708e21ad3fd5a31e9b474596f85a833d",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190802025154.328-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 5880,
            "url": "https://patches.dpdk.org/api/series/5880/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5880",
            "date": "2019-08-02T02:51:51",
            "name": "testpmd: fixes for 19.08",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/5880/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/57374/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/57374/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 753FC1C20B;\n\tFri,  2 Aug 2019 04:52:12 +0200 (CEST)",
            "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id C118A1C1FB\n\tfor <dev@dpdk.org>; Fri,  2 Aug 2019 04:52:05 +0200 (CEST)",
            "by mail-pg1-f193.google.com with SMTP id k189so16228955pgk.13\n\tfor <dev@dpdk.org>; Thu, 01 Aug 2019 19:52:05 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ts24sm73911995pfh.133.2019.08.01.19.52.03\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 01 Aug 2019 19:52:03 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=DyCOaXXLJ5xS3y4c0vquyJVQrHurp2Jx8KDuemTGIYs=;\n\tb=jEj3xNbKleKKIQD5y9Sj+/nI6GiiGA8tJmw1nKx5P8FcOATNpH1OxKccGdYJ+cZLhB\n\tXtdeqEaHHkKcaUhMtQonBrnc3Z/brIFRat3qbD5TuTjWm7GbboCsPLZ2jdaVWZ9Kv/Ly\n\t0SvP6U9NL394YuqCECNWn+8m3lSa7JTbIifSj9uinlOY+3Iy3BwZHW4C5AGaamM9h0YH\n\tYDGHaNuJIBsKCRTOrERpGt7I3ePx4PW1VMK9L7Y75V312SStlEyfiWVbJuxdnwXO8INj\n\tQMoD/+O+Mi+7b/1GmAZZxws7pfYyXTneauU6nsUrq4+l6cWcL38WU+xTPffU9iyqJuQV\n\tmg7g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=DyCOaXXLJ5xS3y4c0vquyJVQrHurp2Jx8KDuemTGIYs=;\n\tb=Sj5qUT9070JWDO1a39zRbA2Tu/v5qqhaAB4sI/pFt8dTWaj3KohNWWjETFo7B7CzHv\n\tzIQNuN3cCXR3vFSAx5lUV3GsHPeaxcQQYUvu6U7CVJvjNyg19v7L/WikwkcDDgKkfGDV\n\t/mynj81CR9xV5S6pEvr1wPNMxR6XdUaSAdc19VfMrLyYhjAEfrLsNGTHfn9YyeGghOEN\n\t1QI53+2ArVBcRcUBBJRBg4wPLPV0z6JNKwIt9kJS4Gtjq2JhmnU8THKJu8iPRUNAegdo\n\tCPrjA0pz6IfQRdLN7CHQdHmuyqWl8evPegOPVnWjnlxvPFZbXHDlOimvDN5OSyux8/WM\n\typfg==",
        "X-Gm-Message-State": "APjAAAUMG9iKJefX4/4s/ODaol8mVNfU16lINNNpfdIJGObi8MFkDDuh\n\t+mEpO/kN2/9YXkedOen1ruP9lrw2",
        "X-Google-Smtp-Source": "APXvYqzotU7k5z9x3bpOOSa2u3WdBv+iwHIa4tZozL+3shaTahtU268YbPgtdpebqasiKtdHQ/OCkQ==",
        "X-Received": "by 2002:a63:5048:: with SMTP id\n\tq8mr120488591pgl.446.1564714324490; \n\tThu, 01 Aug 2019 19:52:04 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Thu,  1 Aug 2019 19:51:54 -0700",
        "Message-Id": "<20190802025154.328-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190802025154.328-1-stephen@networkplumber.org>",
        "References": "<20190802025154.328-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/3] testpmd: use exit instead of panic",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_panic causes a backtrace (which is uniformative since all\nthese calls are in main). Instead use rte_exit and try and make the\nmessages informative.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/testpmd.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex d0142cae68d7..a461cef188e3 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3236,19 +3236,21 @@ main(int argc, char** argv)\n \n \ttestpmd_logtype = rte_log_register(\"testpmd\");\n \tif (testpmd_logtype < 0)\n-\t\trte_panic(\"Cannot register log type\");\n+\t\trte_exit(EXIT_FAILURE, \"Cannot register log type\");\n \trte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG);\n \n \tdiag = rte_eal_init(argc, argv);\n \tif (diag < 0)\n-\t\trte_panic(\"Cannot init EAL\\n\");\n+\t\trte_exit(EXIT_FAILURE, \"Cannot init EAL: %s\\n\",\n+\t\t\t rte_strerror(rte_errno));\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n-\t\trte_panic(\"Secondary process type not supported.\\n\");\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t \"Secondary process type not supported.\\n\");\n \n \tret = register_eth_event_callback();\n \tif (ret != 0)\n-\t\trte_panic(\"Cannot register for ethdev events\");\n+\t\trte_exit(EXIT_FAILURE, \"Cannot register for ethdev events\");\n \n #ifdef RTE_LIBRTE_PDUMP\n \t/* initialize packet capture framework */\n@@ -3269,8 +3271,8 @@ main(int argc, char** argv)\n \n \tset_def_fwd_config();\n \tif (nb_lcores == 0)\n-\t\trte_panic(\"Empty set of forwarding logical cores - check the \"\n-\t\t\t  \"core mask supplied in the command parameters\\n\");\n+\t\trte_exit(EXIT_FAILURE, \"No cores defined for forwarding\\n\"\n+\t\t\t \"Check the core mask argument\\n\");\n \n \t/* Bitrate/latency stats disabled by default */\n #ifdef RTE_LIBRTE_BITRATE\n",
    "prefixes": [
        "3/3"
    ]
}