Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57196/?format=api
{ "id": 57196, "url": "https://patches.dpdk.org/api/patches/57196/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190726165054.24078-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190726165054.24078-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190726165054.24078-3-stephen@networkplumber.org", "date": "2019-07-26T16:50:52", "name": "[v4,2/4] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "491e9eda936232d3e063cc4ea7974a595d736f9d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190726165054.24078-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5790, "url": "https://patches.dpdk.org/api/series/5790/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5790", "date": "2019-07-26T16:50:50", "name": "examples/client_server_mp: fix port issues", "version": 4, "mbox": "https://patches.dpdk.org/series/5790/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57196/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57196/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 303DC1C515;\n\tFri, 26 Jul 2019 18:51:15 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id AFFBD1C4FF\n\tfor <dev@dpdk.org>; Fri, 26 Jul 2019 18:51:05 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id k8so24982005plt.3\n\tfor <dev@dpdk.org>; Fri, 26 Jul 2019 09:51:05 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ts3sm14747747pgq.17.2019.07.26.09.51.03\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 26 Jul 2019 09:51:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=r6lOyyzm0n16mMTrTJL2LNGIxCJl1cXhOv3jdU3TdwSexQnBpXH1+VEhVgq5bmr2sg\n\t3RMEdWxmQc5PCTeFnDgUPvxRRK9W8sp5zkX2YWM38yvzIBMTrlDo21hvakpYpv/skUjK\n\tvKlMbeFDWctB2sJ/ZAbqz61aQlqwxfGwKI/M9uRA0bQ36wU4DGHEIAen/idFsoR3o9pL\n\tB8HlS9IIouL/fExlCfPjfbFkyK2fTzUa4WtY7G24c1aC6hZpzClPfVu8b6JYLqZeIJEj\n\tkKA8PmdY6HXg/rviu+J3fQmAAJkg6FgGaxdRpxa1eiKbOD/jWe6K3q7Gv2CQ7qRQEjno\n\tPDdg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8v7OSOzARnVHBELM/KAu2BccRvpC7XvWrmT3Mxp8KjI=;\n\tb=CMPVz2GZTgieG/TbZeOVmNkuOJFoJm8aDU7bbOYrI6wRHekTFAma3A/IhDdC01HEfb\n\t83USbvkI+V6iRHCGxVuw/ksErdbh6uw+8SHG/TxJ9I9ruGyvds/tqCA5zaufVRHNKwLn\n\tk3QP1Ca7e2kC1FTsQ8D/MuJbEc2XEUUzJDfa0wIypmTbH4cqxNtTOgISsCXkXUfYYIB2\n\t2iqjBVZiV0bVcurB8e4tkfVdPh7KdTPTHChgdPEKUMi036mhv7D8ieHQYwJQ0638Zgug\n\tmzuOCSFHCL1zvONlP9uZr+ZNRVBssgASOhvUhP+LyP4iuT7iIndRonFihvu5ZvonEcUg\n\tBNHg==", "X-Gm-Message-State": "APjAAAWyWEstF9el+dActtucv1ep3mAc5AvoNAkYx1GNFsgVTYNE5Zcv\n\teJbEkj4Y4dsT4mVdeeqNCjFSffS0", "X-Google-Smtp-Source": "APXvYqyTnw2CKhU/elZDMInhDDNs/54zhBjyH1T7CC+2YRG9olH1DTUtO3Qy7LsbWfVKndEGLnD89Q==", "X-Received": "by 2002:a17:902:7781:: with SMTP id\n\to1mr97324417pll.205.1564159864665; \n\tFri, 26 Jul 2019 09:51:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>", "Date": "Fri, 26 Jul 2019 09:50:52 -0700", "Message-Id": "<20190726165054.24078-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190726165054.24078-1-stephen@networkplumber.org>", "References": "<20190709150939.31338-1-stephen@networkplumber.org>\n\t<20190726165054.24078-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/4] examples/multi_process/client_server_mp -\n\tfix crash in mp_client with sparse ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nThe mp_client crashes if run on Azure or any system where ethdev\nports are owned. In that case, the tx_buffer and tx_stats for the\nreal port were initialized correctly, but the wrong port was used.\n\nFor example if the server has Ports 3 and 5. Then calling\nrte_eth_tx_buffer_flush on any other buffer will dereference null\nbecause the tx buffer for that port was not allocated.\n\nAlso:\n - the flush code is common enough that it should not be marked\n unlikely\n - combine conditions to reduce indentation\n - avoid unnecessary if() if sent is zero.\n\nFixes: e2366e74e029 (\"examples: use buffered Tx\")\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n .../client_server_mp/mp_client/client.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_client/client.c b/examples/multi_process/client_server_mp/mp_client/client.c\nindex c23dd3f378f7..361d90b54b2d 100644\n--- a/examples/multi_process/client_server_mp/mp_client/client.c\n+++ b/examples/multi_process/client_server_mp/mp_client/client.c\n@@ -246,19 +246,19 @@ main(int argc, char *argv[])\n \n \tfor (;;) {\n \t\tuint16_t i, rx_pkts;\n-\t\tuint16_t port;\n \n \t\trx_pkts = rte_ring_dequeue_burst(rx_ring, pkts,\n \t\t\t\tPKT_READ_SIZE, NULL);\n \n-\t\tif (unlikely(rx_pkts == 0)){\n-\t\t\tif (need_flush)\n-\t\t\t\tfor (port = 0; port < ports->num_ports; port++) {\n-\t\t\t\t\tsent = rte_eth_tx_buffer_flush(ports->id[port], client_id,\n-\t\t\t\t\t\t\ttx_buffer[port]);\n-\t\t\t\t\tif (unlikely(sent))\n-\t\t\t\t\t\ttx_stats->tx[port] += sent;\n-\t\t\t\t}\n+\t\tif (rx_pkts == 0 && need_flush) {\n+\t\t\tfor (i = 0; i < ports->num_ports; i++) {\n+\t\t\t\tuint16_t port = ports->id[i];\n+\n+\t\t\t\tsent = rte_eth_tx_buffer_flush(port,\n+\t\t\t\t\t\t\t client_id,\n+\t\t\t\t\t\t\t tx_buffer[port]);\n+\t\t\t\ttx_stats->tx[port] += sent;\n+\t\t\t}\n \t\t\tneed_flush = 0;\n \t\t\tcontinue;\n \t\t}\n", "prefixes": [ "v4", "2/4" ] }