Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5716/?format=api
{ "id": 5716, "url": "https://patches.dpdk.org/api/patches/5716/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1435116386-12010-3-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435116386-12010-3-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435116386-12010-3-git-send-email-wenzhuo.lu@intel.com", "date": "2015-06-24T03:25:51", "name": "[dpdk-dev,02/37] ixgbe/base: update Low Power Link Up to use MAC ops link", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "36cca2f07baf9420692029b370a381d708ddf2d2", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1435116386-12010-3-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5716/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 941A6C636;\n\tWed, 24 Jun 2015 05:26:40 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 7E2EDC62C\n\tfor <dev@dpdk.org>; Wed, 24 Jun 2015 05:26:39 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 23 Jun 2015 20:26:39 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 23 Jun 2015 20:26:39 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t5O3QZaq019247;\n\tWed, 24 Jun 2015 11:26:35 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t5O3QWmW012060; Wed, 24 Jun 2015 11:26:34 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t5O3QWxX012056; \n\tWed, 24 Jun 2015 11:26:32 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,669,1427785200\"; d=\"scan'208\";a=\"749302340\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 24 Jun 2015 11:25:51 +0800", "Message-Id": "<1435116386-12010-3-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1435116386-12010-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1435116386-12010-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH 02/37] ixgbe/base: update Low Power Link Up to\n\tuse MAC ops link", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch updates x550em LPLU to use the MAC ops setup_link\nfunction pointer. This removes redundant code and provides iXFI\nand KR support between internal and external PHY.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 44 ++-----------------------------------\n 1 file changed, 2 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex da312ba..fd46699 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -2556,48 +2556,8 @@ s32 ixgbe_enter_lplu_t_x550em(struct ixgbe_hw *hw)\n \tif (status != IXGBE_SUCCESS)\n \t\treturn status;\n \n-\t/* Set AN advertizement to only include LCD */\n-\tif (lcd_speed == IXGBE_LINK_SPEED_1GB_FULL) {\n-\t\tan_10g_cntl_reg &= ~IXGBE_MII_10GBASE_T_ADVERTISE;\n-\t\tautoneg_reg |= IXGBE_MII_1GBASE_T_ADVERTISE;\n-\t}\n-\n-\tif (lcd_speed == IXGBE_LINK_SPEED_10GB_FULL) {\n-\t\tan_10g_cntl_reg |= IXGBE_MII_10GBASE_T_ADVERTISE;\n-\t\tautoneg_reg &= ~IXGBE_MII_1GBASE_T_ADVERTISE;\n-\t}\n-\n-\tstatus = hw->phy.ops.write_reg(hw, IXGBE_MII_10GBASE_T_AUTONEG_CTRL_REG,\n-\t\t\t IXGBE_MDIO_AUTO_NEG_DEV_TYPE,\n-\t\t\t an_10g_cntl_reg);\n-\n-\tif (status != IXGBE_SUCCESS)\n-\t\treturn status;\n-\n-\tstatus = hw->phy.ops.write_reg(hw,\n-\t\t\t IXGBE_MII_AUTONEG_VENDOR_PROVISION_1_REG,\n-\t\t\t IXGBE_MDIO_AUTO_NEG_DEV_TYPE,\n-\t\t\t autoneg_reg);\n-\n-\tif (status != IXGBE_SUCCESS)\n-\t\treturn status;\n-\n-\t/* Restart PHY auto-negotiation. */\n-\tstatus = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_CONTROL,\n-\t\t\t IXGBE_MDIO_AUTO_NEG_DEV_TYPE, &autoneg_reg);\n-\n-\tif (status != IXGBE_SUCCESS)\n-\t\treturn status;\n-\n-\tautoneg_reg |= IXGBE_MII_RESTART;\n-\n-\tstatus = hw->phy.ops.write_reg(hw, IXGBE_MDIO_AUTO_NEG_CONTROL,\n-\t\t\t IXGBE_MDIO_AUTO_NEG_DEV_TYPE, autoneg_reg);\n-\n-\tif (status != IXGBE_SUCCESS)\n-\t\treturn status;\n-\n-\tstatus = ixgbe_setup_ixfi_x550em(hw, &lcd_speed);\n+\t/* Setup link at least common link speed */\n+\tstatus = hw->mac.ops.setup_link(hw, lcd_speed, false);\n \n \treturn status;\n }\n", "prefixes": [ "dpdk-dev", "02/37" ] }