Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57069/?format=api
{ "id": 57069, "url": "https://patches.dpdk.org/api/patches/57069/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1564043050-28306-1-git-send-email-skori@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1564043050-28306-1-git-send-email-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1564043050-28306-1-git-send-email-skori@marvell.com", "date": "2019-07-25T08:24:10", "name": "[v3,1/1] examples/ip_frag: fix Tx fast free offload flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5c444e7771f16af04088ab3a243d3006883eeed", "submitter": { "id": 1318, "url": "https://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1564043050-28306-1-git-send-email-skori@marvell.com/mbox/", "series": [ { "id": 5735, "url": "https://patches.dpdk.org/api/series/5735/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5735", "date": "2019-07-25T08:24:10", "name": "[v3,1/1] examples/ip_frag: fix Tx fast free offload flag", "version": 3, "mbox": "https://patches.dpdk.org/series/5735/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57069/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57069/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65FF01C2B0;\n\tThu, 25 Jul 2019 10:24:28 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C9D541C289;\n\tThu, 25 Jul 2019 10:24:25 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx6P8GEWT024957; Thu, 25 Jul 2019 01:24:24 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2tx61rgke6-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tThu, 25 Jul 2019 01:24:24 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n\t(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tThu, 25 Jul 2019 01:24:23 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Thu, 25 Jul 2019 01:24:23 -0700", "from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com\n\t[10.28.113.55])\n\tby maili.marvell.com (Postfix) with ESMTP id 4BF1B3F703F;\n\tThu, 25 Jul 2019 01:24:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type; s=pfpt0818;\n\tbh=u0JVxcuQ4HcCf7I47exhpHY7HHmt1uU2NeaN4yDKqIg=; \n\tb=O/JIoTsGtqbKh9rrEqB815Cc5BmTO8bmmUeFYWMig1vrdQOZUFDAct1dA9it+b8Q9ILO\n\tgOk/92qpf1kGV/2hery0vBHCdHhKDix6RDKaQt7mtnsU7814ZRCIL2M3HXMiLYO96h/+\n\t2KvXW0pU7jiEJgG3Tkp0415TfkLx+3Ue65iBYA4eH+p2gi8BcEDEo/qAzUU0/9NCJzBn\n\tAjE3ErZNqnjwzLmb2XwYY0ibqG/OcsPzW1Z0InYwUJGl1u5Ss4zEqcZLQcZFvycVWJRp\n\tKs48ulnTYjz6RXcZFVWrqDzwT4Xr6KBDfZgvJnn2gaswmDA57Y22qDQzRFW7AWviZX8h\n\tPw== ", "From": "Sunil Kumar Kori <skori@marvell.com>", "To": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>", "Date": "Thu, 25 Jul 2019 13:54:10 +0530", "Message-ID": "<1564043050-28306-1-git-send-email-skori@marvell.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1564034330-16321-1-git-send-email-skori@marvell.com>", "References": "<1564034330-16321-1-git-send-email-skori@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:5.22.84,1.0.8\n\tdefinitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free\n\toffload flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Application uses different pool to allocate direct and indirect\nmbufs which are further spliced together to consturct a fragmented\npacket and same is transmitted over the port which is configured\nwith DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments\nmust belong to the same pool. But constructed packet violates\nthe conditions.\n\nSo fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device\nconfiguration.\n\nFixes: fdb9eff67f0c (\"examples/ip_fragmentation: convert to new offloads API\")\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\nv3:\n - Add Fixes tag\nv2:\n - Subject is corrected.\n\n examples/ip_fragmentation/main.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\nindex 03be0c1..324d607 100644\n--- a/examples/ip_fragmentation/main.c\n+++ b/examples/ip_fragmentation/main.c\n@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {\n \t\tn_tx_queue = nb_lcores;\n \t\tif (n_tx_queue > MAX_TX_QUEUE_PER_PORT)\n \t\t\tn_tx_queue = MAX_TX_QUEUE_PER_PORT;\n-\t\tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)\n-\t\t\tlocal_port_conf.txmode.offloads |=\n-\t\t\t\tDEV_TX_OFFLOAD_MBUF_FAST_FREE;\n \t\tret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,\n \t\t\t\t\t &local_port_conf);\n \t\tif (ret < 0) {\n", "prefixes": [ "v3", "1/1" ] }