Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57049/?format=api
{ "id": 57049, "url": "https://patches.dpdk.org/api/patches/57049/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190724202813.9743-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190724202813.9743-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190724202813.9743-2-stephen@networkplumber.org", "date": "2019-07-24T20:28:12", "name": "[1/2] mk: fix missing pci bus with shared library build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "689a29d21ab49bfad40a3f842430f8454009f493", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190724202813.9743-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 5722, "url": "https://patches.dpdk.org/api/series/5722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5722", "date": "2019-07-24T20:28:11", "name": "mk: fix build with shared library", "version": 1, "mbox": "https://patches.dpdk.org/series/5722/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57049/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57049/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ADF4B1C269;\n\tWed, 24 Jul 2019 22:28:29 +0200 (CEST)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n\t[209.85.214.179]) by dpdk.org (Postfix) with ESMTP id 986931C25A\n\tfor <dev@dpdk.org>; Wed, 24 Jul 2019 22:28:25 +0200 (CEST)", "by mail-pl1-f179.google.com with SMTP id y8so22438195plr.12\n\tfor <dev@dpdk.org>; Wed, 24 Jul 2019 13:28:25 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tm4sm58020378pgs.71.2019.07.24.13.28.22\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 24 Jul 2019 13:28:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=g8MpBF8semt6kcRCtP6Vo4lAPv6x3WeGpB6MeTxzd1I=;\n\tb=XJ4HQSMqhVKJ5ZFQS9WKhJGNQWP7O9jZihcvarpBvq4zs8mreGpIaTKh9Ozu5UTnL7\n\tnYOz5XGCSPxZgre6/0RliOdZ95wBgG8jfgmS2I3k4O13kBML++OEcrecJPNwAsefJGPF\n\tUaB4HHKCWR+qOhzYKykjooy31MFxWsGNtMkgyWKKGnJvpE6WQjJL9Lm07PXgXZphIpSz\n\t/0gn0HzOo86ZsXub8OnummUMGi+RQPi3YlNQ5xgpm6W69PNmvAeZ/53aKV4RoZLgwCve\n\tcAQWefFyW2W3IAP1SDrQ2zJrpJsF341L823ww2XFuvdzVVsAsNTgKGXZGw3V1PMdTPDC\n\tgfmw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=g8MpBF8semt6kcRCtP6Vo4lAPv6x3WeGpB6MeTxzd1I=;\n\tb=AAR8g+HilaT7MytTTl/y7HakeHhz8bMzqZ6jTjaB/uuIG8pwWC3SZuD7xSvcZwzQvS\n\tz2PE5834Q1acQbOPne7Z+UDIDI2Jl6l7Mh6shfKwqAeX1ZQSRljxLeNcbDNWjuC6xQLG\n\tO/p3yJl76lUt6pIKv9rrnB/IXQxQRfXlUdfOP1gdTcsXBjrPiy0cFVhgSZJR3VYXPEvo\n\triyiXyd6YW/ElRpE3kIfU1ver6YQ5l4SiLsKNdsvHoxoF8IbOQadAVXnXDylUYBsIvCU\n\trXxJCjKiTGpYJfG8Exv6VQE5Hk13CnkcOBzrU8f6fdyRS0ojKmB4jPy8FRfk/aPFMuWp\n\tIPHA==", "X-Gm-Message-State": "APjAAAXgVggZqXhtLPA/TEXbrXjn8jAhs9Vt8c0TNvF79D+URJVG5VL/\n\t0cvtx34wgUnqBxAFEEmLfxTAiyIV", "X-Google-Smtp-Source": "APXvYqxCQbZEILKrS89P79n0cV5f9mHhm2Ibw0wxk+mWkhN7uqNOjI6T94U7S2h1u3k04Zs2YRU3Ew==", "X-Received": "by 2002:a17:902:12d:: with SMTP id\n\t42mr83149517plb.187.1564000104273; \n\tWed, 24 Jul 2019 13:28:24 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tstable@dpdk.org", "Date": "Wed, 24 Jul 2019 13:28:12 -0700", "Message-Id": "<20190724202813.9743-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190724202813.9743-1-stephen@networkplumber.org>", "References": "<20190724202813.9743-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] mk: fix missing pci bus with shared library\n\tbuild", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If DPDK is built as a shared library, then any application linked\nwith rte.app.mk will not find any buses (including PCI devices).\n\nThis is because the linker will not call the initializers\nof the bus libraries since they are not directly called by\napplication or EAL.\n\nBugzilla ID: 333\nFixes: c752998b5e2e (\"pci: introduce library and driver\")\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n mk/rte.app.mk | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex a277c808ed8e..3b3156bfcf09 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -123,6 +123,10 @@ ifneq (,$(findstring y,$(MVEP-y)))\n _LDLIBS-y += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk\n endif\n \n+# Bus devices use constructors to register and therefore\n+# need to be always linked in (--whole-archive already enabled)\n+_LDLIBS-y += --no-as-needed\n+\n ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax\n endif\n@@ -137,6 +141,9 @@ ifeq ($(CONFIG_RTE_EAL_VFIO),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += -lrte_bus_fslmc\n endif\n \n+# drivers are as-needed\n+_LDLIBS-y += --as-needed\n+\n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n # plugins (link only if static libraries)\n \n", "prefixes": [ "1/2" ] }