Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5702/?format=api
https://patches.dpdk.org/api/patches/5702/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1435024235-19483-15-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435024235-19483-15-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435024235-19483-15-git-send-email-helin.zhang@intel.com", "date": "2015-06-23T01:50:31", "name": "[dpdk-dev,v8,14/18] examples/ip_reassembly: replace bit mask based packet type with unified packet type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3846e0c95233cb08f1bc69bde60f2ea52ab5f82a", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1435024235-19483-15-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5702/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CF51AC8E4;\n\tTue, 23 Jun 2015 03:51:53 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B4191C88C\n\tfor <dev@dpdk.org>; Tue, 23 Jun 2015 03:51:20 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 22 Jun 2015 18:51:19 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 22 Jun 2015 18:51:19 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t5N1pGCX024385;\n\tTue, 23 Jun 2015 09:51:16 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t5N1pDoH019725; Tue, 23 Jun 2015 09:51:15 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t5N1pDn9019721; \n\tTue, 23 Jun 2015 09:51:13 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,663,1427785200\"; d=\"scan'208\";a=\"732637079\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 23 Jun 2015 09:50:31 +0800", "Message-Id": "<1435024235-19483-15-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1435024235-19483-1-git-send-email-helin.zhang@intel.com>", "References": "<1434701661-9943-1-git-send-email-helin.zhang@intel.com>\n\t<1435024235-19483-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 14/18] examples/ip_reassembly: replace bit\n\tmask based packet type with unified packet type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To unify packet types among all PMDs, bit masks of packet type for\n'ol_flags' are replaced by unified packet type.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_NEXT_ABI, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n examples/ip_reassembly/main.c | 9 +++++++++\n 1 file changed, 9 insertions(+)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.\n\nv5 changes:\n* Re-worded the commit logs.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n avoid breaking ABI compatibility.\n\nv7 changes:\n* Renamed RTE_UNIFIED_PKT_TYPE to RTE_NEXT_ABI.", "diff": "diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c\nindex 9ecb6f9..f1c47ad 100644\n--- a/examples/ip_reassembly/main.c\n+++ b/examples/ip_reassembly/main.c\n@@ -356,7 +356,11 @@ reassemble(struct rte_mbuf *m, uint8_t portid, uint32_t queue,\n \tdst_port = portid;\n \n \t/* if packet is IPv4 */\n+#ifdef RTE_NEXT_ABI\n+\tif (RTE_ETH_IS_IPV4_HDR(m->packet_type)) {\n+#else\n \tif (m->ol_flags & (PKT_RX_IPV4_HDR)) {\n+#endif\n \t\tstruct ipv4_hdr *ip_hdr;\n \t\tuint32_t ip_dst;\n \n@@ -396,9 +400,14 @@ reassemble(struct rte_mbuf *m, uint8_t portid, uint32_t queue,\n \t\t}\n \n \t\teth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);\n+#ifdef RTE_NEXT_ABI\n+\t} else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {\n+\t\t/* if packet is IPv6 */\n+#else\n \t}\n \t/* if packet is IPv6 */\n \telse if (m->ol_flags & (PKT_RX_IPV6_HDR | PKT_RX_IPV6_HDR_EXT)) {\n+#endif\n \t\tstruct ipv6_extension_fragment *frag_hdr;\n \t\tstruct ipv6_hdr *ip_hdr;\n \n", "prefixes": [ "dpdk-dev", "v8", "14/18" ] }{ "id": 5702, "url": "