Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56842/?format=api
{ "id": 56842, "url": "https://patches.dpdk.org/api/patches/56842/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1563786795-14027-17-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1563786795-14027-17-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1563786795-14027-17-git-send-email-matan@mellanox.com", "date": "2019-07-22T09:13:03", "name": "[16/28] net/mlx5: rename hash RxQ verbs to general", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5678d8a6be9095b304bc9330bc6ad5c957d80b5c", "submitter": { "id": 796, "url": "https://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1563786795-14027-17-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 5639, "url": "https://patches.dpdk.org/api/series/5639/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5639", "date": "2019-07-22T09:12:48", "name": "net/mlx5: support LRO", "version": 1, "mbox": "https://patches.dpdk.org/series/5639/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56842/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AEB3D1BE5E;\n\tMon, 22 Jul 2019 11:14:11 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 30CB71BDF2\n\tfor <dev@dpdk.org>; Mon, 22 Jul 2019 11:13:30 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tmatan@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 22 Jul 2019 12:13:24 +0300", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n\t[10.210.16.112])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6M9DMjf010084;\n\tMon, 22 Jul 2019 12:13:23 +0300" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>, \n\tViacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "dev@dpdk.org, Dekel Peled <dekelp@mellanox.com>", "Date": "Mon, 22 Jul 2019 09:13:03 +0000", "Message-Id": "<1563786795-14027-17-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1563786795-14027-1-git-send-email-matan@mellanox.com>", "References": "<1563786795-14027-1-git-send-email-matan@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 16/28] net/mlx5: rename hash RxQ verbs to general", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dekel Peled <dekelp@mellanox.com>\n\nPrepare for introducing use of DevX TIR object.\nHash Rx queue is currently created using verbs QP only.\nThe next patches will add the option to create it with a TIR object\nusing DevX.\nThis patch renames hrxq_ibv to hrxq wherever relevant, and adds\nthe DevX items to relevant structs.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 2 +-\n drivers/net/mlx5/mlx5_rxq.c | 8 ++++----\n drivers/net/mlx5/mlx5_rxtx.h | 8 ++++++--\n 3 files changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 23ee887..776198f 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -815,7 +815,7 @@ struct mlx5_dev_spawn_data {\n \t\tmlx5_free_shared_ibctx(priv->sh);\n \t\tpriv->sh = NULL;\n \t}\n-\tret = mlx5_hrxq_ibv_verify(dev);\n+\tret = mlx5_hrxq_verify(dev);\n \tif (ret)\n \t\tDRV_LOG(WARNING, \"port %u some hash Rx queue still remain\",\n \t\t\tdev->data->port_id);\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 507a1ab..d3bc3ee 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1741,7 +1741,7 @@ struct mlx5_rxq_ctrl *\n * Tunnel type.\n *\n * @return\n- * The Verbs object initialised, NULL otherwise and rte_errno is set.\n+ * The Verbs/DevX object initialised, NULL otherwise and rte_errno is set.\n */\n struct mlx5_hrxq *\n mlx5_hrxq_new(struct rte_eth_dev *dev,\n@@ -1937,7 +1937,7 @@ struct mlx5_hrxq *\n * The number of object not released.\n */\n int\n-mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev)\n+mlx5_hrxq_verify(struct rte_eth_dev *dev)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_hrxq *hrxq;\n@@ -1945,7 +1945,7 @@ struct mlx5_hrxq *\n \n \tLIST_FOREACH(hrxq, &priv->hrxqs, next) {\n \t\tDRV_LOG(DEBUG,\n-\t\t\t\"port %u Verbs hash Rx queue %p still referenced\",\n+\t\t\t\"port %u hash Rx queue %p still referenced\",\n \t\t\tdev->data->port_id, (void *)hrxq);\n \t\t++ret;\n \t}\n@@ -2106,7 +2106,7 @@ struct mlx5_hrxq *\n * Pointer to Ethernet device.\n *\n * @return\n- * The Verbs object initialised, NULL otherwise and rte_errno is set.\n+ * The Verbs/DevX object initialised, NULL otherwise and rte_errno is set.\n */\n struct mlx5_hrxq *\n mlx5_hrxq_drop_new(struct rte_eth_dev *dev)\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 0e7b428..f4f5c0d 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -200,7 +200,11 @@ struct mlx5_hrxq {\n \tLIST_ENTRY(mlx5_hrxq) next; /* Pointer to the next element. */\n \trte_atomic32_t refcnt; /* Reference counter. */\n \tstruct mlx5_ind_table_obj *ind_table; /* Indirection table. */\n-\tstruct ibv_qp *qp; /* Verbs queue pair. */\n+\tRTE_STD_C11\n+\tunion {\n+\t\tstruct ibv_qp *qp; /* Verbs queue pair. */\n+\t\tstruct mlx5_devx_obj *tir; /* DevX TIR object. */\n+\t};\n #ifdef HAVE_IBV_FLOW_DV_SUPPORT\n \tvoid *action; /* DV QP action pointer. */\n #endif\n@@ -341,7 +345,7 @@ struct mlx5_hrxq *mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t\t\t\tuint64_t hash_fields,\n \t\t\t\tconst uint16_t *queues, uint32_t queues_n);\n int mlx5_hrxq_release(struct rte_eth_dev *dev, struct mlx5_hrxq *hxrq);\n-int mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev);\n+int mlx5_hrxq_verify(struct rte_eth_dev *dev);\n struct mlx5_hrxq *mlx5_hrxq_drop_new(struct rte_eth_dev *dev);\n void mlx5_hrxq_drop_release(struct rte_eth_dev *dev);\n uint64_t mlx5_get_rx_port_offloads(struct rte_eth_dev *dev);\n", "prefixes": [ "16/28" ] }