Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56799/?format=api
{ "id": 56799, "url": "https://patches.dpdk.org/api/patches/56799/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190720071956.68197-1-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190720071956.68197-1-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190720071956.68197-1-ajit.khaparde@broadcom.com", "date": "2019-07-20T07:19:55", "name": "[1/2] net/bnxt: fix rxq start", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b1a88a7886bd7014a46348cc279be46b35dfc50f", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190720071956.68197-1-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5628, "url": "https://patches.dpdk.org/api/series/5628/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5628", "date": "2019-07-20T07:19:55", "name": "[1/2] net/bnxt: fix rxq start", "version": 1, "mbox": "https://patches.dpdk.org/series/5628/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56799/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56799/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33EB22BE5;\n\tSat, 20 Jul 2019 09:20:10 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 3018E1B53\n\tfor <dev@dpdk.org>; Sat, 20 Jul 2019 09:20:08 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 287EC30C109;\n\tSat, 20 Jul 2019 00:20:06 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.47.58])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 10014AC0749;\n\tSat, 20 Jul 2019 00:20:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 287EC30C109", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563607206;\n\tbh=U6/4uaSPlFbCf4c0w8eiWAvvKf4rPRphQk7WR+I2OVM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Hoo9zFWd+Ah8dF8JbSLwwQYM6eGXvLTEDGjMa/bODQ/w5kL/791oQAhQBXFB7llFM\n\t5jQtzkiYJX4yipQpbNbTHMCnUKMEnVPmqe9r0VRyAa5SyXj8DmzFxIN2nDvgu0+QWh\n\tTgrMgRqYJKoh53+ZixUb9HY3tH0m15F/ah5iFGGs=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Sat, 20 Jul 2019 12:49:55 +0530", "Message-Id": "<20190720071956.68197-1-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/bnxt: fix rxq start", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. Added a missing return in bnxt_alloc_hwrm_rx_ring().\n2. Added a missing return value check\n3. Moved the log message to right place.\n\nFixes: 05b5e4821c1e (\"net/bnxt: use dedicated CPR for async events\")\n\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ring.c | 6 ++----\n drivers/net/bnxt/bnxt_rxq.c | 17 +++++++++++++----\n 2 files changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 05a9a200c..80da098ef 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -546,10 +546,8 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \t\tbnxt_db_write(&rxr->ag_db, rxr->ag_prod);\n \t}\n \trxq->index = queue_index;\n-\tPMD_DRV_LOG(INFO,\n-\t\t \"queue %d, rx_deferred_start %d, state %d!\\n\",\n-\t\t queue_index, rxq->rx_deferred_start,\n-\t\t bp->eth_dev->data->rx_queue_state[queue_index]);\n+\n+\treturn 0;\n \n err_out:\n \tPMD_DRV_LOG(ERR,\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex e0eb890f8..4082c3aa9 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -411,10 +411,11 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\treturn -EINVAL;\n \t}\n \n-\tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n-\n \tbnxt_free_hwrm_rx_ring(bp, rx_queue_id);\n-\tbnxt_alloc_hwrm_rx_ring(bp, rx_queue_id);\n+\trc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id);\n+\tif (rc)\n+\t\treturn rc;\n+\n \tPMD_DRV_LOG(INFO, \"Rx queue started %d\\n\", rx_queue_id);\n \n \tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {\n@@ -435,8 +436,16 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n-\tif (rc == 0)\n+\tif (rc == 0) {\n+\t\tdev->data->rx_queue_state[rx_queue_id] =\n+\t\t\t\tRTE_ETH_QUEUE_STATE_STARTED;\n \t\trxq->rx_deferred_start = false;\n+\t}\n+\n+\tPMD_DRV_LOG(INFO,\n+\t\t \"queue %d, rx_deferred_start %d, state %d!\\n\",\n+\t\t rx_queue_id, rxq->rx_deferred_start,\n+\t\t bp->eth_dev->data->rx_queue_state[rx_queue_id]);\n \n \treturn rc;\n }\n", "prefixes": [ "1/2" ] }