Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56727/?format=api
https://patches.dpdk.org/api/patches/56727/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190718160943.10724-3-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718160943.10724-3-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718160943.10724-3-arkadiuszx.kusztal@intel.com", "date": "2019-07-18T16:09:38", "name": "[v5,2/7] cryptodev: add cipher field to RSA op", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "479817a0085e8d42c21b18bc50e537ef6339acd1", "submitter": { "id": 452, "url": "https://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190718160943.10724-3-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 5600, "url": "https://patches.dpdk.org/api/series/5600/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5600", "date": "2019-07-18T16:09:36", "name": "Rework API for RSA algorithm in asymmetric crypto", "version": 5, "mbox": "https://patches.dpdk.org/series/5600/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56727/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/56727/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 912021B951;\n\tThu, 18 Jul 2019 18:10:47 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id C6B881B4B6\n\tfor <dev@dpdk.org>; Thu, 18 Jul 2019 18:10:46 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jul 2019 09:10:46 -0700", "from akusztax-mobl.ger.corp.intel.com ([10.104.14.174])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Jul 2019 09:10:44 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,278,1559545200\"; d=\"scan'208\";a=\"187815303\"", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com, shallyv@marvell.com,\n\tdamianx.nowak@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Thu, 18 Jul 2019 18:09:38 +0200", "Message-Id": "<20190718160943.10724-3-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.19.1.windows.1", "In-Reply-To": "<20190718160943.10724-1-arkadiuszx.kusztal@intel.com>", "References": "<20190718160943.10724-1-arkadiuszx.kusztal@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 2/7] cryptodev: add cipher field to RSA op", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Asymmetric nature of RSA algorithm suggest to use\nadditional field for output. In place operations\nstill can be done by setting cipher and message pointers\nwith the same memory address.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/librte_cryptodev/rte_crypto_asym.h | 43 ++++++++++++++++++++++++++++------\n 1 file changed, 36 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h\nindex 02ec304..1d4ec80 100644\n--- a/lib/librte_cryptodev/rte_crypto_asym.h\n+++ b/lib/librte_cryptodev/rte_crypto_asym.h\n@@ -395,21 +395,50 @@ struct rte_crypto_rsa_op_param {\n \n \trte_crypto_param message;\n \t/**<\n-\t * Pointer to data\n+\t * Pointer to input data\n \t * - to be encrypted for RSA public encrypt.\n-\t * - to be decrypted for RSA private decrypt.\n \t * - to be signed for RSA sign generation.\n \t * - to be authenticated for RSA sign verification.\n+\t *\n+\t * Pointer to output data\n+\t * - for RSA private decrypt.\n+\t * In this case the underlying array should have been\n+\t * allocated with enough memory to hold plaintext output\n+\t * (i.e. must be at least RSA key size). The message.length\n+\t * field should be 0 and will be overwritten by the PMD\n+\t * with the decrypted length.\n+\t *\n+\t * All data is in Octet-string network byte order format.\n+\t */\n+\n+\trte_crypto_param cipher;\n+\t/**<\n+\t * Pointer to input data\n+\t * - to be decrypted for RSA private decrypt.\n+\t *\n+\t * Pointer to output data\n+\t * - for RSA public encrypt.\n+\t * In this case the underlying array should have been allocated\n+\t * with enough memory to hold ciphertext output (i.e. must be\n+\t * at least RSA key size). The cipher.length field should\n+\t * be 0 and will be overwritten by the PMD with the encrypted length.\n+\t *\n+\t * All data is in Octet-string network byte order format.\n \t */\n \n \trte_crypto_param sign;\n \t/**<\n-\t * Pointer to RSA signature data. If operation is RSA\n-\t * sign @ref RTE_CRYPTO_ASYM_OP_SIGN, buffer will be\n-\t * over-written with generated signature.\n+\t * Pointer to input data\n+\t * - to be verified for RSA public decrypt.\n+\t *\n+\t * Pointer to output data\n+\t * - for RSA private encrypt.\n+\t * In this case the underlying array should have been allocated\n+\t * with enough memory to hold signature output (i.e. must be\n+\t * at least RSA key size). The sign.length field should\n+\t * be 0 and will be overwritten by the PMD with the signature length.\n \t *\n-\t * Length of the signature data will be equal to the\n-\t * RSA modulus length.\n+\t * All data is in Octet-string network byte order format.\n \t */\n \n \tenum rte_crypto_rsa_padding_type pad;\n", "prefixes": [ "v5", "2/7" ] }{ "id": 56727, "url": "