Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5669,
    "url": "https://patches.dpdk.org/api/patches/5669/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1434998063-15739-4-git-send-email-cchemparathy@ezchip.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1434998063-15739-4-git-send-email-cchemparathy@ezchip.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1434998063-15739-4-git-send-email-cchemparathy@ezchip.com",
    "date": "2015-06-22T18:34:17",
    "name": "[dpdk-dev,v4,3/9] ethdev: silence -Wcast-align on pointer arithmetic",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "554b9c66052094bed62bcfe81d92ac83eeea1819",
    "submitter": {
        "id": 132,
        "url": "https://patches.dpdk.org/api/people/132/?format=api",
        "name": "Cyril Chemparathy",
        "email": "cchemparathy@ezchip.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1434998063-15739-4-git-send-email-cchemparathy@ezchip.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/5669/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/5669/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4E29AC8D0;\n\tMon, 22 Jun 2015 20:34:48 +0200 (CEST)",
            "from sclab-apps-2.localdomain (sc-fw1.tilera.com [12.218.212.162])\n\tby dpdk.org (Postfix) with ESMTP id E8377C850\n\tfor <dev@dpdk.org>; Mon, 22 Jun 2015 20:34:31 +0200 (CEST)",
            "by sclab-apps-2.localdomain (Postfix, from userid 1318)\n\tid 81B0C2204C7; Mon, 22 Jun 2015 11:34:29 -0700 (PDT)"
        ],
        "X-CheckPoint": "{55885535-9-A3D4DA0C-C0000002}",
        "From": "Cyril Chemparathy <cchemparathy@ezchip.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 22 Jun 2015 11:34:17 -0700",
        "Message-Id": "<1434998063-15739-4-git-send-email-cchemparathy@ezchip.com>",
        "X-Mailer": "git-send-email 2.1.2",
        "In-Reply-To": "<1434998063-15739-1-git-send-email-cchemparathy@ezchip.com>",
        "References": "<1434998063-15739-1-git-send-email-cchemparathy@ezchip.com>",
        "Subject": "[dpdk-dev] [PATCH v4 3/9] ethdev: silence -Wcast-align on pointer\n\tarithmetic",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Statistics offsets in the rte_stats_strings[] array are always 64-bit aligned.\nHowever, the compiler is unaware of this fact and complains on -Wcast-align.\nThis patch modifies the code to use RTE_PTR_ADD(), thereby silencing the\ncompiler by casting through (void *).\n\nChange-Id: I6460b4b84b89dce6ac0b7b20e7002d53bcbd22db\nSigned-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>\n---\n lib/librte_ether/rte_ethdev.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex e13fde5..02cd07f 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1742,8 +1742,7 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n \tstruct rte_eth_stats eth_stats;\n \tstruct rte_eth_dev *dev;\n \tunsigned count, i, q;\n-\tuint64_t val;\n-\tchar *stats_ptr;\n+\tuint64_t val, *stats_ptr;\n \n \tif (!rte_eth_dev_is_valid_port(port_id)) {\n \t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n@@ -1770,8 +1769,9 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n \n \t/* global stats */\n \tfor (i = 0; i < RTE_NB_STATS; i++) {\n-\t\tstats_ptr = (char *)&eth_stats + rte_stats_strings[i].offset;\n-\t\tval = *(uint64_t *)stats_ptr;\n+\t\tstats_ptr = RTE_PTR_ADD(&eth_stats,\n+\t\t\t\t\trte_stats_strings[i].offset);\n+\t\tval = *stats_ptr;\n \t\tsnprintf(xstats[count].name, sizeof(xstats[count].name),\n \t\t\t\"%s\", rte_stats_strings[i].name);\n \t\txstats[count++].value = val;\n@@ -1780,10 +1780,10 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n \t/* per-rxq stats */\n \tfor (q = 0; q < dev->data->nb_rx_queues; q++) {\n \t\tfor (i = 0; i < RTE_NB_RXQ_STATS; i++) {\n-\t\t\tstats_ptr = (char *)&eth_stats;\n-\t\t\tstats_ptr += rte_rxq_stats_strings[i].offset;\n-\t\t\tstats_ptr += q * sizeof(uint64_t);\n-\t\t\tval = *(uint64_t *)stats_ptr;\n+\t\t\tstats_ptr = RTE_PTR_ADD(&eth_stats,\n+\t\t\t\t\trte_rxq_stats_strings[i].offset +\n+\t\t\t\t\tq * sizeof(uint64_t));\n+\t\t\tval = *stats_ptr;\n \t\t\tsnprintf(xstats[count].name, sizeof(xstats[count].name),\n \t\t\t\t\"rx_queue_%u_%s\", q,\n \t\t\t\trte_rxq_stats_strings[i].name);\n@@ -1794,10 +1794,10 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n \t/* per-txq stats */\n \tfor (q = 0; q < dev->data->nb_tx_queues; q++) {\n \t\tfor (i = 0; i < RTE_NB_TXQ_STATS; i++) {\n-\t\t\tstats_ptr = (char *)&eth_stats;\n-\t\t\tstats_ptr += rte_txq_stats_strings[i].offset;\n-\t\t\tstats_ptr += q * sizeof(uint64_t);\n-\t\t\tval = *(uint64_t *)stats_ptr;\n+\t\t\tstats_ptr = RTE_PTR_ADD(&eth_stats,\n+\t\t\t\t\trte_txq_stats_strings[i].offset +\n+\t\t\t\t\tq * sizeof(uint64_t));\n+\t\t\tval = *stats_ptr;\n \t\t\tsnprintf(xstats[count].name, sizeof(xstats[count].name),\n \t\t\t\t\"tx_queue_%u_%s\", q,\n \t\t\t\trte_txq_stats_strings[i].name);\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "3/9"
    ]
}