Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56670/?format=api
{ "id": 56670, "url": "https://patches.dpdk.org/api/patches/56670/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-3-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:35:56", "name": "[02/22] net/bnxt: fix return value check of address mapping", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1bf2e0b1e9ae16b5b3765ac6430c3a3db4e168ca", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "https://patches.dpdk.org/api/series/5581/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "https://patches.dpdk.org/series/5581/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56670/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/56670/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4CBE858C6;\n\tThu, 18 Jul 2019 05:36:31 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id A6FFD4C90;\n\tThu, 18 Jul 2019 05:36:27 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 1F7A830C39E;\n\tWed, 17 Jul 2019 20:36:25 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 0C7FEAC0761;\n\tWed, 17 Jul 2019 20:36:23 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 1F7A830C39E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563420985;\n\tbh=zi7Y16rHKDSPN6/6TxbBv7Ho4I2M2F6AFHiT63jNXQ0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Uci4B2M5azTWTI6yINiGZVkoVzBzVewhJYgUAlzVHG+gcqDHgdhRTQ+hoAIHqXq54\n\teGSc/r5jfkIrdLRj61wJJihsuHz4TLXHaVepwjfQmhtKXdMqh8+t5nKi4zVhOfLQBv\n\tioB3EhN9hmobM+cbjzauDw5b3Fnu+AXHpKyx/bZI=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:05:56 +0530", "Message-Id": "<20190718033616.37605-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/22] net/bnxt: fix return value check of\n\taddress mapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nrte_mem_virt2iova() function returns RTE_BAD_IOVA on failure, not zero.\n\nFixes: 62196f4e0941 (\"mem: rename address mapping function to IOVA\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 6 +++---\n drivers/net/bnxt/bnxt_hwrm.c | 16 ++++++++--------\n drivers/net/bnxt/bnxt_ring.c | 2 +-\n drivers/net/bnxt/bnxt_vnic.c | 4 ++--\n 4 files changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7290c4c33..a37ea93d9 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3472,7 +3472,7 @@ static int bnxt_alloc_ctx_mem_blk(__rte_unused struct bnxt *bp,\n \t\t\tPMD_DRV_LOG(WARNING,\n \t\t\t\t \"Using rte_mem_virt2iova()\\n\");\n \t\t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n-\t\t\tif (mz_phys_addr == 0) {\n+\t\t\tif (mz_phys_addr == RTE_BAD_IOVA) {\n \t\t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\t\"unable to map addr to phys memory\\n\");\n \t\t\t\treturn -ENOMEM;\n@@ -3698,7 +3698,7 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp)\n \t\tPMD_DRV_LOG(WARNING,\n \t\t\t \"Using rte_mem_virt2iova()\\n\");\n \t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n-\t\tif (mz_phys_addr == 0) {\n+\t\tif (mz_phys_addr == RTE_BAD_IOVA) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t \"Can't map address to physical memory\\n\");\n \t\t\treturn -ENOMEM;\n@@ -3736,7 +3736,7 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp)\n \t\tPMD_DRV_LOG(WARNING,\n \t\t\t \"Using rte_mem_virt2iova()\\n\");\n \t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n-\t\tif (mz_phys_addr == 0) {\n+\t\tif (mz_phys_addr == RTE_BAD_IOVA) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t \"Can't map address to physical memory\\n\");\n \t\t\treturn -ENOMEM;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 313459aaf..9c5e5ad77 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -888,7 +888,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\trte_mem_lock_page(bp->hwrm_cmd_resp_addr);\n \t\tbp->hwrm_cmd_resp_dma_addr =\n \t\t\trte_mem_virt2iova(bp->hwrm_cmd_resp_addr);\n-\t\tif (bp->hwrm_cmd_resp_dma_addr == 0) {\n+\t\tif (bp->hwrm_cmd_resp_dma_addr == RTE_BAD_IOVA) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\"Unable to map response buffer to physical memory.\\n\");\n \t\t\trc = -ENOMEM;\n@@ -925,7 +925,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t\trte_mem_lock_page(bp->hwrm_short_cmd_req_addr);\n \t\tbp->hwrm_short_cmd_req_dma_addr =\n \t\t\trte_mem_virt2iova(bp->hwrm_short_cmd_req_addr);\n-\t\tif (bp->hwrm_short_cmd_req_dma_addr == 0) {\n+\t\tif (bp->hwrm_short_cmd_req_dma_addr == RTE_BAD_IOVA) {\n \t\t\trte_free(bp->hwrm_short_cmd_req_addr);\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\"Unable to map buffer to physical memory.\\n\");\n@@ -2229,7 +2229,7 @@ int bnxt_alloc_hwrm_resources(struct bnxt *bp)\n \t\treturn -ENOMEM;\n \tbp->hwrm_cmd_resp_dma_addr =\n \t\trte_mem_virt2iova(bp->hwrm_cmd_resp_addr);\n-\tif (bp->hwrm_cmd_resp_dma_addr == 0) {\n+\tif (bp->hwrm_cmd_resp_dma_addr == RTE_BAD_IOVA) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map response address to physical memory\\n\");\n \t\treturn -ENOMEM;\n@@ -3179,7 +3179,7 @@ int bnxt_hwrm_func_buf_rgtr(struct bnxt *bp)\n \treq.req_buf_len = rte_cpu_to_le_16(HWRM_MAX_REQ_LEN);\n \treq.req_buf_page_addr0 =\n \t\trte_cpu_to_le_64(rte_mem_virt2iova(bp->pf.vf_req_buf));\n-\tif (req.req_buf_page_addr0 == 0) {\n+\tif (req.req_buf_page_addr0 == RTE_BAD_IOVA) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map buffer address to physical memory\\n\");\n \t\treturn -ENOMEM;\n@@ -3611,7 +3611,7 @@ int bnxt_get_nvram_directory(struct bnxt *bp, uint32_t len, uint8_t *data)\n \tif (buf == NULL)\n \t\treturn -ENOMEM;\n \tdma_handle = rte_mem_virt2iova(buf);\n-\tif (dma_handle == 0) {\n+\tif (dma_handle == RTE_BAD_IOVA) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map response address to physical memory\\n\");\n \t\treturn -ENOMEM;\n@@ -3646,7 +3646,7 @@ int bnxt_hwrm_get_nvram_item(struct bnxt *bp, uint32_t index,\n \t\treturn -ENOMEM;\n \n \tdma_handle = rte_mem_virt2iova(buf);\n-\tif (dma_handle == 0) {\n+\tif (dma_handle == RTE_BAD_IOVA) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map response address to physical memory\\n\");\n \t\treturn -ENOMEM;\n@@ -3700,7 +3700,7 @@ int bnxt_hwrm_flash_nvram(struct bnxt *bp, uint16_t dir_type,\n \t\treturn -ENOMEM;\n \n \tdma_handle = rte_mem_virt2iova(buf);\n-\tif (dma_handle == 0) {\n+\tif (dma_handle == RTE_BAD_IOVA) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map response address to physical memory\\n\");\n \t\treturn -ENOMEM;\n@@ -3764,7 +3764,7 @@ static int bnxt_hwrm_func_vf_vnic_query(struct bnxt *bp, uint16_t vf,\n \treq.max_vnic_id_cnt = rte_cpu_to_le_32(bp->pf.total_vnics);\n \treq.vnic_id_tbl_addr = rte_cpu_to_le_64(rte_mem_virt2iova(vnic_ids));\n \n-\tif (req.vnic_id_tbl_addr == 0) {\n+\tif (req.vnic_id_tbl_addr == RTE_BAD_IOVA) {\n \t\tHWRM_UNLOCK();\n \t\tPMD_DRV_LOG(ERR,\n \t\t\"unable to map VNIC ID table address to physical memory\\n\");\ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex ada748c05..a9952e02c 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -187,7 +187,7 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,\n \t\t\trte_mem_lock_page(((char *)mz->addr) + sz);\n \t\tmz_phys_addr_base = rte_mem_virt2iova(mz->addr);\n \t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n-\t\tif (mz_phys_addr == 0) {\n+\t\tif (mz_phys_addr == RTE_BAD_IOVA) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\"unable to map ring address to physical memory\\n\");\n \t\t\treturn -ENOMEM;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 20e5bf2d1..c652b8f03 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -153,9 +153,9 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \t\tPMD_DRV_LOG(WARNING,\n \t\t\t\"Using rte_mem_virt2iova()\\n\");\n \t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n-\t\tif (mz_phys_addr == 0) {\n+\t\tif (mz_phys_addr == RTE_BAD_IOVA) {\n \t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"unable to map vnic address to physical memory\\n\");\n+\t\t\t\t \"unable to map to physical memory\\n\");\n \t\t\treturn -ENOMEM;\n \t\t}\n \t}\n", "prefixes": [ "02/22" ] }