Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56546,
    "url": "https://patches.dpdk.org/api/patches/56546/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716185304.12592-12-arkadiuszx.kusztal@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190716185304.12592-12-arkadiuszx.kusztal@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190716185304.12592-12-arkadiuszx.kusztal@intel.com",
    "date": "2019-07-16T18:53:04",
    "name": "[v3,11/11] test: add RSA PKCS1_5 padding case when no padding selected",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0a293fe98206759c615dedf0d61cf32bac0c0c17",
    "submitter": {
        "id": 452,
        "url": "https://patches.dpdk.org/api/people/452/?format=api",
        "name": "Arkadiusz Kusztal",
        "email": "arkadiuszx.kusztal@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "https://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716185304.12592-12-arkadiuszx.kusztal@intel.com/mbox/",
    "series": [
        {
            "id": 5542,
            "url": "https://patches.dpdk.org/api/series/5542/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5542",
            "date": "2019-07-16T18:52:53",
            "name": "Rework API for RSA algorithm in asymmetric crypto",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/5542/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/56546/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/56546/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 086291BDF7;\n\tTue, 16 Jul 2019 20:53:43 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 487761BDE9\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 20:53:35 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Jul 2019 11:53:34 -0700",
            "from akusztax-mobl.ger.corp.intel.com ([10.104.116.184])\n\tby fmsmga002.fm.intel.com with ESMTP; 16 Jul 2019 11:53:32 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.64,271,1559545200\"; d=\"scan'208\";a=\"194985837\"",
        "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com, shallyv@marvell.com,\n\tArek Kusztal <arkadiuszx.kusztal@intel.com>",
        "Date": "Tue, 16 Jul 2019 20:53:04 +0200",
        "Message-Id": "<20190716185304.12592-12-arkadiuszx.kusztal@intel.com>",
        "X-Mailer": "git-send-email 2.19.1.windows.1",
        "In-Reply-To": "<20190716185304.12592-1-arkadiuszx.kusztal@intel.com>",
        "References": "<20190716185304.12592-1-arkadiuszx.kusztal@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3 11/11] test: add RSA PKCS1_5 padding case when\n\tno padding selected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds an example how to use padding none option with RSA.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n app/test/test_cryptodev_asym.c | 46 +++++++++++++++++++++++++++++++++---------\n 1 file changed, 37 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 0e1277b..fa5ddab 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -157,13 +157,15 @@ queue_ops_rsa_sign_verify(struct rte_cryptodev_asym_session *sess)\n }\n \n static int\n-queue_ops_rsa_enc_dec(struct rte_cryptodev_asym_session *sess)\n+queue_ops_rsa_enc_dec(struct rte_cryptodev_asym_session *sess,\n+\t\tenum rte_crypto_rsa_padding_type padding)\n {\n \tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n \tstruct rte_mempool *op_mpool = ts_params->op_mpool;\n \tuint8_t dev_id = ts_params->valid_devs[0];\n \tstruct rte_crypto_op *op, *result_op;\n \tstruct rte_crypto_asym_op *asym_op;\n+\tuint8_t input_buf[TEST_DATA_SIZE] = {0};\n \tuint8_t cipher_buf[TEST_DATA_SIZE] = {0};\n \tint ret, status = TEST_SUCCESS;\n \n@@ -180,11 +182,19 @@ queue_ops_rsa_enc_dec(struct rte_cryptodev_asym_session *sess)\n \t/* Compute encryption on the test vector */\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_ENCRYPT;\n \n-\tasym_op->rsa.message.data = rsaplaintext.data;\n \tasym_op->rsa.cipher.data = cipher_buf;\n \tasym_op->rsa.cipher.length = 0;\n-\tasym_op->rsa.message.length = rsaplaintext.len;\n-\tasym_op->rsa.pad = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n+\tasym_op->rsa.pad = padding;\n+\n+\tif (padding == RTE_CRYPTO_RSA_PADDING_NONE) {\n+\t\trsa_simulate_pkcs1_5_padding(0, input_buf, rsa_xform.rsa.n.length,\n+\t\t\t\trsaplaintext.data, rsaplaintext.len);\n+\t\tasym_op->rsa.message.length = rsa_xform.rsa.n.length;\n+\t\tasym_op->rsa.message.data = input_buf;\n+\t} else if (padding == RTE_CRYPTO_RSA_PADDING_PKCS1_5) {\n+\t\tasym_op->rsa.message.data = rsaplaintext.data;\n+\t\tasym_op->rsa.message.length = rsaplaintext.len;\n+\t}\n \n \tdebug_hexdump(stdout, \"message\", asym_op->rsa.message.data,\n \t\t      asym_op->rsa.message.length);\n@@ -215,7 +225,7 @@ queue_ops_rsa_enc_dec(struct rte_cryptodev_asym_session *sess)\n \t/* Use the resulted output as decryption Input vector*/\n \tasym_op = result_op->asym;\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;\n-\tasym_op->rsa.pad = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n+\tasym_op->rsa.pad = padding;\n \n \t/* Process crypto operation */\n \tif (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {\n@@ -233,6 +243,13 @@ queue_ops_rsa_enc_dec(struct rte_cryptodev_asym_session *sess)\n \t\tgoto error_exit;\n \t}\n \tstatus = TEST_SUCCESS;\n+\n+\tif (padding == RTE_CRYPTO_RSA_PADDING_NONE) {\n+\t\tresult_op->asym->rsa.message.length =\n+\t\t\trsa_simulate_strip_pkcs1_5_padding(result_op->asym->rsa.message.data,\n+\t\t\trsa_xform.rsa.n.length);\n+\t}\n+\n \tret = rsa_verify(&rsaplaintext, result_op);\n \tif (ret)\n \t\tstatus = TEST_FAILED;\n@@ -562,7 +579,7 @@ test_rsa_sign_verify(void)\n }\n \n static int\n-test_rsa_enc_dec(void)\n+test_rsa_enc_dec(enum rte_crypto_rsa_padding_type padding)\n {\n \tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n \tstruct rte_mempool *sess_mpool = ts_params->session_mpool;\n@@ -597,7 +614,7 @@ test_rsa_enc_dec(void)\n \t\tgoto error_exit;\n \t}\n \n-\tstatus = queue_ops_rsa_enc_dec(sess);\n+\tstatus = queue_ops_rsa_enc_dec(sess, padding);\n \n error_exit:\n \n@@ -610,6 +627,16 @@ test_rsa_enc_dec(void)\n }\n \n static int\n+test_rsa_enc_dec_padding_none(void) {\n+\treturn test_rsa_enc_dec(RTE_CRYPTO_RSA_PADDING_NONE);\n+}\n+\n+static int\n+test_rsa_enc_dec_padding_pkcs_1(void) {\n+\treturn test_rsa_enc_dec(RTE_CRYPTO_RSA_PADDING_PKCS1_5);\n+}\n+\n+static int\n test_rsa_sign_verify_crt(void)\n {\n \tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n@@ -692,7 +719,7 @@ test_rsa_enc_dec_crt(void)\n \t\tstatus = TEST_FAILED;\n \t\tgoto error_exit;\n \t}\n-\tstatus = queue_ops_rsa_enc_dec(sess);\n+\tstatus = queue_ops_rsa_enc_dec(sess, RTE_CRYPTO_RSA_PADDING_PKCS1_5);\n \n error_exit:\n \n@@ -1767,7 +1794,8 @@ static struct unit_test_suite cryptodev_openssl_asym_testsuite  = {\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_capability),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_dsa),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_dh_keygenration),\n-\t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_enc_dec),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_enc_dec_padding_none),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_enc_dec_padding_pkcs_1),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_sign_verify),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_enc_dec_crt),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_rsa_sign_verify_crt),\n",
    "prefixes": [
        "v3",
        "11/11"
    ]
}