Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56533/?format=api
{ "id": 56533, "url": "https://patches.dpdk.org/api/patches/56533/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716184234.29999-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716184234.29999-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716184234.29999-1-stephen@networkplumber.org", "date": "2019-07-16T18:42:34", "name": "[v2] testpmd: add option to not start device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "efb547e899c9e7ea6a4edbe100556ada14ecaba3", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716184234.29999-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 5540, "url": "https://patches.dpdk.org/api/series/5540/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5540", "date": "2019-07-16T18:42:34", "name": "[v2] testpmd: add option to not start device", "version": 2, "mbox": "https://patches.dpdk.org/series/5540/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56533/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/56533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6E9BC2BF5;\n\tTue, 16 Jul 2019 20:42:44 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 59CE12BF5\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 20:42:43 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id t16so9516445pfe.11\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 11:42:43 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb26sm26242717pfo.129.2019.07.16.11.42.41\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 16 Jul 2019 11:42:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=acEjw/u3Nygxf1FsmqRsxhGVHObSYy8SI4xgsuBmqWw=;\n\tb=vWOvKpdbgP9qRWi+d1/o8yoh0w6YcV4ML0FwmDJkbuWf7F1Xo6wl+waIFmSYBkUbvH\n\t1HlX/obPaJXsUCqU1YC1Y9QiVnP7kvOxTzNKnMhARETJirI/siD1I3uNHqXBohZrQj7C\n\tgZxdL8jvHzpRaSLUx9sj/Gc6Fr4Y4pscm7UEUuj3cEufOyeRmR88w3I+FvFS2avg3R08\n\twG4MMB87KIPF03Iuz56IFbVfJ64b5W9xAZjjO6MXr6NvpvOOsdOi9UYPPoW0VUsx0yBn\n\tcr8zlfiHqWqrYf3KdJTPq4bTt/rl9f5UNYuRevr/deBOZ0DCSPoWM22TOCd9OFSbzc4+\n\tr8zg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=acEjw/u3Nygxf1FsmqRsxhGVHObSYy8SI4xgsuBmqWw=;\n\tb=VjoGysQEk2P/pHzdGxFCrmsNYKSSDPnwpmGaiI6oGPo4cvzyHst09i6lXXQ7BWR6Fh\n\tLlDravWY24b8WYTtGzKN6aQqBzmfn9ESKDyUgp8FiQY8n/ZnhRNR69neEyRj7RDXMfbZ\n\tx54wONQkmbsG4RnV2kg0Kn2LIraig+0lVdMTc1lZ8KRZ6jBWnT+Iv41z20mPm0sCBtXj\n\tus00wXIJu5GR2EDP9w+hsOkXqm/4F2sxKFoQ7SXGpE6RwfKQs6pbRFliHLkCT8Xh3ki+\n\tHDBMiDNkGSUGP0wLtHbGRLzvoA4ikcTgFU3UxbtbFe4+yorNp34hL88IXdwF+w6TGnYO\n\ttuYQ==", "X-Gm-Message-State": "APjAAAVBnEz69PEBRWLwWlPORGtelv8wegqfTCSDwSib5hLdyeb7lf6U\n\to7nHnTYqrYTLx4uK7p2UWl/wp8aO", "X-Google-Smtp-Source": "APXvYqwf0njl3R40PvxgE6RCdMGP7+ov1TYHL5LxckviLFViyrrsv3EyW/+eGrjnGeD7o6iHg2qGyg==", "X-Received": "by 2002:a63:3fc9:: with SMTP id\n\tm192mr36577501pga.429.1563302562209; \n\tTue, 16 Jul 2019 11:42:42 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 16 Jul 2019 11:42:34 -0700", "Message-Id": "<20190716184234.29999-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] testpmd: add option to not start device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some configuration options can not be tested properly with testpmd\nbecause it automatically starts all ports. This makes it harder\nto test driver handling of configuration options:\n(for example rx_deferred_start).\n\nAdd new command line flag --disable-device-start which skips\nthe device start. The port can then be started manually later.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 -- add new option to guide in doc\n\n app/test-pmd/parameters.c | 4 ++++\n app/test-pmd/testpmd.c | 7 ++++++-\n app/test-pmd/testpmd.h | 1 +\n doc/guides/testpmd_app_ug/run_app.rst | 6 ++++++\n 4 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 16358ea00c9f..5244872c4aa8 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -174,6 +174,7 @@ usage(char* progname)\n \tprintf(\" --txonly-multi-flow: generate multiple flows in txonly mode\\n\");\n \tprintf(\" --disable-link-check: disable check on link status when \"\n \t \"starting/stopping ports.\\n\");\n+\tprintf(\" --disable-device-start: do not automatically start port\\n\");\n \tprintf(\" --no-lsc-interrupt: disable link status change interrupt.\\n\");\n \tprintf(\" --no-rmv-interrupt: disable device removal interrupt.\\n\");\n \tprintf(\" --bitrate-stats=N: set the logical core N to perform \"\n@@ -634,6 +635,7 @@ launch_args_parse(int argc, char** argv)\n \t\t{ \"txpkts\",\t\t\t1, 0, 0 },\n \t\t{ \"txonly-multi-flow\",\t\t0, 0, 0 },\n \t\t{ \"disable-link-check\",\t\t0, 0, 0 },\n+\t\t{ \"disable-device-start\",\t0, 0, 0 },\n \t\t{ \"no-lsc-interrupt\",\t\t0, 0, 0 },\n \t\t{ \"no-rmv-interrupt\",\t\t0, 0, 0 },\n \t\t{ \"print-event\",\t\t1, 0, 0 },\n@@ -1196,6 +1198,8 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\tno_flush_rx = 1;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"disable-link-check\"))\n \t\t\t\tno_link_check = 1;\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"disable-device-start\"))\n+\t\t\t\tno_device_start = 1;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"no-lsc-interrupt\"))\n \t\t\t\tlsc_interrupt = 0;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"no-rmv-interrupt\"))\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 3ed3523b791e..807ee0c823b8 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -339,6 +339,11 @@ uint8_t flow_isolate_all;\n */\n uint8_t no_link_check = 0; /* check by default */\n \n+/*\n+ * Don't automatically start all ports in interactive mode.\n+ */\n+uint8_t no_device_start = 0;\n+\n /*\n * Enable link status change notification\n */\n@@ -3288,7 +3293,7 @@ main(int argc, char** argv)\n \t\t}\n \t}\n \n-\tif (start_port(RTE_PORT_ALL) != 0)\n+\tif (!no_device_start && start_port(RTE_PORT_ALL) != 0)\n \t\trte_exit(EXIT_FAILURE, \"Start ports failed\\n\");\n \n \t/* set all ports to promiscuous mode by default */\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex e3a6f7c7178c..fd8dccdf08f1 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -321,6 +321,7 @@ extern uint8_t flow_isolate_all; /**< set by \"--flow-isolate-all */\n extern uint8_t mp_alloc_type;\n /**< set by \"--mp-anon\" or \"--mp-alloc\" parameter */\n extern uint8_t no_link_check; /**<set by \"--disable-link-check\" parameter */\n+extern uint8_t no_device_start; /**<set by \"--disable-device-start\" parameter */\n extern volatile int test_done; /* stop packet forwarding when set to 1. */\n extern uint8_t lsc_interrupt; /**< disabled by \"--no-lsc-interrupt\" parameter */\n extern uint8_t rmv_interrupt; /**< disabled by \"--no-rmv-interrupt\" parameter */\ndiff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst\nindex e7db52068623..d0d89b3a30db 100644\n--- a/doc/guides/testpmd_app_ug/run_app.rst\n+++ b/doc/guides/testpmd_app_ug/run_app.rst\n@@ -344,6 +344,12 @@ The command line options are:\n \n Disable check on link status when starting/stopping ports.\n \n+* ``--disable-device-start``\n+\n+ Do not automatically start all ports. This allows testing\n+ configuration of rx and tx queues before device is started\n+ for the first time.\n+\n * ``--no-lsc-interrupt``\n \n Disable LSC interrupts for all ports, even those supporting it.\n", "prefixes": [ "v2" ] }