Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56529,
    "url": "https://patches.dpdk.org/api/patches/56529/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716172741.21399-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190716172741.21399-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190716172741.21399-2-stephen@networkplumber.org",
    "date": "2019-07-16T17:27:39",
    "name": "[1/3] cfgfile: remove unnecessary initialization",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fa451531788a0684f67da06f5e0d116b56bcc461",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716172741.21399-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 5538,
            "url": "https://patches.dpdk.org/api/series/5538/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5538",
            "date": "2019-07-16T17:27:38",
            "name": "cfgfile: cleanup patches",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/5538/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/56529/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/56529/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE8B91B950;\n\tTue, 16 Jul 2019 19:27:55 +0200 (CEST)",
            "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 2558D3195\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 19:27:52 +0200 (CEST)",
            "by mail-pl1-f196.google.com with SMTP id 4so3500488pld.10\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 10:27:52 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tm6sm21173049pfb.151.2019.07.16.10.27.50\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 16 Jul 2019 10:27:50 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dcNLr0jir3vesF0krOzdG75kFT8Y5ChbO3SsnV4VN5w=;\n\tb=tMrb4Hbd72pDFNWH6Qzvkw6sheaxlMRpjbt/z+OxAMiqrOmQVg6j67yERYSBJLsAA7\n\tfc7Yihwh5tohwby8JLRowJrv4kQw6SJa3wyEvGoV6VHRiO1i/DliRF6RvG5AOBYFLJIi\n\tDRflWBA9zRGMpjJqOsrcC/uaVAilYLhcEIibedOQ/hMCH5/m7UI4RFYoyr43IpZ2rAL7\n\tMOvDALhgMyZdBOWziOVWeax4W5890f4lzUSnPLPN+/fbEdSDAR6zeOvPR2GkeTrQDCiK\n\t8qpIoLfYxqQ+b3LHqX9LtPQonb+qQY4OyV14zh6n+9g2MzEgPj80I/sDEwMEgTp/Cgvz\n\tIsFw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dcNLr0jir3vesF0krOzdG75kFT8Y5ChbO3SsnV4VN5w=;\n\tb=e3G8vxVzyu7HkKICaHlXS8SKOyVWFaP9QX5lOlCLmBDOb4xyR6cMUAKrRogvtTLb0C\n\th8rOVkiJKZS8E7MY286OoWSLaK5im4HixLqXwXtiHzreMGxnszZHep/xhhyM51nVHcRv\n\t7mzMg88S1YkxZ13iimxtzVUfDu0lz4wD6GvgenhqumWBRV0zEypT76AeGQ6PzlgKY5IE\n\tntruQ3O7FWliQIEPf9o3XMI95Rk9kmsDvCOWrhWI27DDR29OEhF/jtFbE1jteVvNEb4c\n\tXl8T4Y7uGLjXb5tA+KrXAfm9oy3lwbtlMUpPDYooKH9DhkRlZYXudlOZVcb1w1mPjnau\n\tmtkQ==",
        "X-Gm-Message-State": "APjAAAXLK7RKOlFcnYupgP7XXvQ57B3i1xgjtQeI+SuWdRW+jcRRRErd\n\tN/FCLXlC4zkfN2ik4B8Zcvw=",
        "X-Google-Smtp-Source": "APXvYqw6APnWUGsg1CPtqY3fBf3wMZoa5t+1bDveeNzZcsqd8+L61WlR1LP/1/BJo4P224YoMlclaw==",
        "X-Received": "by 2002:a17:902:e2:: with SMTP id\n\ta89mr37494646pla.210.1563298071393; \n\tTue, 16 Jul 2019 10:27:51 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "cristian.dumitrescu@intel.com",
        "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Tue, 16 Jul 2019 10:27:39 -0700",
        "Message-Id": "<20190716172741.21399-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190716172741.21399-1-stephen@networkplumber.org>",
        "References": "<20190716172741.21399-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 1/3] cfgfile: remove unnecessary initialization",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "No need to initialize variable if it is immediately overwritten.\nIt is better style not do unnecessary initialization with modern\ntools since it lets compiler and other static checkers detect\nuninitialized data.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_cfgfile/rte_cfgfile.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c\nindex f8e7627a5169..1ef298592fa5 100644\n--- a/lib/librte_cfgfile/rte_cfgfile.c\n+++ b/lib/librte_cfgfile/rte_cfgfile.c\n@@ -160,9 +160,9 @@ struct rte_cfgfile *\n rte_cfgfile_load_with_params(const char *filename, int flags,\n \t\t\t     const struct rte_cfgfile_parameters *params)\n {\n-\tchar buffer[CFG_NAME_LEN + CFG_VALUE_LEN + 4] = {0};\n+\tchar buffer[CFG_NAME_LEN + CFG_VALUE_LEN + 4];\n \tint lineno = 0;\n-\tstruct rte_cfgfile *cfg = NULL;\n+\tstruct rte_cfgfile *cfg;\n \n \tif (rte_cfgfile_check_params(params))\n \t\treturn NULL;\n@@ -174,7 +174,7 @@ rte_cfgfile_load_with_params(const char *filename, int flags,\n \tcfg = rte_cfgfile_create(flags);\n \n \twhile (fgets(buffer, sizeof(buffer), f) != NULL) {\n-\t\tchar *pos = NULL;\n+\t\tchar *pos;\n \t\tsize_t len = strnlen(buffer, sizeof(buffer));\n \t\tlineno++;\n \t\tif ((len >= sizeof(buffer) - 1) && (buffer[len-1] != '\\n')) {\n@@ -260,7 +260,7 @@ struct rte_cfgfile *\n rte_cfgfile_create(int flags)\n {\n \tint i;\n-\tstruct rte_cfgfile *cfg = NULL;\n+\tstruct rte_cfgfile *cfg;\n \n \tcfg = malloc(sizeof(*cfg));\n \n",
    "prefixes": [
        "1/3"
    ]
}