Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56520/?format=api
{ "id": 56520, "url": "https://patches.dpdk.org/api/patches/56520/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716154013.6974-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716154013.6974-7-stephen@networkplumber.org", "date": "2019-07-16T15:40:13", "name": "[6/6] net/iavf: use dynamic log type for tx/rx debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "08e601f580f641e674c68f179a09ba9a12d32783", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 5532, "url": "https://patches.dpdk.org/api/series/5532/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5532", "date": "2019-07-16T15:40:07", "name": "replace usage of LOGTYPE_PMD in Intel drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/5532/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56520/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF87E1BD62;\n\tTue, 16 Jul 2019 17:40:44 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id BF1221B9B5\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 17:40:34 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id a93so10298571pla.7\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 08:40:34 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb19sm20700833pgh.57.2019.07.16.08.40.32\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 16 Jul 2019 08:40:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=m57TkkJRUha/gcY2GGTqEdIPNieueH5Gbvxg0IHeSWQ=;\n\tb=cApj3yHpXlB1mFsHYybWq15nZwloCHEaJCsAnZcR2cZCSNiSErez6jEG+yVrb2BBSJ\n\t7vtYQpALPRz1Fp/z5Gt0F3xilQ4b8TDxZMHklyEkpRC2lRMNrQyqKYojRlW8nAYhigod\n\tw9Z7AHn45I/fR0aaVa/9cqkFJrCmyGs4OJbvEtCfVdi8sWNceG88WnXUHTGxIIR/7JOF\n\tae0hFT6QbYAOXmOU36Xp/4h6Nhuv2K29UzfRH3yLvSqZDo/xugiebWnAeLjJRheHIW+P\n\tpTzjsuoweBgQT+xJZtTW+bkhApLOco6djKCZoZlvSkCGt8e3qVCQNGMdWMywkaYLuojI\n\tglHA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=m57TkkJRUha/gcY2GGTqEdIPNieueH5Gbvxg0IHeSWQ=;\n\tb=RKJRKMPk82VYTg0RBZYVdM5BWUnAq1sk+ZaPOW/znK890SRsRUBxlzYC7HnI8MNU0G\n\tFkQUVN3I3kbuSbUJeoXXLcJf1C21rcNP26lZln0NwR7g+ojMzVHxZ9xuPwMMrk1qEgoS\n\twcf+TmijcKQMaQ1uM6ZGYFVRJVxYiiebXFmwUcLVGaN0GniiuiW075FAMc9ZAgse8Wna\n\tJum1TAUXlZWykEQ7PzH0NNQ8CfbUN/nUDcFibBTOzrtXxnLiMZHS3kzz6e+71foXxf+g\n\ttLg2mNJ1QnuBYNdMzZpihW4Fi5+J2Ea0tDWiu/587wvp5GA6w3re/ek5FJyw4+2r5hsn\n\th3Uw==", "X-Gm-Message-State": "APjAAAWeaiUhsKx800hcbmv0wwbK15GPWup7TANwcVHNMaqTvOTX5xMb\n\tJcDXiRDGzsqrXv2Xuy8wrzE=", "X-Google-Smtp-Source": "APXvYqzSnd4ule+kSlF8TblrooYzhVSYYzAOyANR5xAWRq9JeiLYXaSAkQDaXdFkMK2FpADU50PZeQ==", "X-Received": "by 2002:a17:902:2d01:: with SMTP id\n\to1mr37254916plb.105.1563291633988; \n\tTue, 16 Jul 2019 08:40:33 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com,\n\tqi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 16 Jul 2019 08:40:13 -0700", "Message-Id": "<20190716154013.6974-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190716154013.6974-1-stephen@networkplumber.org>", "References": "<20190716154013.6974-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 6/6] net/iavf: use dynamic log type for tx/rx\n\tdebug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The generic RTE_LOGTYPE_PMD is a historical relic and should\nnot be used. Every driver must dynamic log types.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/iavf/iavf_ethdev.c | 28 ++++++++++++++++++++++++++++\n drivers/net/iavf/iavf_log.h | 19 +++++++++++++------\n 2 files changed, 41 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 53dc05c78d1c..d019e6ad57cb 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -76,6 +76,16 @@ static int iavf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev,\n int iavf_logtype_init;\n int iavf_logtype_driver;\n \n+#ifdef RTE_LIBRTE_IAVF_DEBUG_RX\n+int iavf_logtype_rx;\n+#endif\n+#ifdef RTE_LIBRTE_IAVF_DEBUG_TX\n+int iavf_logtype_tx;\n+#endif\n+#ifdef RTE_LIBRTE_IAVF_DEBUG_TX_FREE\n+int iavf_logtype_tx_free;\n+#endif\n+\n static const struct rte_pci_id pci_id_iavf_map[] = {\n \t{ RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID, IAVF_DEV_ID_ADAPTIVE_VF) },\n \t{ .vendor_id = 0, /* sentinel */ },\n@@ -1419,6 +1429,24 @@ RTE_INIT(iavf_init_log)\n \tiavf_logtype_driver = rte_log_register(\"pmd.net.iavf.driver\");\n \tif (iavf_logtype_driver >= 0)\n \t\trte_log_set_level(iavf_logtype_driver, RTE_LOG_NOTICE);\n+\n+#ifdef RTE_LIBRTE_IAVF_DEBUG_RX\n+\tiavf_logtype_rx = rte_log_register(\"pmd.net.iavf.rx\");\n+\tif (iavf_logtype_rx >= 0)\n+\t\trte_log_set_level(iavf_logtype_rx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_IAVF_DEBUG_TX\n+\tiavf_logtype_tx = rte_log_register(\"pmd.net.iavf.tx\");\n+\tif (iavf_logtype_tx >= 0)\n+\t\trte_log_set_level(iavf_logtype_tx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_IAVF_DEBUG_TX_FREE\n+\tiavf_logtype_tx_free = rte_log_register(\"pmd.net.iavf.tx_free\");\n+\tif (iavf_logtype_tx_free >= 0)\n+\t\trte_log_set_level(iavf_logtype_tx_free, RTE_LOG_NOTICE);\n+#endif\n }\n \n /* memory func for base code */\ndiff --git a/drivers/net/iavf/iavf_log.h b/drivers/net/iavf/iavf_log.h\nindex f66c37041439..1088ec75f55b 100644\n--- a/drivers/net/iavf/iavf_log.h\n+++ b/drivers/net/iavf/iavf_log.h\n@@ -20,23 +20,30 @@ extern int iavf_logtype_driver;\n \tPMD_DRV_LOG_RAW(level, fmt \"\\n\", ## args)\n #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, \" >>\")\n \n+\n #ifdef RTE_LIBRTE_IAVF_DEBUG_RX\n-#define PMD_RX_LOG(level, fmt, args...) \\\n-\tRTE_LOG_DP(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int iavf_logtype_rx;\n+#define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, iavf_logtype_rx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_IAVF_DEBUG_TX\n-#define PMD_TX_LOG(level, fmt, args...) \\\n-\tRTE_LOG_DP(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int iavf_logtype_tx;\n+#define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, iavf_logtype_tx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_IAVF_DEBUG_TX_FREE\n-#define PMD_TX_FREE_LOG(level, fmt, args...) \\\n-\tRTE_LOG_DP(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int iavf_logtype_tx_free;\n+#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, iavf_logtype_tx_free,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n #endif\n", "prefixes": [ "6/6" ] }