Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56519/?format=api
{ "id": 56519, "url": "https://patches.dpdk.org/api/patches/56519/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716154013.6974-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716154013.6974-6-stephen@networkplumber.org", "date": "2019-07-16T15:40:12", "name": "[5/6] net/i40e: use dynamic log type for tx/rx debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5c9c683d60197deabea4ce8052e9f442990efea9", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 5532, "url": "https://patches.dpdk.org/api/series/5532/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5532", "date": "2019-07-16T15:40:07", "name": "replace usage of LOGTYPE_PMD in Intel drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/5532/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56519/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56519/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 594D81BCB8;\n\tTue, 16 Jul 2019 17:40:41 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 7E1A41B965\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 17:40:33 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id f25so9623971pgv.10\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 08:40:33 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb19sm20700833pgh.57.2019.07.16.08.40.31\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 16 Jul 2019 08:40:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mY0BtOrHH0mMkayclX1hB3mO/yRpPWthJPirvCx7vG8=;\n\tb=FUpWd9gZDZwdPr00t0fIn0KBpYu9yeV+RGdfedhMhF3JMRriu3pl3a04nzAb18nR6Y\n\tTqzQ0OLHfgx+KvmgoC5/5r/CaAs/6/1/HqiL3JGIPfRFsSi1yRa3Bb+79bU668cmhT8T\n\tuzbVUpXqGSlerU8LkYd5u8gdeUowzrKxeFcFCYoNo3VBQp1364H5nvSgJ6FvkxMgItkl\n\tJuqdjOgcXojRE48kwst0Ny4yj/zVUseKvP34cHx+otQHs0/2ERnanKaCvJWCmmYyU4IS\n\tYm3QMBD1SJ+9SBy2Os2GKsYH5xgJN4Kk832aZW5yQIKGDu3hnA1WW/FArna/wNzHHEm6\n\tfw2w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mY0BtOrHH0mMkayclX1hB3mO/yRpPWthJPirvCx7vG8=;\n\tb=nvUr0EM6tlmhu3YticYkGzoV7eDtLpU4CNggCZ6fp+v9e7YGXA/NAEJx3JrSX24geT\n\teWvbwpQEhSS0hM6GVahqTLuftN4BQhwG5gldSkwiNJ9omH2ucm08TPHy5ltt4SgtXs7k\n\tUimUOWlejpp7wO2LsEF2eJ7cQpOF7oxCunR7FhlpCw3n4IrFLZNAYoxAMjMQ2WI5yX7o\n\tzZvT7Mn64LHWen9qA8PvVrb3CkCaW/VpgrkZ83Q3tZQFiLYMnvh7W3JAk6kYQAIxfUhj\n\tqjgQW0tilABD7FFWP7D8QXuO8Tua2TKwHF5BwXUCX/l9QiziRWim2u8y8TCq4lL7GHVZ\n\tZj0Q==", "X-Gm-Message-State": "APjAAAUeQQM3kx5BMyeBBOzor2D+fMYBBIhwLpdlNuBEKB7S9CP4vwfm\n\tjHcT+h13KIL+wIdoEjRlxBU=", "X-Google-Smtp-Source": "APXvYqytLtEcZQV6j4S7cbOihtvJr3FqnhreOuZejId7NDb3phFFA3N/WDieM1jTqBEjzyQ0ISVyRQ==", "X-Received": "by 2002:a17:90a:1b0c:: with SMTP id\n\tq12mr37785382pjq.76.1563291632743; \n\tTue, 16 Jul 2019 08:40:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com,\n\tqi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 16 Jul 2019 08:40:12 -0700", "Message-Id": "<20190716154013.6974-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190716154013.6974-1-stephen@networkplumber.org>", "References": "<20190716154013.6974-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/6] net/i40e: use dynamic log type for tx/rx\n\tdebug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The generic RTE_LOGTYPE_PMD is a historical relic and should\nnot be used. Every driver must dynamic log types.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/i40e/i40e_ethdev.c | 27 +++++++++++++++++++++++++++\n drivers/net/i40e/i40e_logs.h | 24 +++++++++++++++---------\n 2 files changed, 42 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 2b9fc4572290..1e168c6253d8 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -399,6 +399,15 @@ static void i40e_notify_all_vfs_link_status(struct rte_eth_dev *dev);\n \n int i40e_logtype_init;\n int i40e_logtype_driver;\n+#ifdef RTE_LIBRTE_I40E_DEBUG_RX\n+int i40e_logtype_rx;\n+#endif\n+#ifdef RTE_LIBRTE_I40E_DEBUG_TX\n+int i40e_logtype_tx;\n+#endif\n+#ifdef RTE_LIBRTE_I40E_DEBUG_TX_FREE\n+int i40e_logtype_tx_free;\n+#endif\n \n static const char *const valid_keys[] = {\n \tETH_I40E_FLOATING_VEB_ARG,\n@@ -12766,6 +12775,24 @@ RTE_INIT(i40e_init_log)\n \ti40e_logtype_driver = rte_log_register(\"pmd.net.i40e.driver\");\n \tif (i40e_logtype_driver >= 0)\n \t\trte_log_set_level(i40e_logtype_driver, RTE_LOG_NOTICE);\n+\n+#ifdef RTE_LIBRTE_I40E_DEBUG_RX\n+\ti40e_logtype_rx = rte_log_register(\"pmd.net.i40e.rx\");\n+\tif (i40e_logtype_rx >= 0)\n+\t\trte_log_set_level(i40e_logtype_rx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_I40E_DEBUG_TX\n+\ti40e_logtype_tx = rte_log_register(\"pmd.net.i40e.tx\");\n+\tif (i40e_logtype_tx >= 0)\n+\t\trte_log_set_level(i40e_logtype_tx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_I40E_DEBUG_TX_FREE\n+\ti40e_logtype_tx_free = rte_log_register(\"pmd.net.i40e.tx_free\");\n+\tif (i40e_logtype_tx_free >= 0)\n+\t\trte_log_set_level(i40e_logtype_tx_free, RTE_LOG_NOTICE);\n+#endif\n }\n \n RTE_PMD_REGISTER_PARAM_STRING(net_i40e,\ndiff --git a/drivers/net/i40e/i40e_logs.h b/drivers/net/i40e/i40e_logs.h\nindex b1049699352f..dac3267eb4e2 100644\n--- a/drivers/net/i40e/i40e_logs.h\n+++ b/drivers/net/i40e/i40e_logs.h\n@@ -12,24 +12,30 @@ extern int i40e_logtype_init;\n #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, \" >>\")\n \n #ifdef RTE_LIBRTE_I40E_DEBUG_RX\n-#define PMD_RX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int i40e_logtype_rx;\n+#define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, i40e_logtype_rx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n-#define PMD_RX_LOG(level, fmt, args...) do { } while(0)\n+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_I40E_DEBUG_TX\n-#define PMD_TX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int i40e_logtype_tx;\n+#define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, i40e_logtype_tx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n-#define PMD_TX_LOG(level, fmt, args...) do { } while(0)\n+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_I40E_DEBUG_TX_FREE\n-#define PMD_TX_FREE_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int i40e_logtype_tx_free;\n+#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, i40e_logtype_tx_free,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n-#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while(0)\n+#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n extern int i40e_logtype_driver;\n", "prefixes": [ "5/6" ] }