Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56516/?format=api
{ "id": 56516, "url": "https://patches.dpdk.org/api/patches/56516/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716154013.6974-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716154013.6974-3-stephen@networkplumber.org", "date": "2019-07-16T15:40:09", "name": "[2/6] net/fm10k: use dynamic log type for tx/rx debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fbfe61440d6141d513c1fb8e94d8c83266ada481", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190716154013.6974-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5532, "url": "https://patches.dpdk.org/api/series/5532/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5532", "date": "2019-07-16T15:40:07", "name": "replace usage of LOGTYPE_PMD in Intel drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/5532/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56516/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4C9651B9AA;\n\tTue, 16 Jul 2019 17:40:33 +0200 (CEST)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 0755B1B964\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 17:40:29 +0200 (CEST)", "by mail-pl1-f196.google.com with SMTP id m9so10262635pls.8\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 08:40:29 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb19sm20700833pgh.57.2019.07.16.08.40.27\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 16 Jul 2019 08:40:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=UA4Cle0m0GWuH0sR5xi4HB1jiid4oFAG7LgHMgt3Avs=;\n\tb=N8lqBHQknRf2DpoiRGfdD/9BXphFjwJ/ZUGTCIM2yfuv2/aNGtfaNHs4ODQYACvk9a\n\tPV4d6HyGNZc6gV87hLnBfn7PWmSmUpwjQMHhjSFLE4TLtc1vUIZIjs52Uv8mSRjQ0QX9\n\tNcnOXsu+iF/Go2AQZixYx+Ud0y/tlm8e2mrgOMvYzh8KUhCtRknrUpTNbHT8j9Sz8D6s\n\t4Qi0ISXO6ebP3nINaqCitktNM5zZM2O2q44C7u0G3F6JT5rs9Z5swa818lSaIQ4i7Io8\n\tkZBHeL4P7CDrgMmzzLjHHK8BgQ8xAtqwfOt/g9gFZPpXEreGbg6/JeKOd8/Ib9rTPQP9\n\tnKDA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=UA4Cle0m0GWuH0sR5xi4HB1jiid4oFAG7LgHMgt3Avs=;\n\tb=GjoUdNpCbw8UQTbYv/TSXzRp4qZwgCbwh+j+1h2aQx5p7aWjIAgpsr+N7jm+JvwurA\n\tHjhst5CeQRHXJUAGnvpAUCXKIxM9UtH3hEfiGrCU4nfRexVZoC8F4XDKgzuBCVMPnOw6\n\t5ptmm2tnzxzZP/4IP78D0AeRblBGdpWUBkYdEdc1h7uILDL/RhjXGk08Gd9OuAQdDoNx\n\t/13j4jF58jR4UO6d/ByUEIbCaw3ARU35Z+f7M23w8McqHXDaL5TdojsEnYQb1Xfk/Ssw\n\t9bUZQweqX6INp3pLKgQPseutjtN/+G/pee/uJBgbfgxBJF8nhDvBpK7kpo4o66PTtQCY\n\tC/4w==", "X-Gm-Message-State": "APjAAAVRttQRGrVty3NLE7zC1VxlzXYUdoLlPFLxc9lNKHXbAx4isuvV\n\tBTxjknUJiIWplh/OFU0HshE=", "X-Google-Smtp-Source": "APXvYqyjID2lo+/22DP5BsK3TGLjf+420cb4BbNg8URuIx2SFxf8URUM5Ngbcrpue8ifa+l1jOL1pQ==", "X-Received": "by 2002:a17:902:9a85:: with SMTP id\n\tw5mr36543778plp.221.1563291628488; \n\tTue, 16 Jul 2019 08:40:28 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com,\n\tqi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 16 Jul 2019 08:40:09 -0700", "Message-Id": "<20190716154013.6974-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190716154013.6974-1-stephen@networkplumber.org>", "References": "<20190716154013.6974-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/6] net/fm10k: use dynamic log type for tx/rx\n\tdebug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The generic RTE_LOGTYPE_PMD is a historical relic and should\nnot be used. Every driver must dynamic log types.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 28 ++++++++++++++++++++++++++++\n drivers/net/fm10k/fm10k_logs.h | 18 ++++++++++++------\n 2 files changed, 40 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex a1e3836cb449..1f0a6286a57b 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -43,6 +43,16 @@\n int fm10k_logtype_init;\n int fm10k_logtype_driver;\n \n+#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+int fm10k_logtype_rx;\n+#endif\n+#ifdef RTE_LIBRTE_FM10K_DEBUG_TX\n+int fm10k_logtype_tx;\n+#endif\n+#ifdef RTE_LIBRTE_FM10K_DEBUG_TX_FREE\n+int fm10k_logtype_tx_free;\n+#endif\n+\n static void fm10k_close_mbx_service(struct fm10k_hw *hw);\n static void fm10k_dev_promiscuous_enable(struct rte_eth_dev *dev);\n static void fm10k_dev_promiscuous_disable(struct rte_eth_dev *dev);\n@@ -3286,4 +3296,22 @@ RTE_INIT(fm10k_init_log)\n \tfm10k_logtype_driver = rte_log_register(\"pmd.net.fm10k.driver\");\n \tif (fm10k_logtype_driver >= 0)\n \t\trte_log_set_level(fm10k_logtype_driver, RTE_LOG_NOTICE);\n+\n+#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+\tfm10k_logtype_rx = rte_log_register(\"pmd.net.fm10k.rx\");\n+\tif (fm10k_logtype_rx >= 0)\n+\t\trte_log_set_level(fm10k_logtype_rx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_FM10K_DEBUG_TX\n+\tfm10k_logtype_tx = rte_log_register(\"pmd.net.fm10k.tx\");\n+\tif (fm10k_logtype_tx >= 0)\n+\t\trte_log_set_level(fm10k_logtype_tx, RTE_LOG_NOTICE);\n+#endif\n+\n+#ifdef RTE_LIBRTE_FM10K_DEBUG_TX_FREE\n+\tfm10k_logtype_tx_free = rte_log_register(\"pmd.net.fm10k.tx_free\");\n+\tif (fm10k_logtype_tx_free >= 0)\n+\t\trte_log_set_level(fm10k_logtype_tx_free, RTE_LOG_NOTICE);\n+#endif\n }\ndiff --git a/drivers/net/fm10k/fm10k_logs.h b/drivers/net/fm10k/fm10k_logs.h\nindex df56a51cac48..9ae743d80678 100644\n--- a/drivers/net/fm10k/fm10k_logs.h\n+++ b/drivers/net/fm10k/fm10k_logs.h\n@@ -15,22 +15,28 @@ extern int fm10k_logtype_init;\n #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, \" >>\")\n \n #ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n-#define PMD_RX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int fm10k_logtype_rx;\n+#define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, fm10k_logtype_rx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_FM10K_DEBUG_TX\n-#define PMD_TX_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int fm10k_logtype_tx;\n+#define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, fm10k_logtype_tx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_FM10K_DEBUG_TX_FREE\n-#define PMD_TX_FREE_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+extern int fm10k_logtype_tx_free;\n+#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, fm10k_logtype_tx_free,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #else\n #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n #endif\n", "prefixes": [ "2/6" ] }