Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56318/?format=api
{ "id": 56318, "url": "https://patches.dpdk.org/api/patches/56318/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190711031154.16029-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190711031154.16029-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190711031154.16029-1-stephen@networkplumber.org", "date": "2019-07-11T03:11:54", "name": "octeontx2: do not put escape sequences in log", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b0e3708ed43652afbed6f1b85070bd7feef4fcc0", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190711031154.16029-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 5445, "url": "https://patches.dpdk.org/api/series/5445/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5445", "date": "2019-07-11T03:11:54", "name": "octeontx2: do not put escape sequences in log", "version": 1, "mbox": "https://patches.dpdk.org/series/5445/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56318/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/56318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 24FD92F42;\n\tThu, 11 Jul 2019 05:12:04 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id DCB2E2E81\n\tfor <dev@dpdk.org>; Thu, 11 Jul 2019 05:12:02 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id g2so2045505pfq.0\n\tfor <dev@dpdk.org>; Wed, 10 Jul 2019 20:12:02 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tx13sm4574180pfn.6.2019.07.10.20.12.00\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 10 Jul 2019 20:12:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AYW0ZVXUo5eJIWVE5yi5iKPtETGMN01jefNBEmshdtk=;\n\tb=pFZAXBzxgUf1OLbdC6uOGD/GWjokSm1TCiekV21CMCeWgfwmN0WP/Ep1x4TK9sSiwZ\n\tFpkin69rQ0e+s601IYAz0MViKeanejVcBYMwhdHHXDQItky0MjyuH9wf/Y3FnW8MZVOD\n\tWA0SoIp5rwun1rq9HWWEsb2qMWIIsT1GRhOO21Qv6Sewsq+3vfO+QQ/XHKZCxsbYWtDT\n\tHn3gOZS6jreJtyUjebFqvQ0xF4P7nB6mfpL4b8OTPKWT+FESSDyhAQ1Yx0pF3u/v8Diy\n\tAA0+W9hu+1uCs/HyFD5eEdURtlpptVsCt67wLq9s3Lwtanbyrpo1PlUbb+TQxhEjYD7c\n\tSyiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AYW0ZVXUo5eJIWVE5yi5iKPtETGMN01jefNBEmshdtk=;\n\tb=DzguqxqYbQwrYrKEfHIvdXio0OlWrlSzdds5jHpf1K7WPr59uckOJn+6qdq44hZRwt\n\t+iJ46sC5NhhvPno2/phovkNEUi5VX4uzqyaHmlRJW0P8uryz4O/F8pq3uUimX/f4xLmq\n\tYVpOXR07AvctSmUrkhMqyNxFkQsAogUfbGTcD5hbnocz4syDPfcUIXLNNv35tr6CHwer\n\t5XAZwfdn0axGVCFxJgIdMIff2gLlKQ2dx/HktKsGx5nylYKA1L8lK2dcqhAE/veIzE6J\n\tmjBmS831slR3ANmtpEM7vlfrLmwb8ipQlAywDtKkWZLvmDrFh95hKQqAsmRRqYdC/kJF\n\tEOVw==", "X-Gm-Message-State": "APjAAAXYuA218DPkBOZodopH2PXB9DlpeHlNAeEpFHOzCJs1wNyA5IWk\n\t/SGw4Gh6g4YR/Pn+CpXbrSw=", "X-Google-Smtp-Source": "APXvYqxuyXs2Jn1SHrxHIR+D6RcjO0O4tqBSBB7aqVu5CNomXQlP9hlNpPV5RkdfXUoy1qSAzVp0PA==", "X-Received": "by 2002:a17:90a:36a7:: with SMTP id\n\tt36mr2053012pjb.34.1562814721759; \n\tWed, 10 Jul 2019 20:12:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "jerinj@marvell.com,\n\tndabilpuram@marvell.com,\n\tvattunuru@marvell.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 10 Jul 2019 20:11:54 -0700", "Message-Id": "<20190711031154.16029-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] octeontx2: do not put escape sequences in log", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Putting color escape sequences in the log look pretty for the\ndeveloper but fails in real world DPDK usage. A real application\nwill put DPDK log to syslog, and syslog does not handle escape\nsequences.\n\nFixes: dd543124cd93 (\"common/octeontx2: add runtime log infra\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/octeontx2/otx2_common.h | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h\nindex cdb25d9ed203..e53d411f065d 100644\n--- a/drivers/common/octeontx2/otx2_common.h\n+++ b/drivers/common/octeontx2/otx2_common.h\n@@ -69,12 +69,9 @@ extern int otx2_logtype_tm;\n extern int otx2_logtype_tim;\n extern int otx2_logtype_dpi;\n \n-#define OTX2_CLNRM \"\\x1b[0m\"\n-#define OTX2_CLRED \"\\x1b[31m\"\n-\n-#define otx2_err(fmt, args...)\t\t\t\t\t\t\\\n-\tRTE_LOG(ERR, PMD, \"\"OTX2_CLRED\"%s():%u \" fmt OTX2_CLNRM\"\\n\",\t\\\n-\t\t\t\t__func__, __LINE__, ## args)\n+#define otx2_err(fmt, args...)\t\t\t\\\n+\tRTE_LOG(ERR, PMD, \"%s():%u \" fmt \"\\n\",\t\\\n+\t\t__func__, __LINE__, ## args)\n \n #define otx2_info(fmt, args...)\t\t\t\t\t\t\\\n \tRTE_LOG(INFO, PMD, fmt\"\\n\", ## args)\n", "prefixes": [] }