Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56252/?format=api
{ "id": 56252, "url": "https://patches.dpdk.org/api/patches/56252/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190708182614.1677-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190708182614.1677-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190708182614.1677-9-stephen@networkplumber.org", "date": "2019-07-08T18:26:11", "name": "[v9,08/11] net/virtio: use new ether addr parsing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4c770c28cf6f8bda1be0ff79a4684d0f2f76bd0c", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190708182614.1677-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 5401, "url": "https://patches.dpdk.org/api/series/5401/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5401", "date": "2019-07-08T18:26:03", "name": "ether: improvements and optimizations", "version": 9, "mbox": "https://patches.dpdk.org/series/5401/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56252/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/56252/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C6EF91BDF7;\n\tMon, 8 Jul 2019 20:26:45 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 3EF491B9D9\n\tfor <dev@dpdk.org>; Mon, 8 Jul 2019 20:26:32 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id a93so8703637pla.7\n\tfor <dev@dpdk.org>; Mon, 08 Jul 2019 11:26:32 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\to15sm18769295pgj.18.2019.07.08.11.26.30\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 08 Jul 2019 11:26:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+EmzYVztBuqkWPa3J9xFCquV2rAKQo18WvoWOlsEX30=;\n\tb=ydxH3IB4nYQFo/v1FZQfq1orexlv2KALzkMsCc+L9i2M2gkQ7v9dSzRXdCIthj8K4f\n\tiw0IuXbu3OMCNvzSlZ9Rd1lkfoAj6DuZtZrdFKDP1vAEqhtLoLMb+eJaUmH6TwHEehi4\n\tfY54j5gqV6WHD7sHwu9O85mQMOPK2BBBuOu60mLb3mNfU4VkDaU30R6HeSdxlxWNvocD\n\tLl748MIWCygxuPUz1UJsUzYwnx4ILY1BJNv+pK1H87FBYYIQJlN9h8EApwmyEtPsvq0Z\n\tza81lyQE8Pymx3bo3iA09Ri6xqtaPRK0Vy83Da7qqOpO7GN/9TffjnqS8FhYOwYaX6Ml\n\tOj8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+EmzYVztBuqkWPa3J9xFCquV2rAKQo18WvoWOlsEX30=;\n\tb=F35+hvrxsaHD7vkaPqzsg+jAOSQMnzVvJV3E7mAkM6SKhDJVw8KXiLkd7+fseGUBxp\n\tNRSV8PrhExDFkiKCvCzE1ZDjKcNEqkE6TrejlPC629P2uD59TF+sPr+KHwyEWd9EuMHa\n\te9Bobv/5nKUzzOsH8T+OWTnAFggPPQO3LnvGxGwHZx8i/xmRH6omBrewOJFQxRMIuKE8\n\tlYV1wwxVYm7kfEPvcSrGssUHfylQ35y+NRk2Srj11EVWvcohA++pWbOXKmi9UZTCgE2V\n\tcn16OWYT4zbs6J43VFroh7btZlXV8nQ482bbLWvRsj5eXsWlQPTqc398oXvY1ghMoM3z\n\t05nQ==", "X-Gm-Message-State": "APjAAAWz+bYzmsC91I9FaoZ4WKUEJbbFEkKXsAHZv8/f44eTHdh4v3iO\n\tp6lciG1XN8M7nOOvHWEsyoKHqwf7sPw=", "X-Google-Smtp-Source": "APXvYqw2PV/4EHFe7YDJ8/iN5uXfwYZuAtTc52l+l0YGez4RPn1aFjCwb/7W098tZLh8w3XmYiSSIA==", "X-Received": "by 2002:a17:902:6a88:: with SMTP id\n\tn8mr26824151plk.70.1562610391267; \n\tMon, 08 Jul 2019 11:26:31 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 8 Jul 2019 11:26:11 -0700", "Message-Id": "<20190708182614.1677-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190708182614.1677-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190708182614.1677-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 08/11] net/virtio: use new ether addr parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_ether_unformat_addr rather than sscanf.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex c3ab9a21d107..fab87eb5b60f 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -224,17 +224,13 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n static inline void\n parse_mac(struct virtio_user_dev *dev, const char *mac)\n {\n-\tint i, r;\n-\tuint32_t tmp[RTE_ETHER_ADDR_LEN];\n+\tstruct rte_ether_addr tmp;\n \n \tif (!mac)\n \t\treturn;\n \n-\tr = sscanf(mac, \"%x:%x:%x:%x:%x:%x\", &tmp[0],\n-\t\t\t&tmp[1], &tmp[2], &tmp[3], &tmp[4], &tmp[5]);\n-\tif (r == RTE_ETHER_ADDR_LEN) {\n-\t\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; ++i)\n-\t\t\tdev->mac_addr[i] = (uint8_t)tmp[i];\n+\tif (rte_ether_unformat_addr(mac, &tmp) == 0) {\n+\t\tmemcpy(dev->mac_addr, &tmp, RTE_ETHER_ADDR_LEN);\n \t\tdev->mac_specified = 1;\n \t} else {\n \t\t/* ignore the wrong mac, use random mac */\n", "prefixes": [ "v9", "08/11" ] }