Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56235/?format=api
{ "id": 56235, "url": "https://patches.dpdk.org/api/patches/56235/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190708160600.25939-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190708160600.25939-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190708160600.25939-1-stephen@networkplumber.org", "date": "2019-07-08T16:06:00", "name": "[RFC] net/memif: allow for full key size in socket name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "65c059a1ae44b3453023a7afea2580cd4f5c378f", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190708160600.25939-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 5399, "url": "https://patches.dpdk.org/api/series/5399/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5399", "date": "2019-07-08T16:06:00", "name": "[RFC] net/memif: allow for full key size in socket name", "version": 1, "mbox": "https://patches.dpdk.org/series/5399/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/56235/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/56235/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D3F53256;\n\tMon, 8 Jul 2019 18:06:10 +0200 (CEST)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 4D4D7324D\n\tfor <dev@dpdk.org>; Mon, 8 Jul 2019 18:06:08 +0200 (CEST)", "by mail-pl1-f196.google.com with SMTP id y8so3799740plr.12\n\tfor <dev@dpdk.org>; Mon, 08 Jul 2019 09:06:08 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm11766031pfg.89.2019.07.08.09.06.06\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 08 Jul 2019 09:06:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=KOO1RnIy/pE6mih/C76sAadXz0KJiXGUVQPw5ouVJs4=;\n\tb=odTHSgHEnallFSu5s6VAxsCl8eAVh5tifWxdBuE4Vx/dMwVQ+1J0S8fw/Y+iv5skq+\n\tfExHeSF90TuUIB0G/7pdFNejA07CJRzc9eL0yP+3IjYSuKdgnR3JdPEItz6DfrP0a11k\n\tyBrmZi3CXL10AtOCdya5MUHUsoPHXhfJdnlolAcW9Xlc9vjFJo62EBfaPaz+nJeP0WiV\n\tcSXVq1DuaxnpTM/M+8MMowqHBTCV5IGbYOJ8/splfpKtX2PZnfalvyZ+k6BwtO/dX0mq\n\tvHpQ3mb5ZNidFlJ7EWO1/swfBAqnX78nD7VifIQruM3OosVFnxpS29WthE7XKN83o5zg\n\tC7zQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=KOO1RnIy/pE6mih/C76sAadXz0KJiXGUVQPw5ouVJs4=;\n\tb=e+OEvcsTKZHEbiFYPEfklpz7YVbufFtfM4NWEwmo3IfD5DzqtA6gbpJd16UMfKrM3W\n\tFN/5Iuu/WauaKFqiHw3hcBLqhEviMS/UUFcGKfd5oiVFWUb9kepCebTlRThL95If0b/V\n\tLX0XGv1FKRh+/OPr4igRZb92+vt53h+fcsGBZ4ApmKkSuXn/jTlFJf5Ryy1JhxXNcwAJ\n\tXGx60BQy9xR40fvMTvsm8PRVh67825GzlD/Vs6S7zbp7UrzmSeAZUqgH2kUkyUv9MCGo\n\tV4obFpuVdcgxx2y+n0ez1ZyGRmWbabG7L7o8xH7lKw2+nPWitIskhF7v3vTmtpsbjIrc\n\tYNAQ==", "X-Gm-Message-State": "APjAAAXenX+CLxIJLrXIy+UPkOPQANcpG7ICev51ng1tf48oeKqgXU9u\n\t7NE3haBoOlCpGKWemMBTXwytC8iDLXc=", "X-Google-Smtp-Source": "APXvYqwk9WSt0WSztZncyYo1NAnLnHAXr7xmiq2R/88bh36LbgWKKuO+28WKPY8RE5RgOp49Hm4pdQ==", "X-Received": "by 2002:a17:902:a40c:: with SMTP id\n\tp12mr26046782plq.146.1562601967358; \n\tMon, 08 Jul 2019 09:06:07 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "jgrajcia@cisco.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 8 Jul 2019 09:06:00 -0700", "Message-Id": "<20190708160600.25939-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC] net/memif: allow for full key size in socket name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The key size for memif is 256 but the unix domain socket structure has\nspace for 100 bytes. Change it to use a larger buffer and not hard\ncode the keysize everywhere.\n\nNot sure what purpose of socket is anyway since there is no code\nwhich connects to it in the current tree anyway?\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nPatch is RFC since not tested and I don't use memif so not\ngoing to go further.\n\n drivers/net/memif/memif_socket.c | 30 +++++++++++++++++++-----------\n drivers/net/memif/memif_socket.h | 4 +++-\n 2 files changed, 22 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c\nindex 01a935f87c9f..fb69015694ba 100644\n--- a/drivers/net/memif/memif_socket.c\n+++ b/drivers/net/memif/memif_socket.c\n@@ -860,11 +860,16 @@ memif_listener_handler(void *arg)\n \t\trte_free(cc);\n }\n \n+#define MEMIF_SOCKET_UN_SIZE\t\\\n+\t(offsetof(struct sockaddr_un, sun_path) + MEMIF_SOCKET_KEY_LEN)\n+\n static struct memif_socket *\n-memif_socket_create(struct pmd_internals *pmd, char *key, uint8_t listener)\n+memif_socket_create(struct pmd_internals *pmd,\n+\t\t const char *key, uint8_t listener)\n {\n \tstruct memif_socket *sock;\n-\tstruct sockaddr_un un;\n+\tstruct sockaddr_un *un;\n+\tchar un_buf[MEMIF_SOCKET_UN_SIZE];\n \tint sockfd;\n \tint ret;\n \tint on = 1;\n@@ -876,23 +881,25 @@ memif_socket_create(struct pmd_internals *pmd, char *key, uint8_t listener)\n \t}\n \n \tsock->listener = listener;\n-\trte_memcpy(sock->filename, key, 256);\n+\tstrlcpy(sock->filename, key, MEMIF_SOCKET_KEY_LEN);\n \tTAILQ_INIT(&sock->dev_queue);\n \n \tif (listener != 0) {\n+\n \t\tsockfd = socket(AF_UNIX, SOCK_SEQPACKET, 0);\n \t\tif (sockfd < 0)\n \t\t\tgoto error;\n \n-\t\tun.sun_family = AF_UNIX;\n-\t\tmemcpy(un.sun_path, sock->filename,\n-\t\t\tsizeof(un.sun_path) - 1);\n+\t\tmemset(un_buf, 0, sizeof(un_buf));\n+\t\tun = (struct sockaddr_un *) un_buf;\n+\t\tun->sun_family = AF_UNIX;\n+\t\tstrlcpy(un->sun_path, sock->filename, MEMIF_SOCKET_KEY_LEN);\n \n \t\tret = setsockopt(sockfd, SOL_SOCKET, SO_PASSCRED, &on,\n \t\t\t\t sizeof(on));\n \t\tif (ret < 0)\n \t\t\tgoto error;\n-\t\tret = bind(sockfd, (struct sockaddr *)&un, sizeof(un));\n+\t\tret = bind(sockfd, (struct sockaddr *)un, MEMIF_SOCKET_UN_SIZE);\n \t\tif (ret < 0)\n \t\t\tgoto error;\n \t\tret = listen(sockfd, 1);\n@@ -928,9 +935,10 @@ static struct rte_hash *\n memif_create_socket_hash(void)\n {\n \tstruct rte_hash_parameters params = { 0 };\n+\n \tparams.name = MEMIF_SOCKET_HASH_NAME;\n \tparams.entries = 256;\n-\tparams.key_len = 256;\n+\tparams.key_len = MEMIF_SOCKET_KEY_LEN;;\n \tparams.hash_func = rte_jhash;\n \tparams.hash_func_init_val = 0;\n \treturn rte_hash_create(¶ms);\n@@ -945,7 +953,7 @@ memif_socket_init(struct rte_eth_dev *dev, const char *socket_filename)\n \tstruct pmd_internals *tmp_pmd;\n \tstruct rte_hash *hash;\n \tint ret;\n-\tchar key[256];\n+\tchar key[MEMIF_SOCKET_KEY_LEN];\n \n \thash = rte_hash_find_existing(MEMIF_SOCKET_HASH_NAME);\n \tif (hash == NULL) {\n@@ -956,8 +964,8 @@ memif_socket_init(struct rte_eth_dev *dev, const char *socket_filename)\n \t\t}\n \t}\n \n-\tmemset(key, 0, 256);\n-\trte_memcpy(key, socket_filename, strlen(socket_filename));\n+\tmemset(key, 0, MEMIF_SOCKET_KEY_LEN);\n+\tstrlcpy(key, socket_filename, MEMIF_SOCKET_KEY_LEN);\n \tret = rte_hash_lookup_data(hash, key, (void **)&socket);\n \tif (ret < 0) {\n \t\tsocket = memif_socket_create(pmd, key,\ndiff --git a/drivers/net/memif/memif_socket.h b/drivers/net/memif/memif_socket.h\nindex db293e200961..9f40f8d138bb 100644\n--- a/drivers/net/memif/memif_socket.h\n+++ b/drivers/net/memif/memif_socket.h\n@@ -79,9 +79,11 @@ struct memif_socket_dev_list_elt {\n };\n \n #define MEMIF_SOCKET_HASH_NAME\t\t\t\"memif-sh\"\n+#define MEMIF_SOCKET_KEY_LEN\t\t256\n+\n struct memif_socket {\n \tstruct rte_intr_handle intr_handle;\t/**< interrupt handle */\n-\tchar filename[256];\t\t\t/**< socket filename */\n+\tchar filename[MEMIF_SOCKET_KEY_LEN];\t/**< socket filename */\n \n \tTAILQ_HEAD(, memif_socket_dev_list_elt) dev_queue;\n \t/**< Queue of devices using this socket */\n", "prefixes": [ "RFC" ] }