Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55917/?format=api
{ "id": 55917, "url": "https://patches.dpdk.org/api/patches/55917/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190702221247.28391-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190702221247.28391-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190702221247.28391-10-stephen@networkplumber.org", "date": "2019-07-02T22:12:44", "name": "[v7,09/12] net/virtio: use new ether addr parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4c770c28cf6f8bda1be0ff79a4684d0f2f76bd0c", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190702221247.28391-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 5291, "url": "https://patches.dpdk.org/api/series/5291/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5291", "date": "2019-07-02T22:12:35", "name": "ether: improvements and optimizations", "version": 7, "mbox": "https://patches.dpdk.org/series/5291/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/55917/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/55917/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C92D1BE43;\n\tWed, 3 Jul 2019 00:13:11 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id E28591BE29\n\tfor <dev@dpdk.org>; Wed, 3 Jul 2019 00:13:04 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id 196so81505pgc.6\n\tfor <dev@dpdk.org>; Tue, 02 Jul 2019 15:13:04 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id q4sm25035pjq.27.2019.07.02.15.13.02\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 02 Jul 2019 15:13:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hwEmjfBCDm2MyBGuk9lC8m9EUUnn0LmDNhMzslFOsA0=;\n\tb=0kh2uWhgIed6rTYBhqbYu5oVjI+X+Vfzmx10KI1miXI2j5FBamNBYwKXs9jikuMq4I\n\tWrHtvXhpGHegpbL1u9MO6V2sH9gssFt7FR6B9uzOysxpn2rJcRw0VGE/FWZxZUqNrcLF\n\tJfOi5k00oAlRbutvdFSzcVgUDYBS4bl0Mg01xnNiNuHRF0iG9uz14fu9Vh6eL3wWD7Oo\n\tbtAku5NFFY8nzmeJafqkRZhrmPg4SOy4IEqUcDBAR3NuXSJOEtFEXYMFhc12CGFnRynu\n\tbYmGf/i3Nog5ZNvLfHGKp8CdpvKyeei0bOPODx5fzGnILWlqpqbAaKaMAP7GYueQQs5E\n\tk2lw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hwEmjfBCDm2MyBGuk9lC8m9EUUnn0LmDNhMzslFOsA0=;\n\tb=E2lXH8WPTIXDZ9+Jwhvcxpur9MCWYIsyEzwXD+xje7hN0JpCkVVxXpItIZaqwxvXQi\n\t3AqNlwGOWKznJbrriTZnbbdTGMd9BwgAwIj5QFh/pDbY9RQQSvXovZFikQDdrQqyahIu\n\tRAS2ergxErooyyyzCvSnLtCwMDnKpkIYgTSEp5V72N7K66JpaIPM5f2Vi/PKV7GEU+Jc\n\tK7063srKMqBXiGG56Etc+H0HsVNJJWaNL/dfQ5YSq+33laOkGKWI4PK5w/8IHA740g/p\n\tueoAcqSVWHHyijYtCzPMV8KMVqXuke6/4bRO2DePzkl0mtYRj7KKmXimYs00RTEvJmvZ\n\tj9Iw==", "X-Gm-Message-State": "APjAAAXqJXDbF3iwf3VxN/ggmlmQk6ckkzA58ut1pa3lw0AJSsJPlkpO\n\t4Sw5Yo29BH2FrNCh9ZRRFITHn9xv", "X-Google-Smtp-Source": "APXvYqxGOPnjxJdIv8T3hG3GWtDOg7BvBiDJxT5AQL34LCsTw87yTS3AKkCF7Z/ZS2D3T9xoTLoCOw==", "X-Received": "by 2002:a17:90a:b908:: with SMTP id\n\tp8mr8191208pjr.94.1562105583488; \n\tTue, 02 Jul 2019 15:13:03 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 2 Jul 2019 15:12:44 -0700", "Message-Id": "<20190702221247.28391-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190702221247.28391-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190702221247.28391-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 09/12] net/virtio: use new ether addr parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_ether_unformat_addr rather than sscanf.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex e743695e4510..0bac725e7cdd 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -225,17 +225,13 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n static inline void\n parse_mac(struct virtio_user_dev *dev, const char *mac)\n {\n-\tint i, r;\n-\tuint32_t tmp[RTE_ETHER_ADDR_LEN];\n+\tstruct rte_ether_addr tmp;\n \n \tif (!mac)\n \t\treturn;\n \n-\tr = sscanf(mac, \"%x:%x:%x:%x:%x:%x\", &tmp[0],\n-\t\t\t&tmp[1], &tmp[2], &tmp[3], &tmp[4], &tmp[5]);\n-\tif (r == RTE_ETHER_ADDR_LEN) {\n-\t\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; ++i)\n-\t\t\tdev->mac_addr[i] = (uint8_t)tmp[i];\n+\tif (rte_ether_unformat_addr(mac, &tmp) == 0) {\n+\t\tmemcpy(dev->mac_addr, &tmp, RTE_ETHER_ADDR_LEN);\n \t\tdev->mac_specified = 1;\n \t} else {\n \t\t/* ignore the wrong mac, use random mac */\n", "prefixes": [ "v7", "09/12" ] }