Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 55897,
    "url": "https://patches.dpdk.org/api/patches/55897/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190702165017.3802-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190702165017.3802-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190702165017.3802-3-stephen@networkplumber.org",
    "date": "2019-07-02T16:50:11",
    "name": "[v6,2/8] net/ether: add function to convert string to ethernet address",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "77f81e79cfbbca72f5ba988562d1de92233046c4",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190702165017.3802-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 5289,
            "url": "https://patches.dpdk.org/api/series/5289/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5289",
            "date": "2019-07-02T16:50:09",
            "name": "net/ether: enhancements and optimizations",
            "version": 6,
            "mbox": "https://patches.dpdk.org/series/5289/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/55897/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/55897/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33D881B9C0;\n\tTue,  2 Jul 2019 18:50:33 +0200 (CEST)",
            "from mail-pf1-f177.google.com (mail-pf1-f177.google.com\n\t[209.85.210.177]) by dpdk.org (Postfix) with ESMTP id E585A1B9A3\n\tfor <dev@dpdk.org>; Tue,  2 Jul 2019 18:50:28 +0200 (CEST)",
            "by mail-pf1-f177.google.com with SMTP id t16so8525333pfe.11\n\tfor <dev@dpdk.org>; Tue, 02 Jul 2019 09:50:28 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\th62sm14340230pgc.54.2019.07.02.09.50.26\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 02 Jul 2019 09:50:26 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=HT7fgvqo3DxGVdfkCgxmfvm3m5YXMqttimfnKXT3DRU=;\n\tb=Aqk4B0umBaFK5vxLhPf9q3zOU7i0Mq3HAItKSHJh+/jdTOCJTczyW7DW/ksmnlfydM\n\tiNLngsOfm+wfGXl/KXxb3waqRlv0yIYWZFS9weEzi7lSMWkXftq1b3xrTfaF19D/jdrH\n\tlwdQRgI3nKx5lEnODdrhT+uo6utHifRetWX0XSYnZQGxxS6SVzon5KpFrEmxBvOvIrls\n\tRk9/qP1dYW5LFLODdYiK1utAJfmDzrx24omXRt19nQVILmzOWHen67c100HFkqWj0SMw\n\t4/xtKG6Ggc8ku2Loo3x97XJOJ2uIEFIZIFycyA/Czx/1pIoi6ZRN+58FIwUcuAb9BWCu\n\thNxA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=HT7fgvqo3DxGVdfkCgxmfvm3m5YXMqttimfnKXT3DRU=;\n\tb=NtxhXNP+lU5QE8UJmvcCwWxePsvIsRnyKkmt6M/YR8Z4DalgWU022ai7IhKW3zYUBs\n\tCZS5lxedzBqMJ13pmcRmEzYxrmMZANszgQNvHK20XQBLTiVjFq5UDsK6xER8uHOveOcG\n\tit22XGFrmEcQ/EpIXStKc2T0Xw18mK6OOsEylYYr5W1H63wuDIL0aDOv8yaGIP1/HLv1\n\t8BRQESbxH9tNubGfy9UrNGB5UnCV+HcyVPYy+rYc6rcLd2gKFVwFFWM8SVYkgd/B/JBZ\n\t+soAE9PoTluH2U03NIu3JvJEr1P2rOfCiN8jf9QzOa0UiEuzxOaU5ur/txSSaIkVY/19\n\tC+vw==",
        "X-Gm-Message-State": "APjAAAVdxOJk+vclEcBqrs29Cik+WwH75nITRZUvg5KCCjxHJ6fHwIz3\n\tK4ITwwdEpJ68Bts6N0whkfE1FY2jq2Y=",
        "X-Google-Smtp-Source": "APXvYqzYvHLa8FINxvlvH6h3OWuCvcKzceabOwf76TzJmiALJw01Qo+oNFGnUCTn2g1uC82BqKdsUA==",
        "X-Received": "by 2002:a17:90a:8a91:: with SMTP id\n\tx17mr6684094pjn.95.1562086227726; \n\tTue, 02 Jul 2019 09:50:27 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>",
        "Date": "Tue,  2 Jul 2019 09:50:11 -0700",
        "Message-Id": "<20190702165017.3802-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190702165017.3802-1-stephen@networkplumber.org>",
        "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190702165017.3802-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v6 2/8] net/ether: add function to convert string\n\tto ethernet address",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Make a function that can be used in place of eth_aton_r\nto convert a string to rte_ether_addr. This function\nallows both byte (xx:xx:xx:xx:xx:xx) and word (XXXX:XXXX:XXXX)\nformat and has the same lack of error handling as the original.\n\nThis also allows ethdev to no longer have a hard dependency\non the cmdline library.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_net/rte_ether.c         | 47 ++++++++++++++++++++++++++++++\n lib/librte_net/rte_ether.h         | 14 +++++++++\n lib/librte_net/rte_net_version.map |  1 +\n 3 files changed, 62 insertions(+)",
    "diff": "diff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c\nindex 974fe815b335..acc8a0e938c5 100644\n--- a/lib/librte_net/rte_ether.c\n+++ b/lib/librte_net/rte_ether.c\n@@ -27,3 +27,50 @@ rte_ether_format_addr(char *buf, uint16_t size,\n \t\t eth_addr->addr_bytes[4],\n \t\t eth_addr->addr_bytes[5]);\n }\n+\n+/*\n+ * Like ether_aton_r but can handle either\n+ * XX:XX:XX:XX:XX:XX or XXXX:XXXX:XXXX\n+ */\n+int\n+rte_ether_unformat_addr(const char *s, struct rte_ether_addr *ea)\n+{\n+\tunsigned int o0, o1, o2, o3, o4, o5;\n+\tint n;\n+\n+\tn = sscanf(s, \"%x:%x:%x:%x:%x:%x\",\n+\t\t    &o0, &o1, &o2, &o3, &o4, &o5);\n+\n+\tif (n == 6) {\n+\t\tif (o0 > UINT8_MAX || o1 > UINT8_MAX || o2 > UINT8_MAX ||\n+\t\t    o3 > UINT8_MAX || o4 > UINT8_MAX || o5 > UINT8_MAX)\n+\t\t\treturn -1;\n+\n+\t\tea->addr_bytes[0] = o0;\n+\t\tea->addr_bytes[1] = o1;\n+\t\tea->addr_bytes[2] = o2;\n+\t\tea->addr_bytes[3] = o3;\n+\t\tea->addr_bytes[4] = o4;\n+\t\tea->addr_bytes[5] = o5;\n+\n+\t\treturn 0;\n+\t}\n+\n+\t/* Support the format XXXX:XXXX:XXXX */\n+\tn = sscanf(s, \"%x:%x:%x\", &o0, &o1, &o2);\n+\tif (n == 3) {\n+\t\tif (o0 > UINT16_MAX || o1 > UINT16_MAX || o2 > UINT16_MAX)\n+\t\t\treturn -1;\n+\n+\t\tea->addr_bytes[0] = o0 >> 8;\n+\t\tea->addr_bytes[1] = o0 & 0xff;\n+\t\tea->addr_bytes[2] = o1 >> 8;\n+\t\tea->addr_bytes[3] = o1 & 0xff;\n+\t\tea->addr_bytes[4] = o2 >> 8;\n+\t\tea->addr_bytes[5] = o2 & 0xff;\n+\t\treturn 0;\n+\t}\n+\t/* unknown format */\n+\n+\treturn -1;\n+}\ndiff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex 3caae0d98f6d..8edc7e217b25 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -250,6 +250,20 @@ static inline void rte_ether_addr_copy(const struct rte_ether_addr *ea_from,\n void\n rte_ether_format_addr(char *buf, uint16_t size,\n \t\t      const struct rte_ether_addr *eth_addr);\n+/**\n+ * Convert string with Ethernet address to an ether_addr.\n+ *\n+ * @param str\n+ *   A pointer to buffer contains the formatted MAC address.\n+ * @param eth_addr\n+ *   A pointer to a ether_addr structure.\n+ * @return\n+ *   0 if successful\n+ *   -1 and sets rte_errno if invalid string\n+ */\n+int __rte_experimental\n+rte_ether_unformat_addr(const char *str, struct rte_ether_addr *eth_addr);\n+\n /**\n  * Ethernet header: Contains the destination address, source address\n  * and frame type.\ndiff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map\nindex f1e1b84ab491..f4c915069d57 100644\n--- a/lib/librte_net/rte_net_version.map\n+++ b/lib/librte_net/rte_net_version.map\n@@ -25,4 +25,5 @@ EXPERIMENTAL {\n \n \trte_net_make_rarp_packet;\n \trte_net_skip_ip6_ext;\n+\trte_ether_unformat_addr;\n };\n",
    "prefixes": [
        "v6",
        "2/8"
    ]
}