Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55882/?format=api
{ "id": 55882, "url": "https://patches.dpdk.org/api/patches/55882/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/5bde45006c2891f9942e1545e8cecf226908a5e1.1562075933.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5bde45006c2891f9942e1545e8cecf226908a5e1.1562075933.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5bde45006c2891f9942e1545e8cecf226908a5e1.1562075933.git.dekelp@mellanox.com", "date": "2019-07-02T14:17:26", "name": "[v2] ethdev: support action with any config object type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c6574d6fdef0a6cb038884e2a8b7ecbbba1c9890", "submitter": { "id": 1082, "url": "https://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/5bde45006c2891f9942e1545e8cecf226908a5e1.1562075933.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 5284, "url": "https://patches.dpdk.org/api/series/5284/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5284", "date": "2019-07-02T14:17:26", "name": "[v2] ethdev: support action with any config object type", "version": 2, "mbox": "https://patches.dpdk.org/series/5284/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/55882/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/55882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFE671B9C0;\n\tTue, 2 Jul 2019 16:18:27 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 24C8A1B9BF\n\tfor <dev@dpdk.org>; Tue, 2 Jul 2019 16:18:26 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 2 Jul 2019 17:18:25 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x62EIOlB021525;\n\tTue, 2 Jul 2019 17:18:24 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, \n\tbernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com,\n\tviacheslavo@mellanox.com, arybchenko@solarflare.com", "Cc": "dev@dpdk.org, orika@mellanox.com", "Date": "Tue, 2 Jul 2019 17:17:26 +0300", "Message-Id": "<5bde45006c2891f9942e1545e8cecf226908a5e1.1562075933.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<1389143e204e85c90b4fc124f9e561f43f78175e.1561989889.git.dekelp@mellanox.com>", "References": "<1389143e204e85c90b4fc124f9e561f43f78175e.1561989889.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2] ethdev: support action with any config object\n\ttype", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In current implementation, an action which requires parameters\nmust accept them enclosed in a structure.\nSome actions require a single, trivial type parameter, but it still\nmust be enclosed in a structure.\nThis obligation results in multiple, action-specific structures, each\ncontaining a single trivial type parameter.\n\nThis patch introduces a new approach, allowing an action configuration\nobject of any type, trivial or a structure.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n\n---\nv2: Remove test-pmd code update from this patch.\n---\n\n---\n doc/guides/prog_guide/rte_flow.rst | 5 +++--\n lib/librte_ethdev/rte_flow.h | 11 ++++++-----\n 2 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex a34d012..67deed7 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -1213,8 +1213,9 @@ Matches an application specific 32 bit metadata item.\n Actions\n ~~~~~~~\n \n-Each possible action is represented by a type. Some have associated\n-configuration structures. Several actions combined in a list can be assigned\n+Each possible action is represented by a type.\n+An action can have an associated configuration object.\n+Several actions combined in a list can be assigned\n to a flow rule and are performed in order.\n \n They fall in three categories:\ndiff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex f3a8fb1..2232856 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -1244,9 +1244,10 @@ struct rte_flow_item {\n /**\n * Action types.\n *\n- * Each possible action is represented by a type. Some have associated\n- * configuration structures. Several actions combined in a list can be\n- * assigned to a flow rule and are performed in order.\n+ * Each possible action is represented by a type.\n+ * An action can have an associated configuration object.\n+ * Several actions combined in a list can be assigned\n+ * to a flow rule and are performed in order.\n *\n * They fall in three categories:\n *\n@@ -2136,11 +2137,11 @@ struct rte_flow_action_set_mac {\n *\n * A list of actions is terminated by a END action.\n *\n- * For simple actions without a configuration structure, conf remains NULL.\n+ * For simple actions without a configuration object, conf remains NULL.\n */\n struct rte_flow_action {\n \tenum rte_flow_action_type type; /**< Action type. */\n-\tconst void *conf; /**< Pointer to action configuration structure. */\n+\tconst void *conf; /**< Pointer to action configuration object. */\n };\n \n /**\n", "prefixes": [ "v2" ] }