Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5581/?format=api
{ "id": 5581, "url": "https://patches.dpdk.org/api/patches/5581/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1434709724-4574-6-git-send-email-maciejx.t.gajdzica@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1434709724-4574-6-git-send-email-maciejx.t.gajdzica@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1434709724-4574-6-git-send-email-maciejx.t.gajdzica@intel.com", "date": "2015-06-19T10:28:38", "name": "[dpdk-dev,v5,05/11] table: added hash_key16 table stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c13b2e162f506b42b613c701e12ee1d4db442c62", "submitter": { "id": 18, "url": "https://patches.dpdk.org/api/people/18/?format=api", "name": "Maciej Gajdzica", "email": "maciejx.t.gajdzica@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1434709724-4574-6-git-send-email-maciejx.t.gajdzica@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5581/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5581/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B730BC7D0;\n\tFri, 19 Jun 2015 12:37:15 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id C30BAC7C4\n\tfor <dev@dpdk.org>; Fri, 19 Jun 2015 12:37:13 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 19 Jun 2015 03:37:13 -0700", "from unknown (HELO stargo) ([10.217.248.233])\n\tby orsmga002.jf.intel.com with SMTP; 19 Jun 2015 03:37:10 -0700", "by stargo (sSMTP sendmail emulation);\n\tFri, 19 Jun 2015 12:35:50 +0200" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,643,1427785200\"; d=\"scan'208\";a=\"749562762\"", "From": "Maciej Gajdzica <maciejx.t.gajdzica@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 19 Jun 2015 12:28:38 +0200", "Message-Id": "<1434709724-4574-6-git-send-email-maciejx.t.gajdzica@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1434709724-4574-1-git-send-email-maciejx.t.gajdzica@intel.com>", "References": "<1434709724-4574-1-git-send-email-maciejx.t.gajdzica@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 05/11] table: added hash_key16 table stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added statistics for hash key16 table.\n\nSigned-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>\n---\n lib/librte_table/rte_table_hash_key16.c | 41 +++++++++++++++++++++++++++++++\n 1 file changed, 41 insertions(+)", "diff": "diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c\nindex f87ea0e..b936323 100644\n--- a/lib/librte_table/rte_table_hash_key16.c\n+++ b/lib/librte_table/rte_table_hash_key16.c\n@@ -46,6 +46,20 @@\n \n #define RTE_BUCKET_ENTRY_VALID\t\t\t\t\t\t0x1LLU\n \n+#ifdef RTE_TABLE_STATS_COLLECT\n+\n+#define RTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(table, val) \\\n+\ttable->stats.n_pkts_in += val\n+#define RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(table, val) \\\n+\ttable->stats.n_pkts_lookup_miss += val\n+\n+#else\n+\n+#define RTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(table, val)\n+#define RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(table, val)\n+\n+#endif\n+\n struct rte_bucket_4_16 {\n \t/* Cache line 0 */\n \tuint64_t signature[4 + 1];\n@@ -61,6 +75,8 @@ struct rte_bucket_4_16 {\n };\n \n struct rte_table_hash {\n+\tstruct rte_table_stats stats;\n+\n \t/* Input parameters */\n \tuint32_t n_buckets;\n \tuint32_t n_entries_per_bucket;\n@@ -831,6 +847,9 @@ rte_table_hash_lookup_key16_lru(\n \tuint32_t pkt11_index, pkt20_index, pkt21_index;\n \tuint64_t pkts_mask_out = 0;\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -845,6 +864,7 @@ rte_table_hash_lookup_key16_lru(\n \t\t}\n \n \t\t*lookup_hit_mask = pkts_mask_out;\n+\t\tRTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \t\treturn 0;\n \t}\n \n@@ -934,6 +954,7 @@ rte_table_hash_lookup_key16_lru(\n \t\tbucket20, bucket21, pkts_mask_out, entries, f);\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key16_lru() */\n \n@@ -954,6 +975,9 @@ rte_table_hash_lookup_key16_ext(\n \tstruct rte_bucket_4_16 *buckets[RTE_PORT_IN_BURST_SIZE_MAX];\n \tuint64_t *keys[RTE_PORT_IN_BURST_SIZE_MAX];\n \n+\t__rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);\n+\tRTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(f, n_pkts_in);\n+\n \t/* Cannot run the pipeline with less than 5 packets */\n \tif (__builtin_popcountll(pkts_mask) < 5) {\n \t\tfor ( ; pkts_mask; ) {\n@@ -1080,15 +1104,31 @@ grind_next_buckets:\n \t}\n \n \t*lookup_hit_mask = pkts_mask_out;\n+\tRTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));\n \treturn 0;\n } /* rte_table_hash_lookup_key16_ext() */\n \n+static int\n+rte_table_hash_key16_stats_read(void *table, struct rte_table_stats *stats, int clear)\n+{\n+\tstruct rte_table_hash *t = (struct rte_table_hash *) table;\n+\n+\tif (stats != NULL)\n+\t\tmemcpy(stats, &t->stats, sizeof(t->stats));\n+\n+\tif (clear)\n+\t\tmemset(&t->stats, 0, sizeof(t->stats));\n+\n+\treturn 0;\n+}\n+\n struct rte_table_ops rte_table_hash_key16_lru_ops = {\n \t.f_create = rte_table_hash_create_key16_lru,\n \t.f_free = rte_table_hash_free_key16_lru,\n \t.f_add = rte_table_hash_entry_add_key16_lru,\n \t.f_delete = rte_table_hash_entry_delete_key16_lru,\n \t.f_lookup = rte_table_hash_lookup_key16_lru,\n+\t.f_stats = rte_table_hash_key16_stats_read,\n };\n \n struct rte_table_ops rte_table_hash_key16_ext_ops = {\n@@ -1097,4 +1137,5 @@ struct rte_table_ops rte_table_hash_key16_ext_ops = {\n \t.f_add = rte_table_hash_entry_add_key16_ext,\n \t.f_delete = rte_table_hash_entry_delete_key16_ext,\n \t.f_lookup = rte_table_hash_lookup_key16_ext,\n+\t.f_stats = rte_table_hash_key16_stats_read,\n };\n", "prefixes": [ "dpdk-dev", "v5", "05/11" ] }