Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55636/?format=api
{ "id": 55636, "url": "https://patches.dpdk.org/api/patches/55636/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190628182354.228-32-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190628182354.228-32-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190628182354.228-32-pbhagavatula@marvell.com", "date": "2019-06-28T18:23:42", "name": "[v3,31/42] event/octeontx2: add devargs to modify chunk slots", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "17af9f8d6131813bcf8564bbf14976868871222f", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190628182354.228-32-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 5227, "url": "https://patches.dpdk.org/api/series/5227/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5227", "date": "2019-06-28T18:23:11", "name": "OCTEONTX2 event device driver", "version": 3, "mbox": "https://patches.dpdk.org/series/5227/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/55636/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/55636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9AA801BB15;\n\tFri, 28 Jun 2019 20:25:36 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3AC8D1BA56\n\tfor <dev@dpdk.org>; Fri, 28 Jun 2019 20:25:15 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx5SIPEFm014540; Fri, 28 Jun 2019 11:25:14 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2tdkg191m9-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tFri, 28 Jun 2019 11:25:14 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com\n\t(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tFri, 28 Jun 2019 11:25:11 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Fri, 28 Jun 2019 11:25:11 -0700", "from BG-LT7430.marvell.com (unknown [10.28.17.12])\n\tby maili.marvell.com (Postfix) with ESMTP id 2D7E13F7040;\n\tFri, 28 Jun 2019 11:25:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=9HUwf3YZ5dcDN44ksUF0KovFQY44NdECnh05FQWW4vk=;\n\tb=aioj/m1bPhZCw5le2dFcJJm6/pgsgu21Ot9+/cGPFwfAS9YQ3/RyJDDThGOdsUUExpyK\n\t1KUXvNjserhahqux+duLIXIZPhdcUB1tenKT/hEwOzuaMVd45hJ7HGduLePVZeFArmZA\n\tUvaGmNqCZoe3VVImzCRZjt3/wyXiTYVihVfyi0JvJC0Yodn5t5x9ltch0J0mfrwKGIA2\n\tTzhGs2/0dvLU5NCQKFjQeriypA20Y5dltReTR0VeG9UjsR/1HohtEjutGL6edxUtjrCV\n\t9aYRduNLjxY2RL5+vzmJaX4DwnkBo59G/OYEasLxt16r/qnAi7LTuZF0xGiXMGAFJVSM\n\tCQ== ", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"John\n\tMcNamara\" <john.mcnamara@intel.com>, Marko Kovacevic\n\t<marko.kovacevic@intel.com>", "CC": "<dev@dpdk.org>", "Date": "Fri, 28 Jun 2019 23:53:42 +0530", "Message-ID": "<20190628182354.228-32-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190628182354.228-1-pbhagavatula@marvell.com>", "References": "<20190628182354.228-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-28_08:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v3 31/42] event/octeontx2: add devargs to modify\n\tchunk slots", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd devargs support to modify number of chunk slots. Chunks are used to\nstore event timers, a chunk can be visualised as an array where the last\nelement points to the next chunk and rest of them are used to store\nevents. TIM traverses the list of chunks and enqueues the event timers\nto SSO.\nIf no argument is passed then a default value of 255 is taken.\nExample:\n\n\t--dev \"0002:0e:00.0,tim_chnk_slots=511\"\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n doc/guides/eventdevs/octeontx2.rst | 11 +++++++++++\n drivers/event/octeontx2/otx2_tim_evdev.c | 14 +++++++++++++-\n drivers/event/octeontx2/otx2_tim_evdev.h | 4 ++++\n 3 files changed, 28 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/eventdevs/octeontx2.rst b/doc/guides/eventdevs/octeontx2.rst\nindex d24f81629..1e79bd916 100644\n--- a/doc/guides/eventdevs/octeontx2.rst\n+++ b/doc/guides/eventdevs/octeontx2.rst\n@@ -103,6 +103,17 @@ Runtime Config Options\n \n --dev \"0002:0e:00.0,tim_disable_npa=1\"\n \n+- ``TIM modify chunk slots``\n+\n+ The ``tim_chnk_slots`` devargs can be used to modify number of chunk slots.\n+ Chunks are used to store event timers, a chunk can be visualised as an array\n+ where the last element points to the next chunk and rest of them are used to\n+ store events. TIM traverses the list of chunks and enqueues the event timers\n+ to SSO. The default value is 255 and the max value is 4095.\n+ For example::\n+\n+ --dev \"0002:0e:00.0,tim_chnk_slots=1023\"\n+\n Debugging Options\n ~~~~~~~~~~~~~~~~~\n \ndiff --git a/drivers/event/octeontx2/otx2_tim_evdev.c b/drivers/event/octeontx2/otx2_tim_evdev.c\nindex 4b9816676..c0a692bb5 100644\n--- a/drivers/event/octeontx2/otx2_tim_evdev.c\n+++ b/drivers/event/octeontx2/otx2_tim_evdev.c\n@@ -240,7 +240,7 @@ otx2_tim_ring_create(struct rte_event_timer_adapter *adptr)\n \ttim_ring->tck_nsec = RTE_ALIGN_MUL_CEIL(rcfg->timer_tick_ns, 10);\n \ttim_ring->max_tout = rcfg->max_tmo_ns;\n \ttim_ring->nb_bkts = (tim_ring->max_tout / tim_ring->tck_nsec);\n-\ttim_ring->chunk_sz = OTX2_TIM_RING_DEF_CHUNK_SZ;\n+\ttim_ring->chunk_sz = dev->chunk_sz;\n \tnb_timers = rcfg->nb_timers;\n \ttim_ring->disable_npa = dev->disable_npa;\n \n@@ -355,6 +355,7 @@ otx2_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags,\n }\n \n #define OTX2_TIM_DISABLE_NPA\t\"tim_disable_npa\"\n+#define OTX2_TIM_CHNK_SLOTS\t\"tim_chnk_slots\"\n \n static void\n tim_parse_devargs(struct rte_devargs *devargs, struct otx2_tim_evdev *dev)\n@@ -370,6 +371,8 @@ tim_parse_devargs(struct rte_devargs *devargs, struct otx2_tim_evdev *dev)\n \n \trte_kvargs_process(kvlist, OTX2_TIM_DISABLE_NPA,\n \t\t\t &parse_kvargs_flag, &dev->disable_npa);\n+\trte_kvargs_process(kvlist, OTX2_TIM_CHNK_SLOTS,\n+\t\t\t &parse_kvargs_value, &dev->chunk_slots);\n }\n \n void\n@@ -423,6 +426,15 @@ otx2_tim_init(struct rte_pci_device *pci_dev, struct otx2_dev *cmn_dev)\n \t\tgoto mz_free;\n \t}\n \n+\tif (dev->chunk_slots &&\n+\t dev->chunk_slots <= OTX2_TIM_MAX_CHUNK_SLOTS &&\n+\t dev->chunk_slots >= OTX2_TIM_MIN_CHUNK_SLOTS) {\n+\t\tdev->chunk_sz = (dev->chunk_slots + 1) *\n+\t\t\tOTX2_TIM_CHUNK_ALIGNMENT;\n+\t} else {\n+\t\tdev->chunk_sz = OTX2_TIM_RING_DEF_CHUNK_SZ;\n+\t}\n+\n \treturn;\n \n mz_free:\ndiff --git a/drivers/event/octeontx2/otx2_tim_evdev.h b/drivers/event/octeontx2/otx2_tim_evdev.h\nindex 0a0a0b4d8..9636d8414 100644\n--- a/drivers/event/octeontx2/otx2_tim_evdev.h\n+++ b/drivers/event/octeontx2/otx2_tim_evdev.h\n@@ -22,6 +22,8 @@\n #define OTX2_TIM_RING_DEF_CHUNK_SZ\t(4096)\n #define OTX2_TIM_CHUNK_ALIGNMENT\t(16)\n #define OTX2_TIM_NB_CHUNK_SLOTS(sz)\t(((sz) / OTX2_TIM_CHUNK_ALIGNMENT) - 1)\n+#define OTX2_TIM_MIN_CHUNK_SLOTS\t(0x1)\n+#define OTX2_TIM_MAX_CHUNK_SLOTS\t(0x1FFE)\n #define OTX2_TIM_MIN_TMO_TKS\t\t(256)\n \n enum otx2_tim_clk_src {\n@@ -54,9 +56,11 @@ struct otx2_tim_evdev {\n \tstruct rte_eventdev *event_dev;\n \tstruct otx2_mbox *mbox;\n \tuint16_t nb_rings;\n+\tuint32_t chunk_sz;\n \tuintptr_t bar2;\n \t/* Dev args */\n \tuint8_t disable_npa;\n+\tuint16_t chunk_slots;\n };\n \n struct otx2_tim_ring {\n", "prefixes": [ "v3", "31/42" ] }