Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55089/?format=api
{ "id": 55089, "url": "https://patches.dpdk.org/api/patches/55089/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619185746.26866-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619185746.26866-3-stephen@networkplumber.org", "date": "2019-06-19T18:57:40", "name": "[v3,2/8] kni: use netdev_alloc_skb", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "90099b272c4c852a8204644d5e9e81ec81b54c23", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5090, "url": "https://patches.dpdk.org/api/series/5090/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5090", "date": "2019-06-19T18:57:38", "name": "kni: cleanups and fixes", "version": 3, "mbox": "https://patches.dpdk.org/series/5090/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/55089/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/55089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2C1361D0F3;\n\tWed, 19 Jun 2019 20:58:04 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 2AB8F1D0D9\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 20:57:58 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id y72so168749pgd.8\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 11:57:58 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb8sm24774858pff.20.2019.06.19.11.57.56\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 11:57:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+OFQZiHQfZ8LMLFPBeuGB6NyWoetkG0/c/wPapE/X44=;\n\tb=JpyK/Sxjv08uv1gpqJ3ZWm1RGnqru91O2pvOtEYAhywzTxDNmt6vNTby6jI2M/cIXU\n\tz+GjpqRkmr2x8BIeD1kXVDmKlziG8BjSrtBh8CBtoH+rUvHzkZ/qF9SqvVA/wSU+PDIB\n\tfDmMdq6doEJQggycNipYOiLsjwPoySiGcgE+mhrlZODMtQyL24RYjwNV7GoYpn0ABtxd\n\t0/hgw4IdCg4WhxuyRY9o4219P3w0UpDuFlwsgsPhGbrBX8MTmYs03dBHkmlIQbQAidpM\n\tRIxpF4wWBiQEX+dln6rjktSewzmrEy+KIFsFNSE7VipcKqK4oWjSAeQzL+wFyYExcBuq\n\taTUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+OFQZiHQfZ8LMLFPBeuGB6NyWoetkG0/c/wPapE/X44=;\n\tb=jrCm8H/8r4xZTY4gAIAlNSwSviApAzDbucvahrhS4NgOuPjQ33KrJjYEAvB2DgMExm\n\tZKpGo0Lde+JaogtTosusyVpdm8F6DrAy4BR6VVx/HlWGk0E50n6JHdcWrQvhtc6+cBaM\n\tfJImwhuhd2oolbuI3ckYz6dpCmweUQ/NB1XHs8cZ3baF+wk6on3uC3O62ndeVshGgADr\n\tILWnCk0FA9ltKhfU5ramBU5gg2ZtieBKB6kSTDl+mwoioIT9lqK+pswsaBn7TL1TEgMu\n\tRbEo00e5hJGiGxsQK20bUm2GIgfbKUgFMa7tW5la3QVwCvwppO0vLONAgwZQBqGguk4o\n\tlBtQ==", "X-Gm-Message-State": "APjAAAVUR9a2xT63IPqya7nCgcPKvt+3vcGOXe/r7f82ThJ3nd6KFfCY\n\tD9pMOXMkvC/u7l+UZeJGP6+v6s8aY3Y=", "X-Google-Smtp-Source": "APXvYqyw+DCqr6SZ0crZeKbMrj6wbaYdrXKerRCCV2efaxXrF0mRs+d76IY6I8ext4pBI+1/RiMw0w==", "X-Received": "by 2002:a17:90a:2567:: with SMTP id\n\tj94mr12725877pje.121.1560970677051; \n\tWed, 19 Jun 2019 11:57:57 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 19 Jun 2019 11:57:40 -0700", "Message-Id": "<20190619185746.26866-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190619185746.26866-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190619185746.26866-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/8] kni: use netdev_alloc_skb", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nnetdev_alloc_skb is optimized to any alignment or setup\nof skb->dev that is required. The kernel has chosen to not pad\npackets on x86 (for many years), because it is faster.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_net.c | 17 +++--------------\n 1 file changed, 3 insertions(+), 14 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex c86337d099ab..cce5e7eb991f 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (!skb) {\n \t\t\t/* Update statistics */\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -368,7 +365,6 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->protocol = eth_type_trans(skb, dev);\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n@@ -512,26 +508,20 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (skb) {\n-\t\t\t/* Align IP on 16B boundary */\n-\t\t\tskb_reserve(skb, 2);\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n-\t\t\tskb->dev = dev;\n \t\t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \t\t\tdev_kfree_skb(skb);\n \t\t}\n \n \t\t/* Simulate real usage, allocate/copy skb twice */\n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (skb == NULL) {\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -550,7 +540,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n \t\tkni->stats.rx_bytes += len;\n", "prefixes": [ "v3", "2/8" ] }