Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54951,
    "url": "https://patches.dpdk.org/api/patches/54951/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1560937965-448702-1-git-send-email-asafp@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1560937965-448702-1-git-send-email-asafp@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1560937965-448702-1-git-send-email-asafp@mellanox.com",
    "date": "2019-06-19T09:52:45",
    "name": "net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "37726f34e0b58978d441254f235910360eb4c59c",
    "submitter": {
        "id": 1175,
        "url": "https://patches.dpdk.org/api/people/1175/?format=api",
        "name": "Asaf Penso",
        "email": "asafp@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "https://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1560937965-448702-1-git-send-email-asafp@mellanox.com/mbox/",
    "series": [
        {
            "id": 5080,
            "url": "https://patches.dpdk.org/api/series/5080/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5080",
            "date": "2019-06-19T09:52:45",
            "name": "net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/5080/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/54951/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/54951/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5ED3A1C2CA;\n\tWed, 19 Jun 2019 11:52:57 +0200 (CEST)",
            "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n\tby dpdk.org (Postfix) with ESMTP id 486E01C2C1;\n\tWed, 19 Jun 2019 11:52:56 +0200 (CEST)"
        ],
        "From": "Asaf Penso <asafp@mellanox.com>",
        "To": "yskoh@mellanox.com,\n\tshahafs@mellanox.com",
        "Cc": "dev@dpdk.org,\n\tsrinivas.narayan@att.com,\n\tstable@dpdk.org",
        "Date": "Wed, 19 Jun 2019 09:52:45 +0000",
        "Message-Id": "<1560937965-448702-1-git-send-email-asafp@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix condition for calling\n\tmlx5_link_update_unlocked_gset",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "mlx5_link_update uses the newer ethtool command\nETHTOOL_GLINKSETTINGS to determine interface capabilities but falls\nback to the older (deprecated) ETHTOOL_GSET command if the new\nmethod fails for any reason.\nThe older method only supports reporting of capabilities up to 40G.\n\nHowever, mlx5_link_update_unlocked_gs can return a failure for a\nnumber of reasons (including the link being down).\nUsing the older method in cases of transient failure of the method\ncan result in reporting of reduced capabilities to the application.\n\nThe older method (mlx5_link_update_unlocked_gset) should only be\ninvoked if the newer method returns EOPNOTSUPP.\n\nFixes: 7d2e32f7 (\"net/mlx5: fix ethtool link setting call order\")\nCc: stable@dpdk.org\n\nSigned-off-by: Asaf Penso <asafp@mellanox.com>\nReported-by: Srinivas Narayan <srinivas.narayan@att.com>\n---\n drivers/net/mlx5/mlx5_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex ac0500a..61e12cc 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -947,7 +947,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)\n \n \tdo {\n \t\tret = mlx5_link_update_unlocked_gs(dev, &dev_link);\n-\t\tif (ret)\n+\t\tif (ret == -ENOTSUP)\n \t\t\tret = mlx5_link_update_unlocked_gset(dev, &dev_link);\n \t\tif (ret == 0)\n \t\t\tbreak;\n",
    "prefixes": []
}